Skip to contentSkip to conversation

Patch "Input: iforce - validate number of endpoints before using them" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 27, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: iforce - validate number of endpoints before using them

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-iforce-validate-number-of-endpoints-before-using-them.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 59cf8bed44a79ec42303151dd014fdb6434254bb Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Thu, 16 Mar 2017 11:34:02 -0700
Subject: Input: iforce - validate number of endpoints before using them

From: Johan Hovold <[email protected]>

commit 59cf8bed44a79ec42303151dd014fdb6434254bb upstream.

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory that lie beyond the end of the endpoint array should a malicious device lack the expected endpoints.

---
 drivers/input/joystick/iforce/iforce-usb.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/input/joystick/iforce/iforce-usb.c +3 -0
@@ -141,6 +141,9 @@ static int iforce_usb_probe(struct usb_i
 
 	interface = intf->cur_altsetting;
 
+	if (interface->desc.bNumEndpoints < 2)
+		return -ENODEV;
+
 	epirq = &interface->endpoint[0].desc;
 	epout = &interface->endpoint[1].desc;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch queue-4.4/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch queue-4.4/input-cm109-validate-number-of-endpoints-before-using-them.patch queue-4.4/input-iforce-validate-number-of-endpoints-before-using-them.patch queue-4.4/mmc-ushc-fix-null-deref-at-probe.patch queue-4.4/input-kbtab-validate-number-of-endpoints-before-using-them.patch queue-4.4/input-sur40-validate-number-of-endpoints-before-using-them.patch queue-4.4/uwb-i1480-dfu-fix-null-deref-at-probe.patch queue-4.4/input-hanwang-validate-number-of-endpoints-before-using-them.patch queue-4.4/usb-idmouse-fix-null-deref-at-probe.patch queue-4.4/uwb-hwa-rc-fix-null-deref-at-probe.patch queue-4.4/usb-lvtest-fix-null-deref-at-probe.patch queue-4.4/input-yealink-validate-number-of-endpoints-before-using-them.patch queue-4.4/usb-serial-qcserial-add-dell-dw5811e.patch queue-4.4/usb-uss720-fix-null-deref-at-probe.patch queue-4.4/usb-wusbcore-fix-null-deref-at-probe.patch