Skip to contentSkip to conversation

Patch "USB: idmouse: fix NULL-deref at probe" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Mar 27, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: idmouse: fix NULL-deref at probe

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-idmouse-fix-null-deref-at-probe.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b0addd3fa6bcd119be9428996d5d4522479ab240 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 13 Mar 2017 13:47:48 +0100
Subject: USB: idmouse: fix NULL-deref at probe

From: Johan Hovold <[email protected]>

commit b0addd3fa6bcd119be9428996d5d4522479ab240 upstream.

Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/usb/misc/idmouse.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/usb/misc/idmouse.c +3 -0
@@ -346,6 +346,9 @@ static int idmouse_probe(struct usb_inte
 	if (iface_desc->desc.bInterfaceClass != 0x0A)
 		return -ENODEV;
 
+	if (iface_desc->desc.bNumEndpoints < 1)
+		return -ENODEV;
+
 	/* allocate memory for our device state and initialize it */
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 	if (dev == NULL)

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch queue-4.9/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch queue-4.9/usb-usbtmc-add-missing-endpoint-sanity-check.patch queue-4.9/input-cm109-validate-number-of-endpoints-before-using-them.patch queue-4.9/input-iforce-validate-number-of-endpoints-before-using-them.patch queue-4.9/mmc-ushc-fix-null-deref-at-probe.patch queue-4.9/input-kbtab-validate-number-of-endpoints-before-using-them.patch queue-4.9/usb-usbtmc-fix-probe-error-path.patch queue-4.9/input-sur40-validate-number-of-endpoints-before-using-them.patch queue-4.9/uwb-i1480-dfu-fix-null-deref-at-probe.patch queue-4.9/input-hanwang-validate-number-of-endpoints-before-using-them.patch queue-4.9/usb-idmouse-fix-null-deref-at-probe.patch queue-4.9/uwb-hwa-rc-fix-null-deref-at-probe.patch queue-4.9/usb-lvtest-fix-null-deref-at-probe.patch queue-4.9/input-yealink-validate-number-of-endpoints-before-using-them.patch queue-4.9/usb-serial-qcserial-add-dell-dw5811e.patch queue-4.9/usb-uss720-fix-null-deref-at-probe.patch queue-4.9/usb-wusbcore-fix-null-deref-at-probe.patch