Patch "iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3" has been added to the 4.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iio-hid-sensor-trigger-change-get-poll-value-function-order-to-avoid-sensor-properties-losing-after-resume-from-s3.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
3bec247474469f769af41e8c80d3a100dd97dd76Mon Sep 17 00:00:00 2001
From: Song Hongyan <[email protected]>
Date: Wed, 22 Feb 2017 17:17:38 +0800
Subject: iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3
From: Song Hongyan <[email protected]>
commit 3bec247474469f769af41e8c80d3a100dd97dd76 upstream.
In function _hid_sensor_power_state(), when hid_sensor_read_poll_value() is called, sensor's all properties will be updated by the value from sensor hardware/firmware.
In some implementation, sensor hardware/firmware will do a power cycle during S3. In this case, after resume, once hid_sensor_read_poll_value() is called, sensor's all properties which are kept by driver during S3 will be changed to default value.
But instead, if a set feature function is called first, sensor hardware/firmware will be recovered to the last status. So change the sensor_hub_set_feature() calling order to behind of set feature function to avoid sensor properties lose.
--- drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/common/hid-sensors/hid-sensor-trigger.c +3 -3
@@ -51,8 +51,6 @@ static int _hid_sensor_power_state(struc st->report_state.report_id, st->report_state.index, HID_USAGE_SENSOR_PROP_REPORTING_STATE_ALL_EVENTS_ENUM); - - poll_value =hid_sensor_read_poll_value (st); }else {int val;
@@ -89,7 +87,9 @@ static int _hid_sensor_power_state(strucsensor_hub_get_feature (st->hsdev, st->power_state.report_id, st->power_state.index,sizeof (state_val), &state_val); -if (state && poll_value) +if (state) + poll_value =hid_sensor_read_poll_value (st); +if (poll_value >0 )msleep_interruptible (poll_value *2 );return 0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/iio-hid-sensor-trigger-change-get-poll-value-function-order-to-avoid-sensor-properties-losing-after-resume-from-s3.patch