Patch "Drivers: hv: vmbus: Don't leak memory when a channel is rescinded" has been added to the 4.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
Drivers: hv: vmbus: Don't leak memory when a channel is rescinded
to the 4.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drivers-hv-vmbus-don-t-leak-memory-when-a-channel-is-rescinded.patch
and it can be found in the queue-4.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
5e030d5ce9d99a899b648413139ff65bab12b038Mon Sep 17 00:00:00 2001
From: "K. Y. Srinivasan" <[email protected]>
Date: Sun, 12 Mar 2017 20:00:30 -0700
Subject: Drivers: hv: vmbus: Don't leak memory when a channel is rescinded
From: K. Y. Srinivasan <[email protected]>
commit 5e030d5ce9d99a899b648413139ff65bab12b038 upstream.
When we close a channel that has been rescinded, we will leak memory since vmbus_teardown_gpadl() returns an error. Fix this so that we can properly cleanup the memory allocated to the ring buffers.
--- drivers/hv/channel.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
drivers/hv/channel.c +8 -5
@@ -506,12 +506,15 @@ int vmbus_teardown_gpadl(struct vmbus_chwait_for_completion (&info->waitevent); -if (channel->rescind) { - ret = -ENODEV ; - goto post_msg_err; - } - post_msg_err: +/* +* If the channel has been rescinded; +* we will be awakened by the rescind +* handler; set the error code to zero so we don't leak memory. +*/ +if (channel->rescind) + ret =0 ; +spin_lock_irqsave (&vmbus_connection.channelmsg_lock, flags);list_del (&info->msglistentry);spin_unlock_irqrestore (&vmbus_connection.channelmsg_lock, flags);
Patches currently in stable-queue which might be from [email protected] are
queue-4.10/drivers-hv-vmbus-don-t-leak-memory-when-a-channel-is-rescinded.patch queue-4.10/drivers-hv-vmbus-don-t-leak-channel-ids.patch