ACPI : Update platform device numa node based on _PXM method
PATCH v2 1/1 ACPI : Update platform device numa node based on _PXM method
The optional _PXM method evaluates to an integer that identifies the proximity domain of a device object. On ACPI based kernel boot, the field numa_node in 'struct device' is always set to -1 irrespective of _PXM value that is specified in the ACPI device object. But in case of device-tree based kernel boot the numa_node field is populated and reflects to a DT property that is specified in DTS according to the below document.
https://www.kernel.org/doc/Documentation/devicetree/bindings/numa.txt
http://lxr.free-electrons.com/source/drivers/of/device.c#L54
Without this patch dev_to_node() always returns a value of -1 for all platform devices. This patch implements support for ACPI _PXM method and updates the platform device numa node id using acpi_get_node(), which provides the PXM to NUMA mapping information. The individual platform device drivers should be able to use the NUMA aware memory allocation functions kmalloc_node() and alloc_pages_node() to improve the performance.
---
Changes since v1: Edited commit text.
Not all the platform devices are attached to NUMA node 0 on Qualcomm Datacenter Technologies server chips. Platform device drivers needs to be aware of NUMA information to improve performance.
drivers/acpi/acpi_platform.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/acpi_platform.c +4 -1
@@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,if (IS_ERR (pdev))dev_err (&adev->dev,"platform device creation failed: %ld\n" ,PTR_ERR (pdev)); -else +else { +set_dev_node (&pdev->dev,acpi_get_node (adev->handle));dev_dbg (&adev->dev,"created platform device %s\n" ,dev_name (&pdev->dev)); + }kfree (resources); +return pdev; }EXPORT_SYMBOL_GPL (acpi_create_platform_device);
Signature · 2 lines
Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 40 lines · Shanker Donthineni
The optional
_PXMmethod evaluates to an integer that identifies the proximity domain of a device object. On ACPI based kernel boot, the fieldnuma_nodein 'struct device' is always set to -1 irrespective of_PXMvalue that is specified in the ACPI device object. But in case of device-tree based kernel boot thenuma_nodefield is populated and reflects to a DT property that is specified in DTS according to the below document.https://www.kernel.org/doc/Documentation/devicetree/bindings/numa.txt
http://lxr.free-electrons.com/source/drivers/of/device.c#L54Without this patch
dev_to_node()always returns a value of -1 for all platform devices. This patch implements support for ACPI_PXMmethod and updates the platform device numa node id usingacpi_get_node(), which provides the PXM to NUMA mapping information. The individual platform device drivers should be able to use the NUMA aware memory allocation functionskmalloc_node()andalloc_pages_node()to improve the performance.Signed-off-by Shanker Donthineni <[email protected]>---
Changes since v1: Edited commit text.Not all the platform devices are attached to NUMA node 0 on Qualcomm Datacenter Technologies server chips. Platform device drivers needs to be aware of NUMA information to improve performance.
drivers/acpi/acpi_platform.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/acpi/acpi_platform.c +1
-1@@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,if (IS_ERR (pdev))dev_err (&adev->dev,"platform device creation failed: %ld\n" ,PTR_ERR (pdev)); -else +else {
drivers/acpi/acpi_platform.c struct platform_device *acpi_create_platform_device(struct acpi_device *adev, · line 132
Quoted 10 lines
drivers/acpi/acpi_platform.c +3
-0+set_dev_node (&pdev->dev,acpi_get_node (adev->handle));dev_dbg (&adev->dev,"created platform device %s\n" ,dev_name (&pdev->dev)); + }kfree (resources); +return pdev; }EXPORT_SYMBOL_GPL (acpi_create_platform_device);
Thanks
Hanjun
Quoted 19 lines · Shanker Donthineni
The optional
_PXMmethod evaluates to an integer that identifies the proximity domain of a device object. On ACPI based kernel boot, the fieldnuma_nodein 'struct device' is always set to -1 irrespective of_PXMvalue that is specified in the ACPI device object. But in case of device-tree based kernel boot thenuma_nodefield is populated and reflects to a DT property that is specified in DTS according to the below document.https://www.kernel.org/doc/Documentation/devicetree/bindings/numa.txt
http://lxr.free-electrons.com/source/drivers/of/device.c#L54Without this patch
dev_to_node()always returns a value of -1 for all platform devices. This patch implements support for ACPI_PXMmethod and updates the platform device numa node id usingacpi_get_node(), which provides the PXM to NUMA mapping information. The individual platform device drivers should be able to use the NUMA aware memory allocation functionskmalloc_node()andalloc_pages_node()to improve the performance.
Quoted 1 line
Signed-off-by Shanker Donthineni <[email protected]>
Quoted 33 lines
---
Changes since v1: Edited commit text.Not all the platform devices are attached to NUMA node 0 on Qualcomm Datacenter Technologies server chips. Platform device drivers needs to be aware of NUMA information to improve performance.
drivers/acpi/acpi_platform.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/acpi/acpi_platform.c +4
-1@@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev, if (IS_ERR(pdev)) dev_err(&adev->dev, "platform device creation failed: %ld\n", PTR_ERR(pdev)); - else + else { +set_dev_node (&pdev->dev,acpi_get_node (adev->handle));dev_dbg (&adev->dev,"created platform device %s\n" ,dev_name (&pdev->dev)); + }kfree (resources); +return pdev;}
EXPORT_SYMBOL_GPL(acpi_create_platform_device);
Signature · 3 lines
Jiandi An Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.