Skip to contentSkip to conversation

Eudyptula challenge

PATCH New Chewie Lin 3 participants 5 messages Mar 31, 2017 – Apr 1, 2017 Staging

lore
Share & tools
lore

Chewie Lin

author
#0 lore raw

PATCH 1/1 Eudyptula challenge

Hi,

I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
fixed a checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.10.0
author
#1 lore raw

PATCH 1/1 drivers: fixed a checkpatch warning

fixed a coding style error/warning.

---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/main_usb.c +1 -1
index 9e074e9..2d9e7af 100644
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
Signature · 1 line
2.10.0
#2 lore raw

Re: [PATCH] drivers: fixed a checkpatch warning

Quoted 1 line · Chewie Lin

fixed a coding style error/warning.

Worst changelog and subject: line ever :)

Please go read the links that my patchbot sent you last time you submitted this change. You didn't do so for some odd reason :(

thanks,

greg k-h

#3 lore raw

Re: [PATCH] drivers: fixed a checkpatch warning

In reply to Chewie Lin
Quoted 12 lines · Chewie Lin

fixed a coding style error/warning.

---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/main_usb.c +0 -0
index 9e074e9..2d9e7af 100644

drivers/staging/vt6656/main_usb.c static void usb_device_reset(struct vnt_private *priv) · line 417

Quoted 5 lines
drivers/staging/vt6656/main_usb.c +1 -1
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);

Yeah, what Greg said.

Also most likely this should be

		dev_warn(&priv->usb->dev,
			 "usb_reset_device fail status=%d\n", status);

Note the function is usb_device_reset, but the
function call that failed is usb_reset_device.

author
#4 lore raw

Re: [PATCH] drivers: fixed a checkpatch warning

Quoted 21 lines · Joe Perches
Quoted 12 lines · Chewie Lin

fixed a coding style error/warning.

---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/main_usb.c +0 -0
index 9e074e9..2d9e7af 100644

drivers/staging/vt6656/main_usb.c static void usb_device_reset(struct vnt_private *priv) · line 417

Quoted 5 lines
drivers/staging/vt6656/main_usb.c +1 -1
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);

Yeah, what Greg said.

Quoted 7 lines

Also most likely this should be

		dev_warn(&priv->usb->dev,
			 "usb_reset_device fail status=%d\n", status);

Note the function is usb_device_reset, but the
function call that failed is usb_reset_device.

yep, I had the comic book guy from the Simpsons voice when I read that. :) I submitted a separate patch, maybe I should have reply-to this instead?

Quoted 1 line