Skip to contentSkip to conversation

board: Add support for Engicam i.CoreM6 Quad/Dual boards

PATCH New Jagan Teki 4 participants 6 messages Apr 4, 2017 – Apr 5, 2017 Arm i.MX and Layerscape

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v3 1/1 board: Add support for Engicam i.CoreM6 Quad/Dual boards

From: Jagan Teki <[email protected]>

Add initial support for Engicam i.CoreM6 Quad/Dual board with below features:
- U-Boot 2017.01
- Linux 4.10
- Default packages from buildroot

Cc Thomas Petazzoni <[email protected]>
Cc Matteo Lisi <[email protected]>
Cc Michael Trimarchi <[email protected]>
Signed-off-by Jagan Teki <[email protected]>

---
Changes for v3:
- Rename icore with common, since creating a folder with the name of
SOM is not make sense, becuase the defconfig is the only change.
- Update readme.txt, post-images.sh, engicam_imx6q_icore_defconfig as per above change.
- rebased on master
Changes for v2:
- Created icorem6 family board on engicam
- Added Quad/Dual SOM boards support
- Created well defined readme.tx with referance to board/freescale/imx6q-sabresd/
- s/imx6q_icore_defconfig/engicam_/imx6q_icore_defconfig
- Updated DEVELOPERS file
- Created genimage.cfg with added SPL and u-boot-dtb.img partitions
- Removed Latest source configs and updated with fixed version source for U-Boot, Linux
- Add board link on readme.txt
- Removed BR2_TARGET_ROOTFS_TAR_XZ=y
- Created post-image.sh with referance to board/freescale/imx6q-sabresd/

 DEVELOPERS                            |  4 +++
 board/engicam/common/genimage.cfg     | 46 ++++++++++++++++++++++++
 board/engicam/common/post-image.sh    | 54 ++++++++++++++++++++++++++++
 board/engicam/common/readme.txt       | 66 +++++++++++++++++++++++++++++++++++
 configs/engicam_imx6q_icore_defconfig | 40 +++++++++++++++++++++
 5 files changed, 210 insertions(+)
 create mode 100644 board/engicam/common/genimage.cfg
 create mode 100755 board/engicam/common/post-image.sh
 create mode 100644 board/engicam/common/readme.txt
 create mode 100644 configs/engicam_imx6q_icore_defconfig
DEVELOPERS +4 -0
index c89468b..a86860d 100644
@@ -802,6 +802,10 @@ F:	package/angularjs/
 N:	Ilias Apalodimas <[email protected]>
 F:	package/keepalived/
 
+N:	Jagan Teki <[email protected]>
+F:	board/engicam/
+F:	configs/engicam_imx6q_icore_defconfig
+
 N:	James Knight <[email protected]>
 F:	package/atkmm/
 F:	package/cairomm/
board/engicam/common/genimage.cfg new file +46 -0

46 lines not on this page · raw message

board/engicam/common/post-image.sh new file +54 -0

54 lines not on this page · raw message

board/engicam/common/readme.txt new file +66 -0

66 lines not on this page · raw message

configs/engicam_imx6q_icore_defconfig new file +40 -0
new file mode 100644
index 0000000..4278eeb
@@ -0,0 +1,40 @@
+BR2_arm=y
+BR2_cortex_a9=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_FPU_VFPV3=y
+
+# System
+BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3"
+
+# required tools to create the SD card image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+
+# Filesystem
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/engicam/common/post-image.sh"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.01"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="SPL"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.10"
+BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
+BR2_LINUX_KERNEL_UIMAGE=y
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-icore imx6dl-icore"
Signature · 1 line
1.9.1
#1 lore raw

PATCH v3 1/1 board: Add support for Engicam i.CoreM6 Quad/Dual boards

Hello,

Quoted 8 lines · Jagan Teki

From: Jagan Teki <[email protected]>

Add initial support for Engicam i.CoreM6 Quad/Dual board with below features:
- U-Boot 2017.01
- Linux 4.10
- Default packages from buildroot

Quoted 4 lines
Cc Thomas Petazzoni <[email protected]>
Cc Matteo Lisi <[email protected]>
Cc Michael Trimarchi <[email protected]>
Signed-off-by Jagan Teki <[email protected]>

Thanks, looking better.

board/engicam/common/post-image.sh

Quoted 1 line
board/engicam/common/post-image.sh +0 -0

Why do we have this 'common' folder, and this very flexible script? Do you intend to submit the support for other boards?

This script is exactly the same as the one in board/freescale/common/imx/post-image.sh, I definitely would like to avoid duplication.

For now, if you're trying to submit the support for a single board, I would suggest that you:

1. Use a "fixed" genimage.cfg, i.e without %FILES% or %DTBS%

2. Use support/scripts/genimage.sh

board/engicam/common/post-image.sh

Quoted 4 lines
board/engicam/common/post-image.sh +4 -0
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.10"

Since you're using a 4.10 kernel, you also need to set:

BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_10=y

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH v3 1/1 board: Add support for Engicam i.CoreM6 Quad/Dual boards

Quoted 16 lines · Thomas Petazzoni

Hello,

Quoted 8 lines · Jagan Teki

From: Jagan Teki <[email protected]>

Add initial support for Engicam i.CoreM6 Quad/Dual board with below features:
- U-Boot 2017.01
- Linux 4.10
- Default packages from buildroot

Quoted 4 lines
Cc Thomas Petazzoni <[email protected]>
Cc Matteo Lisi <[email protected]>
Cc Michael Trimarchi <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
Quoted 6 lines

Thanks, looking better.

board/engicam/common/post-image.sh

Quoted 1 line
board/engicam/common/post-image.sh +0 -0

Why do we have this 'common' folder, and this very flexible script? Do you intend to submit the support for other boards?

I would like to add more boards in couple of days, the main intention of adding common is to place file for common if any specific board have any specific changes I will create board name file.

Quoted 4 lines

This script is exactly the same as the one in board/freescale/common/imx/post-image.sh, I definitely would like to avoid duplication.

Same, but calling genimage.cfg is different in engicam vs freescale common.

Quoted 7 lines

For now, if you're trying to submit the support for a single board, I would suggest that you:

1. Use a "fixed" genimage.cfg, i.e without %FILES% or %DTBS%

2. Use support/scripts/genimage.sh

I will submit remaining boards soon, so I will keep the genimage.cfg as it is.

Quoted 9 lines

board/engicam/common/post-image.sh

Quoted 5 lines
board/engicam/common/post-image.sh +4 -0
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.10"

Since you're using a 4.10 kernel, you also need to set:

BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_10=y

Will add.

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#3 lore raw

PATCH v3 1/1 board: Add support for Engicam i.CoreM6 Quad/Dual boards

Hello,

Quoted 5 lines · Jagan Teki
Quoted 3 lines

This script is exactly the same as the one in board/freescale/common/imx/post-image.sh, I definitely would like to avoid duplication.

Same, but calling genimage.cfg is different in engicam vs freescale common.

What is different?

Quoted 8 lines
Quoted 6 lines

For now, if you're trying to submit the support for a single board, I would suggest that you:

1. Use a "fixed" genimage.cfg, i.e without %FILES% or %DTBS%

2. Use support/scripts/genimage.sh

I will submit remaining boards soon, so I will keep the genimage.cfg as it is.

What prevents you from using the Freescale common genimage.cfg?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH v3 1/1 board: Add support for Engicam i.CoreM6 Quad/Dual boards

Quoted 15 lines · Thomas Petazzoni

Hello,

Quoted 5 lines · Jagan Teki
Quoted 3 lines

This script is exactly the same as the one in board/freescale/common/imx/post-image.sh, I definitely would like to avoid duplication.

Same, but calling genimage.cfg is different in engicam vs freescale common.

What is different?

Quoted 3 lines
Quoted 3 lines

For now, if you're trying to submit the support for a single board, I would suggest that you:

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

1. Use a "fixed" genimage.cfg, i.e without %FILES% or %DTBS%

2. Use support/scripts/genimage.sh

I will submit remaining boards soon, so I will keep the genimage.cfg as it is.

What prevents you from using the Freescale common genimage.cfg?

Freescale script doesn't suport SPL and dtb enabled u-boot.

  partition SPL {
    in-partition-table = "no"
    image = "SPL"
    offset = 1024
  }

  partition u-boot-dtb {
    in-partition-table = "no"
    image = "u-boot-dtb.img"
    offset = 69K
  }

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#5 lore raw

PATCH v3 1/1 board: Add support for Engicam i.CoreM6 Quad/Dual boards

In reply to Jagan Teki
Quoted 30 lines · Jagan Teki
Quoted 16 lines · Thomas Petazzoni

Hello,

Quoted 8 lines · Jagan Teki

From: Jagan Teki <[email protected]>

Add initial support for Engicam i.CoreM6 Quad/Dual board with below features:
- U-Boot 2017.01
- Linux 4.10
- Default packages from buildroot

Quoted 4 lines
Cc Thomas Petazzoni <[email protected]>
Cc Matteo Lisi <[email protected]>
Cc Michael Trimarchi <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
Quoted 6 lines

Thanks, looking better.

board/engicam/common/post-image.sh

Quoted 1 line
board/engicam/common/post-image.sh +0 -0

Why do we have this 'common' folder, and this very flexible script? Do you intend to submit the support for other boards?

I would like to add more boards in couple of days, the main intention of adding common is to place file for common if any specific board have any specific changes I will create board name file.

Quoted 1 line
Quoted 5 lines
Quoted 3 lines

This script is exactly the same as the one in board/freescale/common/imx/post-image.sh, I definitely would like to avoid duplication.

Same, but calling genimage.cfg is different in engicam vs freescale common.

Then it's better to add the path to genimage.cfg.template as an argument to the
genimage script (with a default of the current template, so you don't need to update all the existing defconfigs).

Better yet, factor this feature into support/scripts/genimage.sh, by adding
extra flag arguments for the dtb-list and linux-image features. That's a bit more complicated, of course. If you do this, it would be nice to also update the existing freescale defconfigs, but not strictly necessary.

I'm adding Etienne in Cc, he's also working on defconfig refactoring for genimage.

BTW, a better way to get the values is to use printvars (which works now). In
the script, you can do e.g.:

eval $(make -s O="${BASE_DIR}" printvars VARS="LINUX_IMAGE_NAME KERNEL_DTBS")

and you get the LINUX_IMAGE_NAME and KERNEL_DTBS variables in your environment.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF