Skip to contentSkip to conversation

automake: add patch fixing GNU bug #25299

PATCH New Heiko Thiery 3 participants 5 messages Apr 7, 2017 – Apr 14, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 automake: add patch fixing GNU bug #25299

A bug in automake makes it impossible to build in an output directory that contains an '@' character. But this is needed if you want to build with jenkins' pipeline plugin.

This patch was proposed by Michael Brantley but is currently not applied in the upstream automake repository.

Refer to: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299

---
 ...character-in-installation-prefix-breaks-automake.patch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch
package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch new file +15 -0
new file mode 100644
index 0000000..3a5a571
@@ -0,0 +1,15 @@
+See bug report #25299 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299)
+
+Signed-off-by: Heiko Thiery <[email protected]>
+
+--- a/bin/aclocal.in
++++ b/bin/aclocal.in
+@@ -69,7 +69,7 @@
+ # ACLOCAL_PATH environment variable, and reset with the '--system-acdir'
+ # option.
+ my @user_includes = ();
+-my @automake_includes = ("@datadir@/aclocal-$APIVERSION");
++my @automake_includes = ('@datadir@/aclocal-' . $APIVERSION);
+ my @system_includes = ('@datadir@/aclocal');
+ 
+ # Whether we should copy M4 file in $user_includes[0].
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 automake: add patch fixing GNU bug #25299

2017-04-07 14:33 GMT+02:00 Heiko Thiery <[email protected]>:

Quoted 43 lines

A bug in automake makes it impossible to build in an output directory that contains an '@' character. But this is needed if you want to build with jenkins' pipeline plugin.

This patch was proposed by Michael Brantley but is currently not applied in the upstream automake repository.

Refer to: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299

---
 ...character-in-installation-prefix-breaks-automake.patch | 15
+++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 package/automake/0003-at-character-in-installation-

prefix-breaks-automake.patch

package/automake/0003-at-character-in-installation- renamed from package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch +0 -0

prefix-breaks-automake.patch
new file mode 100644
index 0000000..3a5a571

package/automake/0003-at-character-in-installation- new file +0 -0

prefix-breaks-automake.patch

package/automake/0003-at-character-in-installation- new file +1 -0
@@ -0,0 +1,15 @@
+See bug report #25299 (https://debbugs.gnu.org/cgi/

bugreport.cgi?bug=25299)

package/automake/0003-at-character-in-installation- new file +14 -1
+
+Signed-off-by: Heiko Thiery <[email protected]>
+
+--- a/bin/aclocal.in
++++ b/bin/aclocal.in
+@@ -69,7 +69,7 @@
+ # ACLOCAL_PATH environment variable, and reset with the '--system-acdir'
+ # option.
+ my @user_includes = ();
+-my @automake_includes = ("@datadir@/aclocal-$APIVERSION");
++my @automake_includes = ('@datadir@/aclocal-' . $APIVERSION);
+ my @system_includes = ('@datadir@/aclocal');
+
+ # Whether we should copy M4 file in $user_includes[0].
--
Quoted 3 lines

2.1.4

Can someone give me some feedback if this patch is ok and will be accepted?

BR,
Heiko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170410/c2e26504/attachment.html>

#2 lore raw

PATCH 1/1 automake: add patch fixing GNU bug #25299

Quoted 51 lines · Heiko Thiery

2017-04-07 14:33 GMT+02:00 Heiko Thiery <[email protected] <mailto:[email protected]>>:

    A bug in automake makes it impossible to build in an output directory
    that contains an '@' character. But this is needed if you want to build
    with jenkins' pipeline plugin.

    This patch was proposed by Michael Brantley but is currently not applied
    in the upstream automake repository.

    Refer to: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299
    <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299>

    Signed-off-by: Heiko Thiery <[email protected]
    <mailto:[email protected]>>
    ---
     ...character-in-installation-prefix-breaks-automake.patch | 15 +++++++++++++++
     1 file changed, 15 insertions(+)
     create mode 100644
    package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch

    diff --git
    a/package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch
    b/package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch
    new file mode 100644
    index 0000000..3a5a571
    --- /dev/null
    +++
    b/package/automake/0003-at-character-in-installation-prefix-breaks-automake.patch
    @@ -0,0 +1,15 @@
    +See bug report #25299 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299
    <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25299>)
    +
    +Signed-off-by: Heiko Thiery <[email protected]
    <mailto:[email protected]>>
    +
    +--- a/bin/aclocal.in <http://aclocal.in>
    ++++ b/bin/aclocal.in <http://aclocal.in>
    +@@ -69,7 +69,7 @@
    + # ACLOCAL_PATH environment variable, and reset with the '--system-acdir'
    + # option.
    + my @user_includes = ();
    +-my @automake_includes = ("@datadir@/aclocal-$APIVERSION");
    ++my @automake_includes = ('@datadir@/aclocal-' . $APIVERSION);
    + my @system_includes = ('@datadir@/aclocal');
    +
    + # Whether we should copy M4 file in $user_includes[0].
    --
    2.1.4
Quoted 1 line

Can someone give me some feedback if this patch is ok and will be accepted?

You're a bit impatient, we have many patches pending review (cfr.
http://patchwork.ozlabs.org/project/buildroot/list/ ). That said, chances are pretty low that anybody would look at this patch.

The problem is that it's a kind of feature patch (it doesn't solve a
cross-compilation issue or regression), and it's not easy to understand if it does the right thing. So we would typically want upstream feedback on it. Unfortunately, there is no activity on the bug since 4 months (except for your +1).

One thing that would help is if your commit message would clarify that the bug
only shows itself on packages that are autoreconf'ed, and a minimal defconfig that allows someone to reproduce. Something like:

BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_LZO=y

make O=@output olddefconfig world

And it would also help if you could give a list of autoreconf'ed packages that
you have tested with this patch.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH 1/1 automake: add patch fixing GNU bug #25299

Hello,

Quoted 2 lines · Arnout Vandecappelle

And it would also help if you could give a list of autoreconf'ed packages that
you have tested with this patch.

I thought I had given feedback on this patch, but apparently no. One think that isn't clear to me is what packages are affected:

* Are only packages autoreconf'ed by Buildroot affected by the @ issue ?

* Or are all autotools packages affected ? If that's the case, then this patch is not sufficient: we would have to autoreconf all autotools packages, but is not really doable.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 automake: add patch fixing GNU bug #25299

Quoted 10 lines · Thomas Petazzoni

Hello,

Quoted 2 lines · Arnout Vandecappelle

And it would also help if you could give a list of autoreconf'ed packages that
you have tested with this patch.

I thought I had given feedback on this patch, but apparently no. One think that isn't clear to me is what packages are affected:

Quoted 6 lines

* Are only packages autoreconf'ed by Buildroot affected by the @ issue ?

* Or are all autotools packages affected ? If that's the case, then this patch is not sufficient: we would have to autoreconf all autotools packages, but is not really doable.

I've tried it, and apparently only autoreconf'ed packages are the problem.
That's why I wrote that the commit message should clarify exactly this.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF