Skip to contentSkip to conversation

kconfig: remove unused definition from scanner

PATCH In review Martin Walch 3 participants 6 messages Oct 2, 2013 – Oct 3, 2013

Subsystems (2)
Kbuild Kconfig
lore
Share & tools
lore

Martin Walch

author
#0 lore raw

PATCH 4/4 kconfig: remove unused definition from scanner

From: Martin Walch <[email protected]>
Date: Wed, 2 Oct 2013 06:58:46 +0200
Subject: [PATCH 4/4] kconfig: remove unused definition from scanner

The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.

Signed-off-by Martin Walch <[email protected]>
---
 scripts/kconfig/zconf.l | 1 -
 1 file changed, 1 deletion(-)
scripts/kconfig/zconf.l +0 -1
index 6555a47..1a9f53e 100644
@@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
 }
 %}
 
-ws	[ \n\t]
 n	[A-Za-z0-9_]
 
 %%
Signature · 1 line
1.8.1.5
#1 lore raw
Quoted 5 lines · Martin Walch

From: Martin Walch <[email protected]>
Date: Wed, 2 Oct 2013 06:58:46 +0200
Subject: [PATCH 4/4] kconfig: remove unused definition from scanner

The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.

Hi Martin,

I think you should also regenerate the scanner and add the new zconf.lex.c_shipped to this patch.

Dirk

Quoted 17 lines
Signed-off-by Martin Walch <[email protected]>
---
 scripts/kconfig/zconf.l | 1 -
 1 file changed, 1 deletion(-)
scripts/kconfig/zconf.l +0 -1
index 6555a47..1a9f53e 100644
@@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
 }
 %}
 
-ws	[ \n\t]
 n	[A-Za-z0-9_]
 
 %%
#2 lore raw

Martin, All,

Quoted 6 lines · On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
Quoted 4 lines · Martin Walch

From: Martin Walch <[email protected]>
Date: Wed, 2 Oct 2013 06:58:46 +0200
Subject: [PATCH 4/4] kconfig: remove unused definition from scanner

Quoted 6 lines
Quoted 1 line

The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.

Hi Martin,

I think you should also regenerate the scanner and add the new zconf.lex.c_shipped to this patch.

I think sending the re-generated parser as a separate patch helps in reviewing. Ie. I'd prefer a fifth patch.

BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config

Regards,
Yann E. MORIN.

Quoted 18 lines
Quoted 17 lines
Signed-off-by Martin Walch <[email protected]>
---
 scripts/kconfig/zconf.l | 1 -
 1 file changed, 1 deletion(-)
scripts/kconfig/zconf.l +0 -1
index 6555a47..1a9f53e 100644
@@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
 }
 %}
 
-ws	[ \n\t]
 n	[A-Za-z0-9_]
 
 %%
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< O_o >==-- '------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
'------------------------------'-------'------------------'--------------------'
author
#3 lore raw
Quoted 9 lines · On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
Quoted 2 lines · On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:

I think you should also regenerate the scanner and add the new zconf.lex.c_shipped to this patch.

I think sending the re-generated parser as a separate patch helps in reviewing. Ie. I'd prefer a fifth patch.

BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config

Actually, I regenerated the scanner. However, the results did not change after applying the patch, because the definition that the patch removes (ws) is not used anywhere. It is only a cleanup.

Regenerating the scanner and the parser code with newer versions of flex and bison results in code changes. However, they are not related to the patch, but originate from updates in flex and bison. Therefore I did not see any point in including the regenerated files in this patch set.

Of course, if you see any benefit in regenerating the *_shipped files, I can still do so.

Regards,
Martin Walch

#4 lore raw

Martin, All,

Quoted 8 lines · On Thursday 03 October 2013 02:30:21 Martin Walch wrote:
Quoted 7 lines · On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
Quoted 2 lines · On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:

I think you should also regenerate the scanner and add the new zconf.lex.c_shipped to this patch.

I think sending the re-generated parser as a separate patch helps in reviewing. Ie. I'd prefer a fifth patch.

Quoted 6 lines
Quoted 2 lines

BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config

Actually, I regenerated the scanner. However, the results did not change after applying the patch, because the definition that the patch removes (ws) is not used anywhere. It is only a cleanup.

OK, then please say so in the commit message.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< O_o >==-- '------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
'------------------------------'-------'------------------'--------------------'
#5 lore raw
In reply to Martin Walch
Quoted 8 lines · Martin Walch
Quoted 7 lines · On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
Quoted 2 lines · On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:

I think you should also regenerate the scanner and add the new zconf.lex.c_shipped to this patch.

I think sending the re-generated parser as a separate patch helps in reviewing. Ie. I'd prefer a fifth patch.

Quoted 6 lines
Quoted 2 lines

BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config

Actually, I regenerated the scanner. However, the results did not change after applying the patch, because the definition that the patch removes (ws) is not used anywhere. It is only a cleanup.

Sorry, my review was too superficial.
I did downgrade my flex to see if your changes affect the scanner, but I did not test it without your patch and also did not have a look in what the changes are.

The changes I noticed here are probably related to the flex package I use (on a Gentoo system) -- they even occur without your patch. I'll attach what I noticed in case someone is interested.

Dirk

scripts/kconfig/zconf.lex.c_shipped +1 -1
index a0521aa..3eb4c0b 100644
@@ -920,7 +920,7 @@ static int input (void );
 /* This used to be an fputs(), but since the string might contain NUL's,
  * we now use fwrite().
  */
-#define ECHO do { if (fwrite( zconftext, zconfleng, 1, zconfout )) {} } while (0)
+#define ECHO fwrite( zconftext, zconfleng, 1, zconfout )
 #endif
 
 /* Gets input and stuffs it into "buf".  number of characters read, or YY_NULL,