Skip to contentSkip to conversation

: Removing warnings caught by checkpatch.pl

PATCH In review Harman Kalra 3 participants 4 messages Oct 1, 2016 – Oct 4, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Removing warnings caught by checkpatch.pl

Removing warnings caught by checkpatch.pl

---
 drivers/staging/media/omap4iss/iss_video.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/media/omap4iss/iss_video.c +4 -4
index c16927a..7cc1691 100644
@@ -297,8 +297,8 @@ static void iss_video_pix_to_mbus(const struct v4l2_pix_format *pix,
  */
 
 static int iss_video_queue_setup(struct vb2_queue *vq,
-				 unsigned int *count, unsigned int *num_planes,
-				 unsigned int sizes[], struct device *alloc_devs[])
+			unsigned int *count, unsigned int *num_planes,
+			unsigned int sizes[], struct device *alloc_devs[])
 {
 	struct iss_video_fh *vfh = vb2_get_drv_priv(vq);
 	struct iss_video *video = vfh->video;
@@ -678,8 +678,8 @@ void omap4iss_video_cancel_stream(struct iss_video *video)
 	if (subdev == NULL)
 		return -EINVAL;
 
-	/* Try the get selection operation first and fallback to get format if not
-	 * implemented.
+	/* Try the get selection operation first and
+	 * fallback to get format if not implemented.
 	 */
 	sdsel.pad = pad;
 	ret = v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel);

--
1.7.9.5

#1 lore raw

Hello Harman,

Thank you for the patch.

The subject of your commit message should at least contain the name of the driver. Furthermore, you can mention that the patch originates from warnings output by checkpatch.pl, but the subject should describe what you fix (in this case what type of warning).

Quoted 1 line · On Sunday 02 Oct 2016 02:30:45 Harman Kalra wrote:

Removing warnings caught by checkpatch.pl

If the purpose of commit message bodies was to repeat the subject line, we wouldn't use them :-) Here you should describe why this change is needed, and possibly how it is performed when the patch is complex (which isn't the case of this patch).

Quoted 13 lines
---
 drivers/staging/media/omap4iss/iss_video.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_video.c index c16927a..7cc1691 100644

drivers/staging/media/omap4iss/iss_video.c +0 -0
@@ -297,8 +297,8 @@ static void iss_video_pix_to_mbus(const struct

v4l2_pix_format *pix, */

static int iss_video_queue_setup(struct vb2_queue *vq,

drivers/staging/media/omap4iss/iss_video.c

Quoted 1 line
drivers/staging/media/omap4iss/iss_video.c +0 -1
-				 unsigned int *count, unsigned int 

*num_planes,

drivers/staging/media/omap4iss/iss_video.c

Quoted 1 line
drivers/staging/media/omap4iss/iss_video.c +0 -1
-				 unsigned int sizes[], struct device 

*alloc_devs[])

drivers/staging/media/omap4iss/iss_video.c static void iss_video_pix_to_mbus(const struct v4l2_pix_format *pix, · line 301

Quoted 2 lines
drivers/staging/media/omap4iss/iss_video.c +2 -0
+			unsigned int *count, unsigned int *num_planes,
+			unsigned int sizes[], struct device *alloc_devs[])

This breaks the coding style of the driver which aligns function arguments to the opening parenthesis. You can instead wrap the last line to shorten it.

drivers/staging/media/omap4iss/iss_video.c void omap4iss_video_cancel_stream(struct iss_video · line 681

Quoted 8 lines

{

drivers/staging/media/omap4iss/iss_video.c +0 -1
 	struct iss_video_fh *vfh = vb2_get_drv_priv(vq);
 	struct iss_video *video = vfh->video;
@@ -678,8 +678,8 @@ void omap4iss_video_cancel_stream(struct iss_video
 *video) if (subdev == NULL)
 		return -EINVAL;
 
-	/* Try the get selection operation first and fallback to get format if 

not

drivers/staging/media/omap4iss/iss_video.c void omap4iss_video_cancel_stream(struct iss_video *video) · line 682

Quoted 3 lines
drivers/staging/media/omap4iss/iss_video.c +2 -1
-	 * implemented.
+	/* Try the get selection operation first and
+	 * fallback to get format if not implemented.

Lines can be up to 80 characters long, there's no need to wrap them after 52 characters only.

Quoted 5 lines
drivers/staging/media/omap4iss/iss_video.c +0 -1
 	 */
 	sdsel.pad = pad;
 	ret = v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel);
--

1.7.9.5

Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
In reply to Harman Kalra

drivers/staging/media/omap4iss/iss_video.c static void iss_video_pix_to_mbus(const struct v4l2_pix_format *pix, · line 301

Quoted 5 lines · Harman Kalra

static int iss_video_queue_setup(struct vb2_queue *vq,

drivers/staging/media/omap4iss/iss_video.c +2 -2
-				 unsigned int *count, unsigned int *num_planes,
-				 unsigned int sizes[], struct device *alloc_devs[])
+			unsigned int *count, unsigned int *num_planes,
+			unsigned int sizes[], struct device *alloc_devs[])

2 spaces + 3 tabs -> 2 spaces + 2 tabs? Am I seeing this correctly? Both ways are against CodingStyle.

drivers/staging/media/omap4iss/iss_video.c void omap4iss_video_cancel_stream(struct iss_video *video) · line 683

Quoted 5 lines
drivers/staging/media/omap4iss/iss_video.c +2 -2
-	/* Try the get selection operation first and fallback to get format if not
-	 * implemented.
+	/* Try the get selection operation first and
+	 * fallback to get format if not implemented.
 	 */

This comment style is discouraged so this is at lease not perfect. Doesn't checkpatch complain with this change? If it doesn't, could you please also check with --strict, as long as you're working on style.

#3 lore raw

Hi Andrey,

Quoted 4 lines · On Monday 03 Oct 2016 22:52:11 Andrey Utkin wrote:

Review

Quoted 3 lines · Harman Kalra

static int iss_video_queue_setup(struct vb2_queue *vq,

(quoted diff) +0 -1
-				 unsigned int *count, unsigned int 

*num_planes,

Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -1
-				 unsigned int sizes[], struct device 

*alloc_devs[])

Quoted 5 lines

drivers/staging/media/omap4iss/iss_video.c static void iss_video_pix_to_mbus(const struct v4l2_pix_format *pix, · line 301

Quoted 2 lines
drivers/staging/media/omap4iss/iss_video.c +2 -0
+			unsigned int *count, unsigned int *num_planes,
+			unsigned int sizes[], struct device *alloc_devs[])

2 spaces + 3 tabs -> 2 spaces + 2 tabs? Am I seeing this correctly? Both ways are against CodingStyle.

It's 4 tabs + 1 space -> 3 tabs as far as I can see.

Quoted 10 lines

drivers/staging/media/omap4iss/iss_video.c void omap4iss_video_cancel_stream(struct iss_video *video) · line 683

Quoted 6 lines
(quoted diff) +0 -1
-	/* Try the get selection operation first and fallback to get format if

not - * implemented.

drivers/staging/media/omap4iss/iss_video.c +2 -0
+	/* Try the get selection operation first and
+	 * fallback to get format if not implemented.
 
 	 */

This comment style is discouraged so this is at lease not perfect. Doesn't checkpatch complain with this change? If it doesn't, could you please also check with --strict, as long as you're working on style.

Signature · 3 lines
Regards,

Laurent Pinchart