Skip to contentSkip to conversation

x86/irq: Do not check available vectors if no irq to migrate or required slots has been found

PATCH New Chen Yu 2 participants 2 messages Apr 16, 2017 – Apr 20, 2017 x86

lore
Share & tools
lore

Chen Yu

author
#0 lore raw

PATCH 1/1 x86/irq: Do not check available vectors if no irq to migrate or required slots has been found

A micro optimization to bypass the free vector checking if the current CPU has no irq to migrate, also breaks the for_each_online_cpu() loop when the count reaches the required vectors.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Len Brown <[email protected]>
---
 arch/x86/kernel/irq.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
arch/x86/kernel/irq.c +7 -2
index 4d8183b..f34fe74 100644
@@ -394,6 +394,9 @@ int check_irq_vectors_for_cpu_disable(void)
 		    !cpumask_subset(&affinity_new, &online_new))
 			this_count++;
 	}
+	/* No need to check any further. */
+	if (!this_count)
+		return 0;
 
 	count = 0;
 	for_each_online_cpu(cpu) {
@@ -411,8 +414,10 @@ int check_irq_vectors_for_cpu_disable(void)
 		for (vector = FIRST_EXTERNAL_VECTOR;
 		     vector < first_system_vector; vector++) {
 			if (!test_bit(vector, used_vectors) &&
-			    IS_ERR_OR_NULL(per_cpu(vector_irq, cpu)[vector]))
-			    count++;
+			    IS_ERR_OR_NULL(per_cpu(vector_irq, cpu)[vector])) {
+				if (++count == this_count)
+					return 0;
+			}
 		}
 	}
 
Signature · 1 line
2.7.4
#1 lore raw

[tip:x86/irq] x86/irq: Optimize free vector check in the CPU offline path

x86/irq: Optimize free vector check in the CPU offline path
Commit-ID:  c0edbd4a1693600d6eb9e2faad452638c35391f7
Gitweb:     http://git.kernel.org/tip/c0edbd4a1693600d6eb9e2faad452638c35391f7
Author:     Chen Yu <[email protected]>
AuthorDate: Sun, 16 Apr 2017 23:43:30 +0800
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Thu, 20 Apr 2017 15:25:09 +0200

x86/irq: Optimize free vector check in the CPU offline path

Before offlining a CPU its required to check whether there are enough free irq vectors available so interrupts can be migrated away from the CPU.

This check is executed whether its required or not and neither stops searching when the number of required free vectors are reached.

Bypass the free vector check if the current CPU has no irq to migrate and leave the for_each_online_cpu() loop when the free vector count reaches the number of required vectors.

---
 arch/x86/kernel/irq.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
arch/x86/kernel/irq.c +7 -2
index 4d8183b..f34fe74 100644
@@ -394,6 +394,9 @@ int check_irq_vectors_for_cpu_disable(void)
 		    !cpumask_subset(&affinity_new, &online_new))
 			this_count++;
 	}
+	/* No need to check any further. */
+	if (!this_count)
+		return 0;
 
 	count = 0;
 	for_each_online_cpu(cpu) {
@@ -411,8 +414,10 @@ int check_irq_vectors_for_cpu_disable(void)
 		for (vector = FIRST_EXTERNAL_VECTOR;
 		     vector < first_system_vector; vector++) {
 			if (!test_bit(vector, used_vectors) &&
-			    IS_ERR_OR_NULL(per_cpu(vector_irq, cpu)[vector]))
-			    count++;
+			    IS_ERR_OR_NULL(per_cpu(vector_irq, cpu)[vector])) {
+				if (++count == this_count)
+					return 0;
+			}
 		}
 	}