Skip to contentSkip to conversation

drm/amdgpu: fix memory clock can't switch on CI.

PATCH In review Rex Zhu 2 participants 2 messages Apr 18, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Rex Zhu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix memory clock can't switch on CI.

if we enable uvd dpm during boot time, mclk will be fixed in the initially enabled level for activity. In performance level, other leevels can't be enabled by send the mask to SMC. so set all mclk levels enabled.

Change-Id Id5c795317412a8013666fa432426d2713a27a2f8
---
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/ci_dpm.c +1 -2
index 11ccda8..a6dda34 100644
@@ -3036,6 +3036,7 @@ static int ci_populate_single_memory_level(struct amdgpu_device *adev,
 						      memory_clock,
 						      &memory_level->MinVddcPhases);
 
+	memory_level->EnabledForActivity = 1;
 	memory_level->EnabledForThrottle = 1;
 	memory_level->UpH = 0;
 	memory_level->DownH = 100;
@@ -3468,8 +3469,6 @@ static int ci_populate_all_memory_levels(struct amdgpu_device *adev)
 			return ret;
 	}
 
-	pi->smc_state_table.MemoryLevel[0].EnabledForActivity = 1;
-
 	if ((dpm_table->mclk_table.count >= 2) &&
 	    ((adev->pdev->device == 0x67B0) || (adev->pdev->device == 0x67B1))) {
 		pi->smc_state_table.MemoryLevel[1].MinVddc =
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1492515307-5979-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Rex Zhu
Sent: Tuesday, April 18, 2017 7:35 AM
To: [email protected]
Cc: Zhu, Rex
Subject: [PATCH] drm/amdgpu: fix memory clock can't switch on CI.

Quoted 8 lines

if we enable uvd dpm during boot time, mclk will be fixed in the initially enabled level for activity. In performance level, other leevels can't be enabled by send the mask to SMC. so set all mclk levels enabled.

Change-Id Id5c795317412a8013666fa432426d2713a27a2f8
Quoted 33 lines
---
 drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/ci_dpm.c +1 -0
index 11ccda8..a6dda34 100644
@@ -3036,6 +3036,7 @@ static int ci_populate_single_memory_level(struct
 amdgpu_device *adev,
 						      memory_clock,
 						      &memory_level-
 >MinVddcPhases);
 
+	memory_level->EnabledForActivity = 1;
 	memory_level->EnabledForThrottle = 1;
drivers/gpu/drm/amd/amdgpu/ci_dpm.c +0 -2
 	memory_level->UpH = 0;
 	memory_level->DownH = 100;
@@ -3468,8 +3469,6 @@ static int ci_populate_all_memory_levels(struct
 amdgpu_device *adev)
 			return ret;
 	}
 
-	pi->smc_state_table.MemoryLevel[0].EnabledForActivity = 1;
-
 	if ((dpm_table->mclk_table.count >= 2) &&
 	    ((adev->pdev->device == 0x67B0) || (adev->pdev->device ==

0x67B1))) {
pi->smc_state_table.MemoryLevel[1].MinVddc =
--
1.9.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx