Skip to contentSkip to conversation

x86/smp: Update reschedule warning text

PATCH New Prarit Bhargava 2 participants 2 messages Apr 18, 2017 – Apr 20, 2017 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/smp: Update reschedule warning text

Modify the reschedule warning to output the offline CPU value and a better debug message.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Wanpeng Li <[email protected]>
Cc Andrew Morton <[email protected]>
Cc "Steven Rostedt (VMware)" <[email protected]>
Cc Daniel Bristot de Oliveira <[email protected]>
Cc Hidehiro Kawai <[email protected]>
---
 arch/x86/kernel/smp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/smp.c +1 -1
index d3c66a15bbde..94da6f6971bf 100644
@@ -124,7 +124,7 @@
 static void native_smp_send_reschedule(int cpu)
 {
 	if (unlikely(cpu_is_offline(cpu))) {
-		WARN_ON(1);
+		WARN(1, "Attempting to schedule on offline CPU %d\n", cpu);
 		return;
 	}
 	apic->send_IPI(cpu, RESCHEDULE_VECTOR);
Signature · 1 line
1.7.9.3
#1 lore raw

[tip:sched/core] sched/x86: Update reschedule warning text

sched/x86: Update reschedule warning text
Commit-ID:  21173d0b4d2a0b9e9e5f3155cf2cfc5781a6f4b1
Gitweb:     http://git.kernel.org/tip/21173d0b4d2a0b9e9e5f3155cf2cfc5781a6f4b1
Author:     Prarit Bhargava <[email protected]>
AuthorDate: Tue, 18 Apr 2017 08:25:05 -0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 20 Apr 2017 10:14:30 +0200

sched/x86: Update reschedule warning text

Modify the reschedule warning to output the offline CPU number and use a better debug message.

Cc Andrew Morton <[email protected]>
Cc Daniel Bristot de Oliveira <[email protected]>
Cc Hidehiro Kawai <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Steven Rostedt (VMware) <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Wanpeng Li <[email protected]>
[ Tweaked the warning message. ]
---
 arch/x86/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/smp.c +1 -1
index d3c66a1..3cab841 100644
@@ -124,7 +124,7 @@ static bool smp_no_nmi_ipi = false;
 static void native_smp_send_reschedule(int cpu)
 {
 	if (unlikely(cpu_is_offline(cpu))) {
-		WARN_ON(1);
+		WARN(1, "sched: Unexpected reschedule of offline CPU#%d!\n", cpu);
 		return;
 	}
 	apic->send_IPI(cpu, RESCHEDULE_VECTOR);