Skip to contentSkip to conversation

Patch "char: Drop bogus dependency of DEVPORT on !M68K" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Apr 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

char: Drop bogus dependency of DEVPORT on !M68K

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
char-drop-bogus-dependency-of-devport-on-m68k.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 309124e2648d668a0c23539c5078815660a4a850 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven <[email protected]>
Date: Mon, 11 Apr 2016 10:40:55 +0200
Subject: char: Drop bogus dependency of DEVPORT on !M68K

From: Geert Uytterhoeven <[email protected]>

commit 309124e2648d668a0c23539c5078815660a4a850 upstream.

According to full-history-linux commit d3794f4fa7c3edc3 ("[PATCH] M68k update (part 25)"), port operations are allowed on m68k if CONFIG_ISA is defined.

However, commit 153dcc54df826d2f ("[PATCH] mem driver: fix conditional on isa i/o support") accidentally changed an "||" into an "&&", disabling it completely on m68k. This logic was retained when introducing the DEVPORT symbol in commit 4f911d64e04a44c4 ("Make /dev/port conditional on config symbol").

Drop the bogus dependency on !M68K to fix this.

Fixes 153dcc54df826d2f ("[PATCH] mem driver: fix conditional on isa i/o support")
---
 drivers/char/Kconfig |    1 -
 1 file changed, 1 deletion(-)
drivers/char/Kconfig +0 -1
@@ -575,7 +575,6 @@ config TELCLOCK
 
 config DEVPORT
 	bool
-	depends on !M68K
 	depends on ISA || PCI
 	default y
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/char-drop-bogus-dependency-of-devport-on-m68k.patch