infiniband: chelsio
Subsystems (2)
cover infiniband: chelsio
Neaten logging
Joe Perches (4):
cxgb3: Use more common logging style
cxgb3: Convert PDBG to pr_debug
cxgb4: Use more common logging style
cxgb4: Convert PDBG to pr_debug
drivers/infiniband/hw/cxgb3/cxio_dbg.c | 35 +-- drivers/infiniband/hw/cxgb3/cxio_hal.c | 201 +++++++-------- drivers/infiniband/hw/cxgb3/cxio_hal.h | 7 +- drivers/infiniband/hw/cxgb3/cxio_resource.c | 25 +- drivers/infiniband/hw/cxgb3/iwch.c | 19 +- drivers/infiniband/hw/cxgb3/iwch_cm.c | 269 ++++++++++--------- drivers/infiniband/hw/cxgb3/iwch_cm.h | 18 +- drivers/infiniband/hw/cxgb3/iwch_cq.c | 21 +- drivers/infiniband/hw/cxgb3/iwch_ev.c | 26 +- drivers/infiniband/hw/cxgb3/iwch_mem.c | 2 +- drivers/infiniband/hw/cxgb3/iwch_provider.c | 112 ++++---- drivers/infiniband/hw/cxgb3/iwch_provider.h | 9 +- drivers/infiniband/hw/cxgb3/iwch_qp.c | 67 +++-- drivers/infiniband/hw/cxgb4/cm.c | 387 ++++++++++++++-------------- drivers/infiniband/hw/cxgb4/cq.c | 79 +++--- drivers/infiniband/hw/cxgb4/device.c | 141 +++++----- drivers/infiniband/hw/cxgb4/ev.c | 39 ++- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 48 ++-- drivers/infiniband/hw/cxgb4/mem.c | 34 ++- drivers/infiniband/hw/cxgb4/provider.c | 42 ++- drivers/infiniband/hw/cxgb4/qp.c | 96 +++---- drivers/infiniband/hw/cxgb4/resource.c | 64 +++-- drivers/infiniband/hw/cxgb4/t4.h | 24 +- 23 files changed, 861 insertions(+), 904 deletions(-)
Signature · 6 lines
2.10.0.rc2.1.g053435c -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/4 cxgb3: Use more common logging style
Convert printks to pr_<level>
Miscellanea:
o Coalesce formats
o Realign arguments
--- drivers/infiniband/hw/cxgb3/cxio_hal.c | 27 ++++++------ drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 +++- drivers/infiniband/hw/cxgb3/cxio_resource.c | 5 ++- drivers/infiniband/hw/cxgb3/iwch.c | 13 +++--- drivers/infiniband/hw/cxgb3/iwch_cm.c | 66 ++++++++++++----------------- drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 ++- drivers/infiniband/hw/cxgb3/iwch_ev.c | 11 +++-- drivers/infiniband/hw/cxgb3/iwch_provider.c | 11 ++--- drivers/infiniband/hw/cxgb3/iwch_qp.c | 7 ++- 9 files changed, 70 insertions(+), 86 deletions(-)
drivers/infiniband/hw/cxgb3/cxio_hal.c +12 -15
@@ -110,8 +110,7 @@ int cxio_hal_cq_op(struct cxio_rdev *rdev_p, struct t3_cq *cq,while (!CQ_VLD_ENTRY (rptr, cq->size_log2, cqe)) {udelay (1 );if (i++ >1000000 ) { -printk (KERN_ERR "%s: stalled rnic\n" , - rdev_p->dev_name); +pr_err ("%s: stalled rnic\n" , rdev_p->dev_name);return -EIO ; } }
@@ -949,13 +948,12 @@ int cxio_rdev_open(struct cxio_rdev *rdev_p) err = rdev_p->t3cdev_p->ctl (rdev_p->t3cdev_p,GET_EMBEDDED_INFO , &(rdev_p->fw_info));if (err) { -printk (KERN_ERR "%s t3cdev_p(%p)->ctl returned error %d.\n" , - __func__, rdev_p->t3cdev_p, err); +pr_err ("%s t3cdev_p(%p)->ctl returned error %d\n" , + __func__, rdev_p->t3cdev_p, err); goto err1; }if (G_FW_VERSION_MAJOR (rdev_p->fw_info.fw_vers) !=CXIO_FW_MAJ ) { - printk(KERN_ERR MOD "fatal firmware version mismatch: " -"need version %u but adapter has version %u\n" , +pr_err ("fatal firmware version mismatch: need version %u but adapter has version %u\n" ,CXIO_FW_MAJ ,G_FW_VERSION_MAJOR (rdev_p->fw_info.fw_vers)); err = -EINVAL ;
@@ -965,15 +963,15 @@ int cxio_rdev_open(struct cxio_rdev *rdev_p) err = rdev_p->t3cdev_p->ctl (rdev_p->t3cdev_p,RDMA_GET_PARAMS , &(rdev_p->rnic_info));if (err) { -printk (KERN_ERR "%s t3cdev_p(%p)->ctl returned error %d.\n" , - __func__, rdev_p->t3cdev_p, err); +pr_err ("%s t3cdev_p(%p)->ctl returned error %d\n" , + __func__, rdev_p->t3cdev_p, err); goto err1; } err = rdev_p->t3cdev_p->ctl (rdev_p->t3cdev_p,GET_PORTS , &(rdev_p->port_info));if (err) { -printk (KERN_ERR "%s t3cdev_p(%p)->ctl returned error %d.\n" , - __func__, rdev_p->t3cdev_p, err); +pr_err ("%s t3cdev_p(%p)->ctl returned error %d\n" , + __func__, rdev_p->t3cdev_p, err); goto err1; }
@@ -1003,27 +1001,26 @@ int cxio_rdev_open(struct cxio_rdev *rdev_p) err =cxio_hal_init_ctrl_qp (rdev_p);if (err) { -printk (KERN_ERR "%s error %d initializing ctrl_qp.\n" , - __func__, err); +pr_err ("%s error %d initializing ctrl_qp\n" , __func__, err); goto err1; } err =cxio_hal_init_resource (rdev_p,cxio_num_stags (rdev_p),0 ,0 ,T3_MAX_NUM_QP ,T3_MAX_NUM_CQ ,T3_MAX_NUM_PD );if (err) { -printk (KERN_ERR "%s error %d initializing hal resources.\n" , +pr_err ("%s error %d initializing hal resources\n" , __func__, err); goto err2; } err =cxio_hal_pblpool_create (rdev_p);if (err) { -printk (KERN_ERR "%s error %d initializing pbl mem pool.\n" , +pr_err ("%s error %d initializing pbl mem pool\n" , __func__, err); goto err3; } err =cxio_hal_rqtpool_create (rdev_p);if (err) { -printk (KERN_ERR "%s error %d initializing rqt mem pool.\n" , +pr_err ("%s error %d initializing rqt mem pool\n" , __func__, err); goto err4; }
drivers/infiniband/hw/cxgb3/cxio_hal.h +7 -2
@@ -196,8 +196,13 @@ int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq, struct t3_cqe *cqe, u8 *cqe_flushed, u64 *cookie, u32 *credit);int iwch_cxgb3_ofld_send (struct t3cdev *tdev,struct sk_buff *skb); -#define MOD "iw_cxgb3: " -#define PDBG(fmt, args...) pr_debug(MOD fmt, ## args) +#ifdef pr_fmt +#undef pr_fmt +#endif + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt + +#define PDBG(fmt, args...) pr_debug(fmt, ## args)#ifdef DEBUG void cxio_dump_tpt (struct cxio_rdev *rev,u32 stag);
drivers/infiniband/hw/cxgb3/cxio_resource.c +3 -2
@@ -285,8 +285,9 @@ int cxio_hal_pblpool_create(struct cxio_rdev *rdev_p)PDBG ("%s failed to add PBL chunk (%x/%x)\n" , __func__, pbl_start, pbl_chunk);if (pbl_chunk <=1024 <<MIN_PBL_SHIFT ) { - printk(KERN_WARNING MOD "%s: Failed to add all PBL chunks (%x/%x)\n", - __func__, pbl_start, rdev_p->rnic_info.pbl_top - pbl_start); +pr_warn ("%s: Failed to add all PBL chunks (%x/%x)\n" , + __func__, pbl_start, + rdev_p->rnic_info.pbl_top - pbl_start);return 0 ; } pbl_chunk >>=1 ;
drivers/infiniband/hw/cxgb3/iwch.c +6 -7
@@ -146,11 +146,10 @@ static void open_rnic_dev(struct t3cdev *tdev)struct iwch_dev *rnicp;PDBG ("%s t3cdev %p\n" , __func__, tdev); - printk_once(KERN_INFO MOD "Chelsio T3 RDMA Driver - version %s\n", - DRV_VERSION); +pr_info_once ("Chelsio T3 RDMA Driver - version %s\n" ,DRV_VERSION ); rnicp = (struct iwch_dev *)ib_alloc_device (sizeof (*rnicp));if (!rnicp) { - printk(KERN_ERR MOD "Cannot allocate ib device\n"); +pr_err ("Cannot allocate ib device\n" );return ; } rnicp->rdev.ulp = rnicp;
@@ -160,7 +159,7 @@ static void open_rnic_dev(struct t3cdev *tdev)if (cxio_rdev_open (&rnicp->rdev)) {mutex_unlock (&dev_mutex); - printk(KERN_ERR MOD "Unable to open CXIO rdev\n"); +pr_err ("Unable to open CXIO rdev\n" );ib_dealloc_device (&rnicp->ibdev);return ; }
@@ -171,11 +170,11 @@ static void open_rnic_dev(struct t3cdev *tdev)mutex_unlock (&dev_mutex);if (iwch_register_device (rnicp)) { - printk(KERN_ERR MOD "Unable to register device\n"); +pr_err ("Unable to register device\n" );close_rnic_dev (tdev); } - printk(KERN_INFO MOD "Initialized device %s\n", - pci_name(rnicp->rdev.rnic_info.pdev)); +pr_info ("Initialized device %s\n" , +pci_name (rnicp->rdev.rnic_info.pdev));return ; }
drivers/infiniband/hw/cxgb3/iwch_cm.c +27 -39
220 lines not on this page · raw message
drivers/infiniband/hw/cxgb3/iwch_cq.c +3 -4
@@ -122,8 +122,7 @@ static int iwch_poll_cq_one(struct iwch_dev *rhp, struct iwch_cq *chp, wc->opcode =IB_WC_REG_MR ;break ;default : - printk(KERN_ERR MOD "Unexpected opcode %d " -"in the CQE received for QPID=0x%0x\n" , +pr_err ("Unexpected opcode %d in the CQE received for QPID=0x%0x\n" ,CQE_OPCODE (cqe),CQE_QPID (cqe)); ret = -EINVAL ; goto out;
@@ -177,8 +176,8 @@ static int iwch_poll_cq_one(struct iwch_dev *rhp, struct iwch_cq *chp, wc->status =IB_WC_WR_FLUSH_ERR ;break ;default : - printk(KERN_ERR MOD "Unexpected cqe_status 0x%x for " - "QPID=0x%0x\n", CQE_STATUS(cqe), CQE_QPID(cqe)); +pr_err ("Unexpected cqe_status 0x%x for QPID=0x%0x\n" , +CQE_STATUS (cqe),CQE_QPID (cqe)); ret = -EINVAL ; } }
drivers/infiniband/hw/cxgb3/iwch_ev.c +5 -6
@@ -52,7 +52,7 @@ static void post_qp_event(struct iwch_dev *rnicp, struct iwch_cq *chp, qhp =get_qhp (rnicp,CQE_QPID (rsp_msg->cqe));if (!qhp) { -printk (KERN_ERR "%s unaffiliated error 0x%x qpid 0x%x\n" , +pr_err ("%s unaffiliated error 0x%x qpid 0x%x\n" , __func__,CQE_STATUS (rsp_msg->cqe),CQE_QPID (rsp_msg->cqe));spin_unlock (&rnicp->lock);
@@ -68,8 +68,8 @@ static void post_qp_event(struct iwch_dev *rnicp, struct iwch_cq *chp,return ; } -printk (KERN_ERR "%s - AE qpid 0x%x opcode %d status 0x%x " -"type %d wrid.hi 0x%x wrid.lo 0x%x \n" , __func__, +pr_err ("%s - AE qpid 0x%x opcode %d status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x\n" , + __func__,CQE_QPID (rsp_msg->cqe),CQE_OPCODE (rsp_msg->cqe),CQE_STATUS (rsp_msg->cqe),CQE_TYPE (rsp_msg->cqe),CQE_WRID_HI (rsp_msg->cqe),CQE_WRID_LOW (rsp_msg->cqe));
@@ -117,8 +117,7 @@ void iwch_ev_dispatch(struct cxio_rdev *rdev_p, struct sk_buff *skb) chp =get_chp (rnicp, cqid); qhp =get_qhp (rnicp,CQE_QPID (rsp_msg->cqe));if (!chp || !qhp) { - printk(KERN_ERR MOD "BAD AE cqid 0x%x qpid 0x%x opcode %d " -"status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x \n" , + pr_err("BAD AE cqid 0x%x qpid 0x%x opcode %d status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x\n", cqid, CQE_QPID(rsp_msg->cqe), CQE_OPCODE(rsp_msg->cqe), CQE_STATUS(rsp_msg->cqe), CQE_TYPE(rsp_msg->cqe), CQE_WRID_HI(rsp_msg->cqe),
@@ -218,7 +217,7 @@ void iwch_ev_dispatch(struct cxio_rdev *rdev_p, struct sk_buff *skb)break ;default : - printk(KERN_ERR MOD "Unknown T3 status 0x%x QPID 0x%x\n", +pr_err ("Unknown T3 status 0x%x QPID 0x%x\n" ,CQE_STATUS (rsp_msg->cqe), qhp->wq.qpid);post_qp_event (rnicp, chp, rsp_msg,IB_EVENT_QP_FATAL ,1 );break ;
drivers/infiniband/hw/cxgb3/iwch_provider.c +4 -7
@@ -227,8 +227,7 @@ static struct ib_cq *iwch_create_cq(struct ib_device *ibdev, mm->addr =virt_to_phys (chp->cq.queue);if (udata->outlen <sizeof uresp) {if (!warned++) - printk(KERN_WARNING MOD "Warning - " -"downlevel libcxgb3 (non-fatal).\n" ); +pr_warn ("Warning - downlevel libcxgb3 (non-fatal)\n" ); mm->len =PAGE_ALIGN ((1UL << uresp.size_log2) *sizeof (struct t3_cqe )); resplen =sizeof (struct iwch_create_cq_resp_v0 );
@@ -306,8 +305,7 @@ static int iwch_resize_cq(struct ib_cq *cq, int cqe, struct ib_udata *udata) oldcq.cqid = newcq.cqid; ret =cxio_destroy_cq (&chp->rhp->rdev, &oldcq);if (ret) { - printk(KERN_ERR MOD "%s - cxio_destroy_cq failed %d\n", - __func__, ret); +pr_err ("%s - cxio_destroy_cq failed %d\n" , __func__, ret); }/* add user hooks here */
@@ -346,8 +344,7 @@ static int iwch_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags) err =cxio_hal_cq_op (&rhp->rdev, &chp->cq, cq_op,0 );spin_unlock_irqrestore (&chp->lock, flag);if (err <0 ) - printk(KERN_ERR MOD "Error %d rearming CQID 0x%x\n", err, - chp->cq.cqid); +pr_err ("Error %d rearming CQID 0x%x\n" , err, chp->cq.cqid);if (err >0 && !(flags &IB_CQ_REPORT_MISSED_EVENTS )) err =0 ;return err;
@@ -493,7 +490,7 @@ static struct ib_mr *iwch_get_dma_mr(struct ib_pd *pd, int acc)* T3 only supports 32 bits of size. */ if (sizeof (phys_addr_t) >4 ) { -pr_warn_once (MOD "Cannot support dma_mrs on this platform.\n" ); +pr_warn_once ("Cannot support dma_mrs on this platform\n" );return ERR_PTR (-ENOTSUPP ); }
drivers/infiniband/hw/cxgb3/iwch_qp.c +3 -4
@@ -667,7 +667,7 @@ int iwch_post_zb_read(struct iwch_ep *ep)PDBG ("%s enter\n" , __func__); skb =alloc_skb (40 ,GFP_KERNEL );if (!skb) { -printk (KERN_ERR "%s cannot send zb_read!!\n" , __func__); +pr_err ("%s cannot send zb_read!!\n" , __func__);return -ENOMEM ; } wqe = (union t3_wr *)skb_put (skb,sizeof (struct t3_rdma_read_wr ));
@@ -699,7 +699,7 @@ int iwch_post_terminate(struct iwch_qp *qhp, struct respQ_msg_t *rsp_msg)PDBG ("%s %d\n" , __func__, __LINE__); skb =alloc_skb (40 ,GFP_ATOMIC );if (!skb) { -printk (KERN_ERR "%s cannot send TERMINATE!\n" , __func__); +pr_err ("%s cannot send TERMINATE!\n" , __func__);return -ENOMEM ; } wqe = (union t3_wr *)skb_put (skb,40 );
@@ -1034,8 +1034,7 @@ int iwch_modify_qp(struct iwch_dev *rhp, struct iwch_qp *qhp, goto err;break ;default : -printk (KERN_ERR "%s in a bad state %d\n" , - __func__, qhp->attr.state); +pr_err ("%s in a bad state %d\n" , __func__, qhp->attr.state); ret = -EINVAL ; goto err;break ;
Signature · 1 line
2.10.0.rc2.1.g053435c
RE: [PATCH 1/4] cxgb3: Use more common logging style
Quoted 9 lines
Subject: [PATCH 1/4] cxgb3: Use more common logging style
Convert printks to pr_<level>
Miscellanea:
o Coalesce formats
o Realign arguments
Quoted 7 lines
Signed-off-by Joe Perches <[email protected]>--- drivers/infiniband/hw/cxgb3/cxio_hal.c | 27 ++++++------ drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 +++- drivers/infiniband/hw/cxgb3/cxio_resource.c | 5 ++- drivers/infiniband/hw/cxgb3/iwch.c | 13 +++--- drivers/infiniband/hw/cxgb3/iwch_cm.c | 66
++++++++++++-----------------
Quoted 5 lines
drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 ++- drivers/infiniband/hw/cxgb3/iwch_ev.c | 11 +++-- drivers/infiniband/hw/cxgb3/iwch_provider.c | 11 ++--- drivers/infiniband/hw/cxgb3/iwch_qp.c | 7 ++- 9 files changed, 70 insertions(+), 86 deletions(-)
<snip>
drivers/infiniband/hw/cxgb3/cxio_hal.h int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq,
Quoted 6 lines
drivers/infiniband/hw/cxgb3/cxio_hal.h +0
-0@@ -196,8 +196,13 @@ int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq,
struct
drivers/infiniband/hw/cxgb3/cxio_hal.h int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq, struct t3_cqe *cqe, · line 201
Quoted 9 lines
drivers/infiniband/hw/cxgb3/cxio_hal.h +3
-2t3_cqe *cqe, u8 *cqe_flushed, u64 *cookie, u32 *credit);int iwch_cxgb3_ofld_send (struct t3cdev *tdev,struct sk_buff *skb); -#define MOD "iw_cxgb3: " -#define PDBG(fmt, args...) pr_debug(MOD fmt, ## args) +#ifdef pr_fmt +#undef pr_fmt +#endif
Is the ifdef/undef needed? I see other modules just define pr_fmt() regardless.
Otherwise, looks good (and thanks).
Re: [PATCH 1/4] cxgb3: Use more common logging style
Quoted 1 line · Steve Wise
Quoted 1 line
Subject: [PATCH 1/4] cxgb3: Use more common logging style
[]
Quoted 7 lines
drivers/infiniband/hw/cxgb3/cxio_hal.h int cxio_poll_cq(struct t3_wq *wq, struct t3_cq *cq, struct t3_cqe *cqe, · line 201
Quoted 5 lines
drivers/infiniband/hw/cxgb3/cxio_hal.h +3
-2-#define MOD "iw_cxgb3: " -#define PDBG(fmt, args...) pr_debug(MOD fmt, ## args) +#ifdef pr_fmt +#undef pr_fmt +#endif Is the ifdef/undef needed? I see other modules just define
pr_fmt()regardless.
Yes.
Because kernel.h may be included before this file, kernel.h creates a define for pr_fmt, so this must be undef'd before redefining it.
The other option, done in most files, is to add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/4 cxgb3: Convert PDBG to pr_debug
In reply to Joe PerchesUsing the normal mechanism, not an indirected one, is clearer.
Miscellanea:
o Coalesce formats
o Realign arguments
--- drivers/infiniband/hw/cxgb3/cxio_dbg.c | 35 ++--- drivers/infiniband/hw/cxgb3/cxio_hal.c | 174 ++++++++++++------------ drivers/infiniband/hw/cxgb3/cxio_hal.h | 2 - drivers/infiniband/hw/cxgb3/cxio_resource.c | 20 +-- drivers/infiniband/hw/cxgb3/iwch.c | 6 +- drivers/infiniband/hw/cxgb3/iwch_cm.c | 203 ++++++++++++++-------------- drivers/infiniband/hw/cxgb3/iwch_cm.h | 18 +-- drivers/infiniband/hw/cxgb3/iwch_cq.c | 14 +- drivers/infiniband/hw/cxgb3/iwch_ev.c | 15 +- drivers/infiniband/hw/cxgb3/iwch_mem.c | 2 +- drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++++++------- drivers/infiniband/hw/cxgb3/iwch_provider.h | 9 +- drivers/infiniband/hw/cxgb3/iwch_qp.c | 60 ++++---- 13 files changed, 329 insertions(+), 330 deletions(-)
drivers/infiniband/hw/cxgb3/cxio_dbg.c +19 -16
@@ -51,17 +51,18 @@ void cxio_dump_tpt(struct cxio_rdev *rdev, u32 stag) m->mem_id =MEM_PMRX ; m->addr = (stag>>8 ) *32 + rdev->rnic_info.tpt_base; m->len = size; -PDBG ("%s TPT addr 0x%x len %d\n" , __func__, m->addr, m->len); +pr_debug ("%s TPT addr 0x%x len %d\n" , __func__, m->addr, m->len); rc = rdev->t3cdev_p->ctl (rdev->t3cdev_p,RDMA_GET_MEM , m);if (rc) { -PDBG ("%s toectl returned error %d\n" , __func__, rc); +pr_debug ("%s toectl returned error %d\n" , __func__, rc);kfree (m);return ; } data = (u64 *)m->buf;while (size >0 ) { -PDBG ("TPT %08x: %016llx\n" , m->addr, (unsigned long long ) *data); +pr_debug ("TPT %08x: %016llx\n" , + m->addr, (unsigned long long )*data); size -=8 ; data++; m->addr +=8 ;
@@ -87,18 +88,19 @@ void cxio_dump_pbl(struct cxio_rdev *rdev, u32 pbl_addr, uint len, u8 shift) m->mem_id =MEM_PMRX ; m->addr = pbl_addr; m->len = size; -PDBG ("%s PBL addr 0x%x len %d depth %d\n" , - __func__, m->addr, m->len, npages); +pr_debug ("%s PBL addr 0x%x len %d depth %d\n" , + __func__, m->addr, m->len, npages); rc = rdev->t3cdev_p->ctl (rdev->t3cdev_p,RDMA_GET_MEM , m);if (rc) { -PDBG ("%s toectl returned error %d\n" , __func__, rc); +pr_debug ("%s toectl returned error %d\n" , __func__, rc);kfree (m);return ; } data = (u64 *)m->buf;while (size >0 ) { -PDBG ("PBL %08x: %016llx\n" , m->addr, (unsigned long long ) *data); +pr_debug ("PBL %08x: %016llx\n" , + m->addr, (unsigned long long )*data); size -=8 ; data++; m->addr +=8 ;
@@ -114,8 +116,8 @@ void cxio_dump_wqe(union t3_wr *wqe)if (size ==0 ) size =8 ;while (size >0 ) { -PDBG ("WQE %p: %016llx\n" , data, - (unsigned long long )be64_to_cpu (*data)); +pr_debug ("WQE %p: %016llx\n" , + data, (unsigned long long )be64_to_cpu (*data)); size--; data++; }
@@ -127,8 +129,8 @@ void cxio_dump_wce(struct t3_cqe *wce)int size =sizeof (*wce);while (size >0 ) { -PDBG ("WCE %p: %016llx\n" , data, - (unsigned long long )be64_to_cpu (*data)); +pr_debug ("WCE %p: %016llx\n" , + data, (unsigned long long )be64_to_cpu (*data)); size -=8 ; data++; }
@@ -148,17 +150,18 @@ void cxio_dump_rqt(struct cxio_rdev *rdev, u32 hwtid, int nents) m->mem_id =MEM_PMRX ; m->addr = ((hwtid)<<10 ) + rdev->rnic_info.rqt_base; m->len = size; -PDBG ("%s RQT addr 0x%x len %d\n" , __func__, m->addr, m->len); +pr_debug ("%s RQT addr 0x%x len %d\n" , __func__, m->addr, m->len); rc = rdev->t3cdev_p->ctl (rdev->t3cdev_p,RDMA_GET_MEM , m);if (rc) { -PDBG ("%s toectl returned error %d\n" , __func__, rc); +pr_debug ("%s toectl returned error %d\n" , __func__, rc);kfree (m);return ; } data = (u64 *)m->buf;while (size >0 ) { -PDBG ("RQT %08x: %016llx\n" , m->addr, (unsigned long long ) *data); +pr_debug ("RQT %08x: %016llx\n" , + m->addr, (unsigned long long )*data); size -=8 ; data++; m->addr +=8 ;
@@ -180,10 +183,10 @@ void cxio_dump_tcb(struct cxio_rdev *rdev, u32 hwtid) m->mem_id =MEM_CM ; m->addr = hwtid * size; m->len = size; -PDBG ("%s TCB %d len %d\n" , __func__, m->addr, m->len); +pr_debug ("%s TCB %d len %d\n" , __func__, m->addr, m->len); rc = rdev->t3cdev_p->ctl (rdev->t3cdev_p,RDMA_GET_MEM , m);if (rc) { -PDBG ("%s toectl returned error %d\n" , __func__, rc); +pr_debug ("%s toectl returned error %d\n" , __func__, rc);kfree (m);return ; }
drivers/infiniband/hw/cxgb3/cxio_hal.c +85 -89
366 lines not on this page · raw message
drivers/infiniband/hw/cxgb3/cxio_hal.h +0 -2
@@ -202,8 +202,6 @@ int iwch_cxgb3_ofld_send(struct t3cdev *tdev, struct sk_buff *skb);#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt -#define PDBG(fmt, args...) pr_debug(fmt, ## args) -#ifdef DEBUG void cxio_dump_tpt (struct cxio_rdev *rev,u32 stag);void cxio_dump_pbl (struct cxio_rdev *rev,u32 pbl_addr,uint len,u8 shift);
drivers/infiniband/hw/cxgb3/cxio_resource.c +10 -10
@@ -209,13 +209,13 @@ u32 cxio_hal_get_qpid(struct cxio_hal_resource *rscp) {u32 qpid =cxio_hal_get_resource (&rscp->qpid_fifo, &rscp->qpid_fifo_lock); -PDBG ("%s qpid 0x%x\n" , __func__, qpid); +pr_debug ("%s qpid 0x%x\n" , __func__, qpid);return qpid; }void cxio_hal_put_qpid (struct cxio_hal_resource *rscp,u32 qpid) { -PDBG ("%s qpid 0x%x\n" , __func__, qpid); +pr_debug ("%s qpid 0x%x\n" , __func__, qpid);cxio_hal_put_resource (&rscp->qpid_fifo, &rscp->qpid_fifo_lock, qpid); }
@@ -257,13 +257,13 @@ void cxio_hal_destroy_resource(struct cxio_hal_resource *rscp)u32 cxio_hal_pblpool_alloc (struct cxio_rdev *rdev_p,int size) {unsigned long addr =gen_pool_alloc (rdev_p->pbl_pool, size); -PDBG ("%s addr 0x%x size %d\n" , __func__, (u32 )addr, size); +pr_debug ("%s addr 0x%x size %d\n" , __func__, (u32 )addr, size);return (u32 )addr; }void cxio_hal_pblpool_free (struct cxio_rdev *rdev_p,u32 addr,int size) { -PDBG ("%s addr 0x%x size %d\n" , __func__, addr, size); +pr_debug ("%s addr 0x%x size %d\n" , __func__, addr, size);gen_pool_free (rdev_p->pbl_pool, (unsigned long )addr, size); }
@@ -282,8 +282,8 @@ int cxio_hal_pblpool_create(struct cxio_rdev *rdev_p) pbl_chunk =min (rdev_p->rnic_info.pbl_top - pbl_start +1 , pbl_chunk);if (gen_pool_add (rdev_p->pbl_pool, pbl_start, pbl_chunk,-1 )) { -PDBG ("%s failed to add PBL chunk (%x/%x)\n" , - __func__, pbl_start, pbl_chunk); +pr_debug ("%s failed to add PBL chunk (%x/%x)\n" , + __func__, pbl_start, pbl_chunk);if (pbl_chunk <=1024 <<MIN_PBL_SHIFT ) { pr_warn("%s: Failed to add all PBL chunks (%x/%x)\n", __func__, pbl_start,
@@ -292,8 +292,8 @@ int cxio_hal_pblpool_create(struct cxio_rdev *rdev_p) } pbl_chunk >>=1 ; }else { -PDBG ("%s added PBL chunk (%x/%x)\n" , - __func__, pbl_start, pbl_chunk); +pr_debug ("%s added PBL chunk (%x/%x)\n" , + __func__, pbl_start, pbl_chunk); pbl_start += pbl_chunk; } }
@@ -316,13 +316,13 @@ void cxio_hal_pblpool_destroy(struct cxio_rdev *rdev_p)u32 cxio_hal_rqtpool_alloc (struct cxio_rdev *rdev_p,int size) {unsigned long addr =gen_pool_alloc (rdev_p->rqt_pool, size <<6 ); -PDBG ("%s addr 0x%x size %d\n" , __func__, (u32 )addr, size <<6 ); +pr_debug ("%s addr 0x%x size %d\n" , __func__, (u32 )addr, size <<6 );return (u32 )addr; }void cxio_hal_rqtpool_free (struct cxio_rdev *rdev_p,u32 addr,int size) { -PDBG ("%s addr 0x%x size %d\n" , __func__, addr, size <<6 ); +pr_debug ("%s addr 0x%x size %d\n" , __func__, addr, size <<6 );gen_pool_free (rdev_p->rqt_pool, (unsigned long )addr, size <<6 ); }
drivers/infiniband/hw/cxgb3/iwch.c +3 -3
@@ -105,7 +105,7 @@ static void iwch_db_drop_task(struct work_struct *work)static void rnic_init (struct iwch_dev *rnicp) { -PDBG ("%s iwch_dev %p\n" , __func__, rnicp); +pr_debug ("%s iwch_dev %p\n" , __func__, rnicp);idr_init (&rnicp->cqidr);idr_init (&rnicp->qpidr);idr_init (&rnicp->mmidr);
@@ -145,7 +145,7 @@ static void open_rnic_dev(struct t3cdev *tdev) {struct iwch_dev *rnicp; -PDBG ("%s t3cdev %p\n" , __func__, tdev); +pr_debug ("%s t3cdev %p\n" , __func__, tdev);pr_info_once ("Chelsio T3 RDMA Driver - version %s\n" ,DRV_VERSION ); rnicp = (struct iwch_dev *)ib_alloc_device (sizeof (*rnicp));if (!rnicp) {
@@ -181,7 +181,7 @@ static void open_rnic_dev(struct t3cdev *tdev)static void close_rnic_dev (struct t3cdev *tdev) {struct iwch_dev *dev, *tmp; -PDBG ("%s t3cdev %p\n" , __func__, tdev); +pr_debug ("%s t3cdev %p\n" , __func__, tdev);mutex_lock (&dev_mutex);list_for_each_entry_safe (dev, tmp, &dev_list, entry) {if (dev->rdev.t3cdev_p == tdev) {
drivers/infiniband/hw/cxgb3/iwch_cm.c +102 -101
628 lines not on this page · raw message
drivers/infiniband/hw/cxgb3/iwch_cm.h +9 -9
@@ -53,17 +53,17 @@#define MPA_MARKERS 0x80#define MPA_FLAGS_MASK 0xE0 -#define put_ep (ep) { \ - PDBG("put_ep (via %s:%u) ep %p refcnt %d\n", __func__, __LINE__, \ - ep, kref_read(&((ep)->kref))); \ - WARN_ON(kref_read(&((ep)->kref)) < 1); \ - kref_put(&((ep)->kref), __free_ep); \ +#define put_ep (ep) { \ + pr_debug("put_ep (via %s:%u) ep %p refcnt %d\n", \ + __func__, __LINE__, ep, kref_read(&((ep)->kref))); \ + WARN_ON(kref_read(&((ep)->kref)) < 1); \ + kref_put(&((ep)->kref), __free_ep); \ } -#define get_ep (ep) { \ - PDBG("get_ep (via %s:%u) ep %p, refcnt %d\n", __func__, __LINE__, \ - ep, kref_read(&((ep)->kref))); \ - kref_get(&((ep)->kref)); \ +#define get_ep (ep) { \ + pr_debug("get_ep (via %s:%u) ep %p, refcnt %d\n", \ + __func__, __LINE__, ep, kref_read(&((ep)->kref))); \ + kref_get(&((ep)->kref)); \ }struct mpa_message {
drivers/infiniband/hw/cxgb3/iwch_cq.c +7 -7
@@ -67,8 +67,8 @@ static int iwch_poll_cq_one(struct iwch_dev *rhp, struct iwch_cq *chp, ret =cxio_poll_cq (wq, &(chp->cq), &cqe, &cqe_flushed, &cookie, &credit);if (t3a_device (chp->rhp) && credit) { -PDBG ("%s updating %d cq credits on id %d\n" , __func__, - credit, chp->cq.cqid); +pr_debug ("%s updating %d cq credits on id %d\n" , __func__, + credit, chp->cq.cqid);cxio_hal_cq_op (&rhp->rdev, &chp->cq,CQ_CREDIT_UPDATE , credit); }
@@ -83,11 +83,11 @@ static int iwch_poll_cq_one(struct iwch_dev *rhp, struct iwch_cq *chp, wc->vendor_err =CQE_STATUS (cqe); wc->wc_flags =0 ; -PDBG ("%s qpid 0x%x type %d opcode %d status 0x%x wrid hi 0x%x " -"lo 0x%x cookie 0x%llx\n" , __func__, -CQE_QPID (cqe),CQE_TYPE (cqe), -CQE_OPCODE (cqe),CQE_STATUS (cqe),CQE_WRID_HI (cqe), -CQE_WRID_LOW (cqe), (unsigned long long ) cookie); +pr_debug ("%s qpid 0x%x type %d opcode %d status 0x%x wrid hi 0x%x lo 0x%x cookie 0x%llx\n" , + __func__, +CQE_QPID (cqe),CQE_TYPE (cqe), +CQE_OPCODE (cqe),CQE_STATUS (cqe),CQE_WRID_HI (cqe), +CQE_WRID_LOW (cqe), (unsigned long long )cookie);if (CQE_TYPE (cqe) ==0 ) {if (!CQE_STATUS (cqe))
drivers/infiniband/hw/cxgb3/iwch_ev.c +8 -7
@@ -61,9 +61,10 @@ static void post_qp_event(struct iwch_dev *rnicp, struct iwch_cq *chp,if ((qhp->attr.state ==IWCH_QP_STATE_ERROR ) || (qhp->attr.state ==IWCH_QP_STATE_TERMINATE )) { -PDBG ("%s AE received after RTS - " -"qp state %d qpid 0x%x status 0x%x\n" , __func__, - qhp->attr.state, qhp->wq.qpid,CQE_STATUS (rsp_msg->cqe)); +pr_debug ("%s AE received after RTS - qp state %d qpid 0x%x status 0x%x\n" , + __func__, + qhp->attr.state, qhp->wq.qpid, +CQE_STATUS (rsp_msg->cqe));spin_unlock (&rnicp->lock);return ; }
@@ -136,12 +137,12 @@ void iwch_ev_dispatch(struct cxio_rdev *rdev_p, struct sk_buff *skb)if ((CQE_OPCODE (rsp_msg->cqe) ==T3_TERMINATE ) && (CQE_STATUS (rsp_msg->cqe) ==0 )) {if (SQ_TYPE (rsp_msg->cqe)) { -PDBG ("%s QPID 0x%x ep %p disconnecting\n" , - __func__, qhp->wq.qpid, qhp->ep); +pr_debug ("%s QPID 0x%x ep %p disconnecting\n" , + __func__, qhp->wq.qpid, qhp->ep);iwch_ep_disconnect (qhp->ep,0 ,GFP_ATOMIC ); }else { -PDBG ("%s post REQ_ERR AE QPID 0x%x\n" , __func__, - qhp->wq.qpid); +pr_debug ("%s post REQ_ERR AE QPID 0x%x\n" , __func__, + qhp->wq.qpid);post_qp_event (rnicp, chp, rsp_msg,IB_EVENT_QP_REQ_ERR ,0 );iwch_ep_disconnect (qhp->ep,0 ,GFP_ATOMIC );
drivers/infiniband/hw/cxgb3/iwch_mem.c +1 -1
@@ -48,7 +48,7 @@ static int iwch_finish_mem_reg(struct iwch_mr *mhp, u32 stag) mhp->attr.stag = stag; mmid = stag >>8 ; mhp->ibmr.rkey = mhp->ibmr.lkey = stag; -PDBG ("%s mmid 0x%x mhp %p\n" , __func__, mmid, mhp); +pr_debug ("%s mmid 0x%x mhp %p\n" , __func__, mmid, mhp);return insert_handle (mhp->rhp, &mhp->rhp->mmidr, mhp, mmid); }
drivers/infiniband/hw/cxgb3/iwch_provider.c +50 -51
334 lines not on this page · raw message
drivers/infiniband/hw/cxgb3/iwch_provider.h +5 -4
@@ -217,8 +217,9 @@ static inline struct iwch_mm_entry *remove_mmap(struct iwch_ucontext *ucontext,if (mm->key == key && mm->len == len) {list_del_init (&mm->entry);spin_unlock (&ucontext->mmap_lock); -PDBG ("%s key 0x%x addr 0x%llx len %d\n" , __func__, - key, (unsigned long long ) mm->addr, mm->len); +pr_debug ("%s key 0x%x addr 0x%llx len %d\n" , + __func__, key, + (unsigned long long )mm->addr, mm->len);return mm; } }
@@ -230,8 +231,8 @@ static inline void insert_mmap(struct iwch_ucontext *ucontext, struct iwch_mm_entry *mm) {spin_lock (&ucontext->mmap_lock); -PDBG ("%s key 0x%x addr 0x%llx len %d\n" , __func__, - mm->key, (unsigned long long ) mm->addr, mm->len); +pr_debug ("%s key 0x%x addr 0x%llx len %d\n" , + __func__, mm->key, (unsigned long long )mm->addr, mm->len);list_add_tail (&mm->entry, &ucontext->mmaps);spin_unlock (&ucontext->mmap_lock); }
drivers/infiniband/hw/cxgb3/iwch_qp.c +30 -30
150 lines not on this page · raw message
Signature · 1 line
2.10.0.rc2.1.g053435c
RE: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
Quoted 9 lines
Subject: [PATCH 2/4] cxgb3: Convert PDBG to
pr_debugUsing the normal mechanism, not an indirected one, is clearer.
Miscellanea:
o Coalesce formats
o Realign arguments
Quoted 8 lines
Signed-off-by Joe Perches <[email protected]>--- drivers/infiniband/hw/cxgb3/cxio_dbg.c | 35 ++--- drivers/infiniband/hw/cxgb3/cxio_hal.c | 174 ++++++++++++------------ drivers/infiniband/hw/cxgb3/cxio_hal.h | 2 - drivers/infiniband/hw/cxgb3/cxio_resource.c | 20 +-- drivers/infiniband/hw/cxgb3/iwch.c | 6 +- drivers/infiniband/hw/cxgb3/iwch_cm.c | 203
++++++++++++++--------------
Quoted 9 lines
drivers/infiniband/hw/cxgb3/iwch_cm.h | 18 +-- drivers/infiniband/hw/cxgb3/iwch_cq.c | 14 +- drivers/infiniband/hw/cxgb3/iwch_ev.c | 15 +- drivers/infiniband/hw/cxgb3/iwch_mem.c | 2 +- drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++++++------- drivers/infiniband/hw/cxgb3/iwch_provider.h | 9 +- drivers/infiniband/hw/cxgb3/iwch_qp.c | 60 ++++---- 13 files changed, 329 insertions(+), 330 deletions(-)
Looks good (and thanks).
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 3/4 cxgb4: Use more common logging style
In reply to Joe PerchesConvert printks to pr_<level>
Miscellanea:
o Coalesce formats
o Realign arguments
--- drivers/infiniband/hw/cxgb4/cm.c | 84 +++++++++++++++------------------- drivers/infiniband/hw/cxgb4/cq.c | 8 ++-- drivers/infiniband/hw/cxgb4/device.c | 83 ++++++++++++++------------------- drivers/infiniband/hw/cxgb4/ev.c | 10 ++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 6 +++ drivers/infiniband/hw/cxgb4/mem.c | 6 +-- drivers/infiniband/hw/cxgb4/provider.c | 4 +- drivers/infiniband/hw/cxgb4/qp.c | 5 +- drivers/infiniband/hw/cxgb4/resource.c | 18 +++----- drivers/infiniband/hw/cxgb4/t4.h | 2 +- 10 files changed, 97 insertions(+), 129 deletions(-)
drivers/infiniband/hw/cxgb4/cm.c +37 -47
@@ -467,7 +467,7 @@ static struct net_device *get_real_dev(struct net_device *egress_dev)static void arp_failure_discard (void *handle,struct sk_buff *skb) { -pr_err (MOD "ARP failure\n" ); +pr_err ("ARP failure\n" );kfree_skb (skb); }
@@ -528,7 +528,7 @@ static void pass_accept_rpl_arp_failure(void *handle, struct sk_buff *skb) {struct c4iw_ep *ep = handle; -pr_err (MOD "ARP failure during accept - tid %u -dropping connection\n" , +pr_err ("ARP failure during accept - tid %u - dropping connection\n" , ep->hwtid);__state_set (&ep->com,DEAD );
@@ -542,7 +542,7 @@ static void act_open_req_arp_failure(void *handle, struct sk_buff *skb) {struct c4iw_ep *ep = handle; - printk(KERN_ERR MOD "ARP failure during connect\n"); +pr_err ("ARP failure during connect\n" );connect_reply_upcall (ep, -EHOSTUNREACH );__state_set (&ep->com,DEAD );if (ep->com.remote_addr.ss_family ==AF_INET6 ) {
@@ -720,8 +720,7 @@ static int send_connect(struct c4iw_ep *ep) skb =get_skb (NULL , wrlen,GFP_KERNEL );if (!skb) { - printk(KERN_ERR MOD "%s - failed to alloc skb.\n", - __func__); +pr_err ("%s - failed to alloc skb\n" , __func__);return -ENOMEM ; }set_wr_txq (skb,CPL_PRIORITY_SETUP , ep->ctrlq_idx);
@@ -1007,7 +1006,7 @@ static int send_mpa_reject(struct c4iw_ep *ep, const void *pdata, u8 plen) skb =get_skb (NULL , wrlen,GFP_KERNEL );if (!skb) { - printk(KERN_ERR MOD "%s - cannot alloc skb!\n", __func__); +pr_err ("%s - cannot alloc skb!\n" , __func__);return -ENOMEM ; }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx);
@@ -1087,7 +1086,7 @@ static int send_mpa_reply(struct c4iw_ep *ep, const void *pdata, u8 plen) skb =get_skb (NULL , wrlen,GFP_KERNEL );if (!skb) { - printk(KERN_ERR MOD "%s - cannot alloc skb!\n", __func__); +pr_err ("%s - cannot alloc skb!\n" , __func__);return -ENOMEM ; }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx);
@@ -1363,7 +1362,7 @@ static int update_rx_credits(struct c4iw_ep *ep, u32 credits)PDBG ("%s ep %p tid %u credits %u\n" , __func__, ep, ep->hwtid, credits); skb =get_skb (NULL , wrlen,GFP_KERNEL );if (!skb) { - printk(KERN_ERR MOD "update_rx_credits - cannot alloc skb!\n"); +pr_err ("update_rx_credits - cannot alloc skb!\n" );return 0 ; }
@@ -1438,8 +1437,8 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb)/* Validate MPA header. */ if (mpa->revision > mpa_rev) { - printk(KERN_ERR MOD "%s MPA version mismatch. Local = %d," - " Received = %d\n", __func__, mpa_rev, mpa->revision); +pr_err ("%s MPA version mismatch. Local = %d, Received = %d\n" , + __func__, mpa_rev, mpa->revision); err = -EPROTO ; goto err_stop_timer; }
@@ -1594,7 +1593,7 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb)* supports, generate TERM message */ if (rtr_mismatch) { -printk (KERN_ERR "%s: RTR mismatch, sending TERM\n" , __func__); +pr_err ("%s: RTR mismatch, sending TERM\n" , __func__); attrs.layer_etype =LAYER_MPA |DDP_LLP ; attrs.ecode =MPA_NOMATCH_RTR ; attrs.next_state =C4IW_QP_STATE_TERMINATE ;
@@ -1613,8 +1612,7 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb)* initiator ORD. */ if (insuff_ird) { -printk (KERN_ERR "%s: Insufficient IRD, sending TERM\n" , - __func__); +pr_err ("%s: Insufficient IRD, sending TERM\n" , __func__); attrs.layer_etype =LAYER_MPA |DDP_LLP ; attrs.ecode =MPA_INSUFF_IRD ; attrs.next_state =C4IW_QP_STATE_TERMINATE ;
@@ -1685,8 +1683,8 @@ static int process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb)* Validate MPA Header. */ if (mpa->revision > mpa_rev) { - printk(KERN_ERR MOD "%s MPA version mismatch. Local = %d," - " Received = %d\n", __func__, mpa_rev, mpa->revision); +pr_err ("%s MPA version mismatch. Local = %d, Received = %d\n" , + __func__, mpa_rev, mpa->revision); goto err_stop_timer; }
@@ -1850,7 +1848,7 @@ static int abort_rpl(struct c4iw_dev *dev, struct sk_buff *skb) ep =get_ep_from_tid (dev, tid);if (!ep) { - printk(KERN_WARNING MOD "Abort rpl to freed endpoint\n"); +pr_warn ("Abort rpl to freed endpoint\n" );return 0 ; }PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);
@@ -1862,8 +1860,7 @@ static int abort_rpl(struct c4iw_dev *dev, struct sk_buff *skb) release =1 ;break ;default : -printk (KERN_ERR "%s ep %p state %d\n" , - __func__, ep, ep->com.state); +pr_err ("%s ep %p state %d\n" , __func__, ep, ep->com.state);break ; }mutex_unlock (&ep->com.mutex);
@@ -2108,7 +2105,7 @@ static int c4iw_reconnect(struct c4iw_ep *ep)*/ ep->atid =cxgb4_alloc_atid (ep->com.dev->rdev.lldi.tids, ep);if (ep->atid ==-1 ) { -pr_err ("%s - cannot alloc atid.\n" , __func__); +pr_err ("%s - cannot alloc atid\n" , __func__); err = -ENOMEM ; goto fail2; }
@@ -2135,7 +2132,7 @@ static int c4iw_reconnect(struct c4iw_ep *ep) ra = (__u8 *)&raddr6->sin6_addr; }if (!ep->dst) { -pr_err ("%s - cannot find route.\n" , __func__); +pr_err ("%s - cannot find route\n" , __func__); err = -EHOSTUNREACH ; goto fail3; }
@@ -2143,7 +2140,7 @@ static int c4iw_reconnect(struct c4iw_ep *ep) ep->com.dev->rdev.lldi.adapter_type, ep->com.cm_id->tos);if (err) { -pr_err ("%s - cannot alloc l2e.\n" , __func__); +pr_err ("%s - cannot alloc l2e\n" , __func__); goto fail4; }
@@ -2477,15 +2474,13 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb) &parent_ep->com.local_addr)->sin6_scope_id); }if (!dst) { - printk(KERN_ERR MOD "%s - failed to find dst entry!\n", - __func__); +pr_err ("%s - failed to find dst entry!\n" , __func__); goto reject; } child_ep =alloc_ep (sizeof (*child_ep),GFP_KERNEL );if (!child_ep) { - printk(KERN_ERR MOD "%s - failed to allocate ep entry!\n", - __func__); +pr_err ("%s - failed to allocate ep entry!\n" , __func__);dst_release (dst); goto reject; }
@@ -2493,8 +2488,7 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb) err =import_ep (child_ep, iptype, peer_ip, dst, dev, false, parent_ep->com.dev->rdev.lldi.adapter_type, tos);if (err) { - printk(KERN_ERR MOD "%s - failed to allocate l2t entry!\n", - __func__); +pr_err ("%s - failed to allocate l2t entry!\n" , __func__);dst_release (dst);kfree (child_ep); goto reject;
@@ -2781,9 +2775,7 @@ static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb) ep->com.qp,C4IW_QP_ATTR_NEXT_STATE , &attrs, 1);if (ret) - printk(KERN_ERR MOD -"%s - qp <- error failed!\n" , - __func__); +pr_err ("%s - qp <- error failed!\n" , __func__); }peer_abort_upcall (ep);break ;
@@ -2902,13 +2894,13 @@ static int terminate(struct c4iw_dev *dev, struct sk_buff *skb)BUG_ON (!ep);if (ep && ep->com.qp) { - printk(KERN_WARNING MOD "TERM received tid %u qpid %u\n", tid, - ep->com.qp->wq.sq.qid); +pr_warn ("TERM received tid %u qpid %u\n" , + tid, ep->com.qp->wq.sq.qid); attrs.next_state =C4IW_QP_STATE_TERMINATE ;c4iw_modify_qp (ep->com.qp->rhp, ep->com.qp,C4IW_QP_ATTR_NEXT_STATE , &attrs,1 ); }else - printk(KERN_WARNING MOD "TERM received tid %u no ep/qp\n", tid); +pr_warn ("TERM received tid %u no ep/qp\n" , tid);c4iw_put_ep (&ep->com);return 0 ;
@@ -3172,7 +3164,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) } ep =alloc_ep (sizeof (*ep),GFP_KERNEL );if (!ep) { - printk(KERN_ERR MOD "%s - cannot alloc ep.\n", __func__); +pr_err ("%s - cannot alloc ep\n" , __func__); err = -ENOMEM ; goto out; }
@@ -3212,7 +3204,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)*/ ep->atid =cxgb4_alloc_atid (dev->rdev.lldi.tids, ep);if (ep->atid ==-1 ) { - printk(KERN_ERR MOD "%s - cannot alloc atid.\n", __func__); +pr_err ("%s - cannot alloc atid\n" , __func__); err = -ENOMEM ; goto fail2; }
@@ -3276,7 +3268,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) raddr6->sin6_scope_id); }if (!ep->dst) { - printk(KERN_ERR MOD "%s - cannot find route.\n", __func__); +pr_err ("%s - cannot find route\n" , __func__); err = -EHOSTUNREACH ; goto fail3; }
@@ -3284,7 +3276,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) err =import_ep (ep, iptype, ra, ep->dst, ep->com.dev, true, ep->com.dev->rdev.lldi.adapter_type, cm_id->tos);if (err) { - printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); +pr_err ("%s - cannot alloc l2e\n" , __func__); goto fail4; }
@@ -3398,7 +3390,7 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog) ep =alloc_ep (sizeof (*ep),GFP_KERNEL );if (!ep) { - printk(KERN_ERR MOD "%s - cannot alloc ep.\n", __func__); +pr_err ("%s - cannot alloc ep\n" , __func__); err = -ENOMEM ; goto fail1; }
@@ -3423,7 +3415,7 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog) cm_id->m_local_addr.ss_family, ep);if (ep->stid ==-1 ) { - printk(KERN_ERR MOD "%s - cannot alloc stid.\n", __func__); +pr_err ("%s - cannot alloc stid\n" , __func__); err = -ENOMEM ; goto fail2; }
@@ -3584,8 +3576,7 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)C4IW_QP_ATTR_NEXT_STATE , &attrs, 1);if (ret) -pr_err (MOD -"%s - qp <- error failed!\n" , +pr_err ("%s - qp <- error failed!\n" , __func__); } fatal =1 ;
@@ -4141,8 +4132,8 @@ static int set_tcb_rpl(struct c4iw_dev *dev, struct sk_buff *skb)struct cpl_set_tcb_rpl *rpl =cplhdr (skb);if (rpl->status !=CPL_ERR_NONE ) { - printk(KERN_ERR MOD "Unexpected SET_TCB_RPL status %u " - "for tid %u\n", rpl->status, GET_TID(rpl)); +pr_err ("Unexpected SET_TCB_RPL status %u for tid %u\n" , + rpl->status,GET_TID (rpl)); }kfree_skb (skb);return 0 ;
@@ -4170,8 +4161,8 @@ static int fw6_msg(struct c4iw_dev *dev, struct sk_buff *skb)sched (dev, skb);break ;default : - printk(KERN_ERR MOD "%s unexpected fw6 msg type %u\n", __func__, - rpl->type); +pr_err ("%s unexpected fw6 msg type %u\n" , + __func__, rpl->type);kfree_skb (skb);break ; }
@@ -4187,8 +4178,7 @@ static int peer_abort_intr(struct c4iw_dev *dev, struct sk_buff *skb) ep =get_ep_from_tid (dev, tid);/* This EP will be dereferenced in peer_abort() */ if (!ep) { - printk(KERN_WARNING MOD - "Abort on non-existent endpoint, tid %d\n", tid); +pr_warn ("Abort on non-existent endpoint, tid %d\n" , tid);kfree_skb (skb);return 0 ; }
drivers/infiniband/hw/cxgb4/cq.c +3 -5
@@ -159,7 +159,7 @@ static int create_cq(struct c4iw_rdev *rdev, struct t4_cq *cq, &cq->bar2_qid, user ? &cq->bar2_pa : NULL);if (user && !cq->bar2_pa) { -pr_warn (MOD "%s: cqid %u not in BAR2 range.\n" , +pr_warn ("%s: cqid %u not in BAR2 range\n" ,pci_name (rdev->lldi.pdev), cq->cqid); ret = -EINVAL ; goto err4;
@@ -766,8 +766,7 @@ static int c4iw_poll_cq_one(struct c4iw_cq *chp, struct ib_wc *wc) wc->opcode =IB_WC_SEND ;break ;default : - printk(KERN_ERR MOD "Unexpected opcode %d " -"in the CQE received for QPID=0x%0x\n" , +pr_err ("Unexpected opcode %d in the CQE received for QPID=0x%0x\n" ,CQE_OPCODE (&cqe),CQE_QPID (&cqe)); ret = -EINVAL ; goto out;
@@ -822,8 +821,7 @@ static int c4iw_poll_cq_one(struct c4iw_cq *chp, struct ib_wc *wc) wc->status =IB_WC_WR_FLUSH_ERR ;break ;default : - printk(KERN_ERR MOD -"Unexpected cqe_status 0x%x for QPID=0x%0x\n" , +pr_err ("Unexpected cqe_status 0x%x for QPID=0x%0x\n" ,CQE_STATUS (&cqe),CQE_QPID (&cqe)); wc->status =IB_WC_FATAL_ERR ; }
drivers/infiniband/hw/cxgb4/device.c +34 -49
237 lines not on this page · raw message
drivers/infiniband/hw/cxgb4/ev.c +4 -6
@@ -124,8 +124,7 @@ void c4iw_ev_dispatch(struct c4iw_dev *dev, struct t4_cqe *err_cqe)spin_lock_irq (&dev->lock); qhp =get_qhp (dev,CQE_QPID (err_cqe));if (!qhp) { - printk(KERN_ERR MOD "BAD AE qpid 0x%x opcode %d " -"status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x\n" , + pr_err("BAD AE qpid 0x%x opcode %d status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x\n", CQE_QPID(err_cqe), CQE_OPCODE(err_cqe), CQE_STATUS(err_cqe), CQE_TYPE(err_cqe), CQE_WRID_HI(err_cqe),
@@ -140,8 +139,7 @@ void c4iw_ev_dispatch(struct c4iw_dev *dev, struct t4_cqe *err_cqe) cqid = qhp->attr.rcq; chp =get_chp (dev, cqid);if (!chp) { - printk(KERN_ERR MOD "BAD AE cqid 0x%x qpid 0x%x opcode %d " -"status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x\n" , + pr_err("BAD AE cqid 0x%x qpid 0x%x opcode %d status 0x%x type %d wrid.hi 0x%x wrid.lo 0x%x\n", cqid, CQE_QPID(err_cqe), CQE_OPCODE(err_cqe), CQE_STATUS(err_cqe), CQE_TYPE(err_cqe), CQE_WRID_HI(err_cqe),
@@ -165,7 +163,7 @@ void c4iw_ev_dispatch(struct c4iw_dev *dev, struct t4_cqe *err_cqe)/* Completion Events */ case T4_ERR_SUCCESS : - printk(KERN_ERR MOD "AE with status 0!\n"); +pr_err ("AE with status 0!\n" );break ;case T4_ERR_STAG :
@@ -207,7 +205,7 @@ void c4iw_ev_dispatch(struct c4iw_dev *dev, struct t4_cqe *err_cqe)break ;default : - printk(KERN_ERR MOD "Unknown T4 status 0x%x QPID 0x%x\n", +pr_err ("Unknown T4 status 0x%x QPID 0x%x\n" ,CQE_STATUS (err_cqe), qhp->wq.sq.qid);post_qp_event (dev, chp, qhp, err_cqe,IB_EVENT_QP_FATAL );break ;
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +6 -0
@@ -64,6 +64,12 @@#define DRV_NAME "iw_cxgb4"#define MOD DRV_NAME ":" +#ifdef pr_fmt +#undef pr_fmt +#endif + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +extern int c4iw_debug; #define PDBG(fmt, args...) \ do { \
drivers/infiniband/hw/cxgb4/mem.c +2 -4
@@ -234,10 +234,8 @@ static int write_adapter_mem(struct c4iw_rdev *rdev, u32 addr, u32 len,if (is_t5 (rdev->lldi.adapter_type) && use_dsgl) {if (len > inline_threshold) {if (_c4iw_write_mem_dma (rdev, addr, len, data, skb)) { -printk_ratelimited (KERN_WARNING -"%s: dma map" -" failure (non fatal)\n" , -pci_name (rdev->lldi.pdev)); +pr_warn_ratelimited ("%s: dma map failure (non fatal)\n" , +pci_name (rdev->lldi.pdev));return _c4iw_write_mem_inline (rdev, addr, len, data, skb); }else {
drivers/infiniband/hw/cxgb4/provider.c +1 -3
@@ -123,7 +123,6 @@ static struct ib_ucontext *c4iw_alloc_ucontext(struct ib_device *ibdev, {struct c4iw_ucontext *context;struct c4iw_dev *rhp =to_c4iw_dev (ibdev); -static int warned;struct c4iw_alloc_ucontext_resp uresp;int ret =0 ;struct c4iw_mm_entry *mm =NULL ;
@@ -141,8 +140,7 @@ static struct ib_ucontext *c4iw_alloc_ucontext(struct ib_device *ibdev,kref_init (&context->kref);if (udata->outlen <sizeof (uresp) -sizeof (uresp.reserved)) { -if (!warned++) -pr_err (MOD "Warning - downlevel libcxgb4 (non-fatal), device status page disabled." ); +pr_err_once ("Warning - downlevel libcxgb4 (non-fatal), device status page disabled\n" ); rhp->rdev.flags |=T4_STATUS_PAGE_DISABLED ; }else { mm =kmalloc (sizeof (*mm),GFP_KERNEL );
drivers/infiniband/hw/cxgb4/qp.c +2 -3
@@ -275,7 +275,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,* User mode must have bar2 access. */ if (user && (!wq->sq.bar2_pa || !wq->rq.bar2_pa)) { -pr_warn (MOD "%s: sqid %u or rqid %u not in BAR2 range.\n" , +pr_warn ("%s: sqid %u or rqid %u not in BAR2 range\n" ,pci_name (rdev->lldi.pdev), wq->sq.qid, wq->rq.qid); goto free_dma; }
@@ -1671,8 +1671,7 @@ int c4iw_modify_qp(struct c4iw_dev *rhp, struct c4iw_qp *qhp, goto err;break ;default : -printk (KERN_ERR "%s in a bad state %d\n" , - __func__, qhp->attr.state); +pr_err ("%s in a bad state %d\n" , __func__, qhp->attr.state); ret = -EINVAL ; goto err;break ;
drivers/infiniband/hw/cxgb4/resource.c +7 -11
@@ -293,10 +293,8 @@ int c4iw_pblpool_create(struct c4iw_rdev *rdev)PDBG ("%s failed to add PBL chunk (%x/%x)\n" , __func__, pbl_start, pbl_chunk);if (pbl_chunk <=1024 <<MIN_PBL_SHIFT ) { - printk(KERN_WARNING MOD -"Failed to add all PBL chunks (%x/%x)\n" , - pbl_start, - pbl_top - pbl_start); +pr_warn ("Failed to add all PBL chunks (%x/%x)\n" , + pbl_start, pbl_top - pbl_start);return 0 ; } pbl_chunk >>=1 ;
@@ -326,7 +324,7 @@ u32 c4iw_rqtpool_alloc(struct c4iw_rdev *rdev, int size)unsigned long addr =gen_pool_alloc (rdev->rqt_pool, size <<6 );PDBG ("%s addr 0x%x size %d\n" , __func__, (u32 )addr, size <<6 );if (!addr) -pr_warn_ratelimited (MOD "%s: Out of RQT memory\n" , +pr_warn_ratelimited ("%s: Out of RQT memory\n" ,pci_name (rdev->lldi.pdev));mutex_lock (&rdev->stats.lock);if (addr) {
@@ -366,9 +364,8 @@ int c4iw_rqtpool_create(struct c4iw_rdev *rdev)PDBG ("%s failed to add RQT chunk (%x/%x)\n" , __func__, rqt_start, rqt_chunk);if (rqt_chunk <=1024 <<MIN_RQT_SHIFT ) { - printk(KERN_WARNING MOD -"Failed to add all RQT chunks (%x/%x)\n" , - rqt_start, rqt_top - rqt_start); +pr_warn ("Failed to add all RQT chunks (%x/%x)\n" , + rqt_start, rqt_top - rqt_start);return 0 ; } rqt_chunk >>=1 ;
@@ -432,9 +429,8 @@ int c4iw_ocqp_pool_create(struct c4iw_rdev *rdev)PDBG ("%s failed to add OCQP chunk (%x/%x)\n" , __func__, start, chunk);if (chunk <=1024 <<MIN_OCQP_SHIFT ) { - printk(KERN_WARNING MOD -"Failed to add all OCQP chunks (%x/%x)\n" , - start, top - start); +pr_warn ("Failed to add all OCQP chunks (%x/%x)\n" , + start, top - start);return 0 ; } chunk >>=1 ;
drivers/infiniband/hw/cxgb4/t4.h +1 -1
@@ -656,7 +656,7 @@ static inline int t4_next_hw_cqe(struct t4_cq *cq, struct t4_cqe **cqe)if (cq->queue[prev_cidx].bits_type_ts != cq->bits_type_ts) { ret = -EOVERFLOW ; cq->error =1 ; - printk(KERN_ERR MOD "cq overflow cqid %u\n", cq->cqid); +pr_err ("cq overflow cqid %u\n" , cq->cqid);BUG_ON (1 ); }else if (t4_valid_cqe (cq, &cq->queue[cq->cidx])) {
Signature · 1 line
2.10.0.rc2.1.g053435c
RE: [PATCH 3/4] cxgb4: Use more common logging style
Quoted 11 lines
Convert printks to pr_<level>
Miscellanea:
o Coalesce formats
o Realign argumentsSigned-off-by Joe Perches <[email protected]>--- drivers/infiniband/hw/cxgb4/cm.c | 84
+++++++++++++++-------------------
Quoted 11 lines
drivers/infiniband/hw/cxgb4/cq.c | 8 ++-- drivers/infiniband/hw/cxgb4/device.c | 83 ++++++++++++++------------------- drivers/infiniband/hw/cxgb4/ev.c | 10 ++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 6 +++ drivers/infiniband/hw/cxgb4/mem.c | 6 +-- drivers/infiniband/hw/cxgb4/provider.c | 4 +- drivers/infiniband/hw/cxgb4/qp.c | 5 +- drivers/infiniband/hw/cxgb4/resource.c | 18 +++----- drivers/infiniband/hw/cxgb4/t4.h | 2 +- 10 files changed, 97 insertions(+), 129 deletions(-)
Looks good (and thanks).
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 4/4 cxgb4: Convert PDBG to pr_debug
In reply to Joe PerchesUse a more typical logging style.
Miscellanea:
o Obsolete the c4iw_debug module parameter
o Coalesce formats
o Realign arguments
--- drivers/infiniband/hw/cxgb4/cm.c | 303 +++++++++++++++++---------------- drivers/infiniband/hw/cxgb4/cq.c | 71 ++++---- drivers/infiniband/hw/cxgb4/device.c | 58 +++---- drivers/infiniband/hw/cxgb4/ev.c | 29 ++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 44 +++-- drivers/infiniband/hw/cxgb4/mem.c | 28 +-- drivers/infiniband/hw/cxgb4/provider.c | 38 ++--- drivers/infiniband/hw/cxgb4/qp.c | 91 +++++----- drivers/infiniband/hw/cxgb4/resource.c | 46 ++--- drivers/infiniband/hw/cxgb4/t4.h | 22 +-- 10 files changed, 368 insertions(+), 362 deletions(-)
drivers/infiniband/hw/cxgb4/cm.c +156 -147
@@ -101,7 +101,7 @@ MODULE_PARM_DESC(enable_tcp_window_scaling,int c4iw_debug;module_param (c4iw_debug, int,0644 ); -MODULE_PARM_DESC (c4iw_debug,"Enable debug logging (default=0)" ); +MODULE_PARM_DESC (c4iw_debug,"obsolete" );static int peer2peer =1 ;module_param (peer2peer, int,0644 );
@@ -180,7 +180,7 @@ static void ref_qp(struct c4iw_ep *ep)static void start_ep_timer (struct c4iw_ep *ep) { -PDBG ("%s ep %p\n" , __func__, ep); +pr_debug ("%s ep %p\n" , __func__, ep);if (timer_pending (&ep->timer)) {pr_err ("%s timer already started! ep %p\n" , __func__, ep);
@@ -196,7 +196,7 @@ static void start_ep_timer(struct c4iw_ep *ep)static int stop_ep_timer (struct c4iw_ep *ep) { -PDBG ("%s ep %p stopping\n" , __func__, ep); +pr_debug ("%s ep %p stopping\n" , __func__, ep);del_timer_sync (&ep->timer);if (!test_and_set_bit (TIMEOUT , &ep->com.flags)) {c4iw_put_ep (&ep->com);
@@ -212,7 +212,7 @@ static int c4iw_l2t_send(struct c4iw_rdev *rdev, struct sk_buff *skb,if (c4iw_fatal_error (rdev)) {kfree_skb (skb); -PDBG ("%s - device in error state - dropping\n" , __func__); +pr_debug ("%s - device in error state - dropping\n" , __func__);return -EIO ; } error =cxgb4_l2t_send (rdev->lldi.ports[0 ], skb, l2e);
@@ -229,7 +229,7 @@ int c4iw_ofld_send(struct c4iw_rdev *rdev, struct sk_buff *skb)if (c4iw_fatal_error (rdev)) {kfree_skb (skb); -PDBG ("%s - device in error state - dropping\n" , __func__); +pr_debug ("%s - device in error state - dropping\n" , __func__);return -EIO ; } error =cxgb4_ofld_send (rdev->lldi.ports[0 ], skb);
@@ -263,10 +263,10 @@ static void set_emss(struct c4iw_ep *ep, u16 opt)if (ep->emss <128 ) ep->emss =128 ;if (ep->emss &7 ) -PDBG ("Warning: misaligned mtu idx %u mss %u emss=%u\n" , -TCPOPT_MSS_G (opt), ep->mss, ep->emss); -PDBG ("%s mss_idx %u mss %u emss=%u\n" , __func__,TCPOPT_MSS_G (opt), - ep->mss, ep->emss); +pr_debug ("Warning: misaligned mtu idx %u mss %u emss=%u\n" , +TCPOPT_MSS_G (opt), ep->mss, ep->emss); +pr_debug ("%s mss_idx %u mss %u emss=%u\n" , __func__,TCPOPT_MSS_G (opt), + ep->mss, ep->emss); }static enum c4iw_ep_state state_read (struct c4iw_ep_common *epc)
@@ -287,7 +287,7 @@ static void __state_set(struct c4iw_ep_common *epc, enum c4iw_ep_state new)static void state_set (struct c4iw_ep_common *epc,enum c4iw_ep_state new) {mutex_lock (&epc->mutex); -PDBG ("%s - %s -> %s\n" , __func__, states[epc->state], states[new]); +pr_debug ("%s - %s -> %s\n" , __func__, states[epc->state], states[new]);__state_set (epc, new);mutex_unlock (&epc->mutex);return ;
@@ -322,7 +322,7 @@ static void *alloc_ep(int size, gfp_t gfp)mutex_init (&epc->mutex);c4iw_init_wr_wait (&epc->wr_wait); } -PDBG ("%s alloc ep %p\n" , __func__, epc); +pr_debug ("%s alloc ep %p\n" , __func__, epc);return epc; }
@@ -384,7 +384,7 @@ void _c4iw_free_ep(struct kref *kref)struct c4iw_ep *ep; ep = container_of(kref, struct c4iw_ep, com.kref); -PDBG ("%s ep %p state %s\n" , __func__, ep, states[ep->com.state]); +pr_debug ("%s ep %p state %s\n" , __func__, ep, states[ep->com.state]);if (test_bit (QP_REFERENCED , &ep->com.flags))deref_qp (ep);if (test_bit (RELEASE_RESOURCES , &ep->com.flags)) {
@@ -567,7 +567,7 @@ static void abort_arp_failure(void *handle, struct sk_buff *skb)struct c4iw_rdev *rdev = &ep->com.dev->rdev;struct cpl_abort_req *req =cplhdr (skb); -PDBG ("%s rdev %p\n" , __func__, rdev); +pr_debug ("%s rdev %p\n" , __func__, rdev); req->cmd =CPL_ABORT_NO_RST ; ret =c4iw_ofld_send (rdev, skb);if (ret) {
@@ -642,7 +642,7 @@ static int send_halfclose(struct c4iw_ep *ep)struct sk_buff *skb =skb_dequeue (&ep->com.ep_skb_list);u32 wrlen =roundup (sizeof (struct cpl_close_con_req ),16 ); -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);if (WARN_ON (!skb))return -ENOMEM ;
@@ -657,7 +657,7 @@ static int send_abort(struct c4iw_ep *ep)u32 wrlen =roundup (sizeof (struct cpl_abort_req ),16 );struct sk_buff *req_skb =skb_dequeue (&ep->com.ep_skb_list); -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);if (WARN_ON (!req_skb))return -ENOMEM ;
@@ -716,7 +716,7 @@ static int send_connect(struct c4iw_ep *ep) roundup(sizev4, 16) :roundup (sizev6,16 ); -PDBG ("%s ep %p atid %u\n" , __func__, ep, ep->atid); +pr_debug ("%s ep %p atid %u\n" , __func__, ep, ep->atid); skb =get_skb (NULL , wrlen,GFP_KERNEL );if (!skb) {
@@ -818,7 +818,7 @@ static int send_connect(struct c4iw_ep *ep) ep->com.dev->rdev.lldi.ports[0 ], ep->l2t))); t5req->rsvd =cpu_to_be32 (isn); -PDBG ("%s snd_isn %u\n" , __func__, t5req->rsvd); +pr_debug ("%s snd_isn %u\n" , __func__, t5req->rsvd); t5req->opt2 =cpu_to_be32 (opt2); } }else {
@@ -868,7 +868,7 @@ static int send_connect(struct c4iw_ep *ep) ep->com.dev->rdev.lldi.ports[0 ], ep->l2t))); t5req6->rsvd =cpu_to_be32 (isn); -PDBG ("%s snd_isn %u\n" , __func__, t5req6->rsvd); +pr_debug ("%s snd_isn %u\n" , __func__, t5req6->rsvd); t5req6->opt2 =cpu_to_be32 (opt2); } }
@@ -890,7 +890,8 @@ static int send_mpa_req(struct c4iw_ep *ep, struct sk_buff *skb,struct mpa_message *mpa;struct mpa_v2_conn_params mpa_v2_params; -PDBG ("%s ep %p tid %u pd_len %d\n" , __func__, ep, ep->hwtid, ep->plen); +pr_debug ("%s ep %p tid %u pd_len %d\n" , + __func__, ep, ep->hwtid, ep->plen);BUG_ON (skb_cloned (skb));
@@ -944,8 +945,8 @@ static int send_mpa_req(struct c4iw_ep *ep, struct sk_buff *skb,if (mpa_rev_to_use ==2 ) { mpa->private_data_size =htons (ntohs (mpa->private_data_size) +sizeof (struct mpa_v2_conn_params )); -PDBG ("%s initiator ird %u ord %u\n" , __func__, ep->ird, - ep->ord); +pr_debug ("%s initiator ird %u ord %u\n" , __func__, ep->ird, + ep->ord); mpa_v2_params.ird =htons ((u16 )ep->ird); mpa_v2_params.ord =htons ((u16 )ep->ord);
@@ -997,7 +998,8 @@ static int send_mpa_reject(struct c4iw_ep *ep, const void *pdata, u8 plen)struct sk_buff *skb;struct mpa_v2_conn_params mpa_v2_params; -PDBG ("%s ep %p tid %u pd_len %d\n" , __func__, ep, ep->hwtid, ep->plen); +pr_debug ("%s ep %p tid %u pd_len %d\n" , + __func__, ep, ep->hwtid, ep->plen); mpalen =sizeof (*mpa) + plen;if (ep->mpa_attr.version ==2 && ep->mpa_attr.enhanced_rdma_conn)
@@ -1077,7 +1079,8 @@ static int send_mpa_reply(struct c4iw_ep *ep, const void *pdata, u8 plen)struct sk_buff *skb;struct mpa_v2_conn_params mpa_v2_params; -PDBG ("%s ep %p tid %u pd_len %d\n" , __func__, ep, ep->hwtid, ep->plen); +pr_debug ("%s ep %p tid %u pd_len %d\n" , + __func__, ep, ep->hwtid, ep->plen); mpalen =sizeof (*mpa) + plen;if (ep->mpa_attr.version ==2 && ep->mpa_attr.enhanced_rdma_conn)
@@ -1168,8 +1171,8 @@ static int act_establish(struct c4iw_dev *dev, struct sk_buff *skb) ep =lookup_atid (t, atid); -PDBG ("%s ep %p tid %u snd_isn %u rcv_isn %u\n" , __func__, ep, tid, -be32_to_cpu (req->snd_isn),be32_to_cpu (req->rcv_isn)); +pr_debug ("%s ep %p tid %u snd_isn %u rcv_isn %u\n" , __func__, ep, tid, +be32_to_cpu (req->snd_isn),be32_to_cpu (req->rcv_isn));mutex_lock (&ep->com.mutex);dst_confirm (ep->dst);
@@ -1212,13 +1215,13 @@ static void close_complete_upcall(struct c4iw_ep *ep, int status) {struct iw_cm_event event; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);memset (&event,0 ,sizeof (event)); event.event =IW_CM_EVENT_CLOSE ; event.status = status;if (ep->com.cm_id) { -PDBG ("close complete delivered ep %p cm_id %p tid %u\n" , - ep, ep->com.cm_id, ep->hwtid); +pr_debug ("close complete delivered ep %p cm_id %p tid %u\n" , + ep, ep->com.cm_id, ep->hwtid); ep->com.cm_id->event_handler (ep->com.cm_id, &event);deref_cm_id (&ep->com);set_bit (CLOSE_UPCALL , &ep->com.history);
@@ -1229,12 +1232,12 @@ static void peer_close_upcall(struct c4iw_ep *ep) {struct iw_cm_event event; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);memset (&event,0 ,sizeof (event)); event.event =IW_CM_EVENT_DISCONNECT ;if (ep->com.cm_id) { -PDBG ("peer close delivered ep %p cm_id %p tid %u\n" , - ep, ep->com.cm_id, ep->hwtid); +pr_debug ("peer close delivered ep %p cm_id %p tid %u\n" , + ep, ep->com.cm_id, ep->hwtid); ep->com.cm_id->event_handler (ep->com.cm_id, &event);set_bit (DISCONN_UPCALL , &ep->com.history); }
@@ -1244,13 +1247,13 @@ static void peer_abort_upcall(struct c4iw_ep *ep) {struct iw_cm_event event; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);memset (&event,0 ,sizeof (event)); event.event =IW_CM_EVENT_CLOSE ; event.status = -ECONNRESET ;if (ep->com.cm_id) { -PDBG ("abort delivered ep %p cm_id %p tid %u\n" , ep, - ep->com.cm_id, ep->hwtid); +pr_debug ("abort delivered ep %p cm_id %p tid %u\n" , ep, + ep->com.cm_id, ep->hwtid); ep->com.cm_id->event_handler (ep->com.cm_id, &event);deref_cm_id (&ep->com);set_bit (ABORT_UPCALL , &ep->com.history);
@@ -1261,7 +1264,8 @@ static void connect_reply_upcall(struct c4iw_ep *ep, int status) {struct iw_cm_event event; -PDBG ("%s ep %p tid %u status %d\n" , __func__, ep, ep->hwtid, status); +pr_debug ("%s ep %p tid %u status %d\n" , + __func__, ep, ep->hwtid, status);memset (&event,0 ,sizeof (event)); event.event =IW_CM_EVENT_CONNECT_REPLY ; event.status = status;
@@ -1290,8 +1294,8 @@ static void connect_reply_upcall(struct c4iw_ep *ep, int status) } } -PDBG ("%s ep %p tid %u status %d\n" , __func__, ep, - ep->hwtid, status); +pr_debug ("%s ep %p tid %u status %d\n" , __func__, ep, + ep->hwtid, status);set_bit (CONN_RPL_UPCALL , &ep->com.history); ep->com.cm_id->event_handler (ep->com.cm_id, &event);
@@ -1304,7 +1308,7 @@ static int connect_request_upcall(struct c4iw_ep *ep)struct iw_cm_event event;int ret; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);memset (&event,0 ,sizeof (event)); event.event =IW_CM_EVENT_CONNECT_REQUEST ; memcpy(&event.local_addr, &ep->com.local_addr,
@@ -1341,13 +1345,13 @@ static void established_upcall(struct c4iw_ep *ep) {struct iw_cm_event event; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);memset (&event,0 ,sizeof (event)); event.event =IW_CM_EVENT_ESTABLISHED ; event.ird = ep->ord; event.ord = ep->ird;if (ep->com.cm_id) { -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); ep->com.cm_id->event_handler (ep->com.cm_id, &event);set_bit (ESTAB_UPCALL , &ep->com.history); }
@@ -1359,7 +1363,8 @@ static int update_rx_credits(struct c4iw_ep *ep, u32 credits)u32 wrlen =roundup (sizeof (struct cpl_rx_data_ack ),16 );u32 credit_dack; -PDBG ("%s ep %p tid %u credits %u\n" , __func__, ep, ep->hwtid, credits); +pr_debug ("%s ep %p tid %u credits %u\n" , + __func__, ep, ep->hwtid, credits); skb =get_skb (NULL , wrlen,GFP_KERNEL );if (!skb) {pr_err ("update_rx_credits - cannot alloc skb!\n" );
@@ -1410,7 +1415,7 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb)int err;int disconnect =0 ; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);/* * If we get more than the supported amount of private data
@@ -1508,8 +1513,9 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb)MPA_V2_IRD_ORD_MASK ; resp_ord =ntohs (mpa_v2_params->ord) &MPA_V2_IRD_ORD_MASK ; -PDBG ("%s responder ird %u ord %u ep ird %u ord %u\n" , - __func__, resp_ird, resp_ord, ep->ird, ep->ord); +pr_debug ("%s responder ird %u ord %u ep ird %u ord %u\n" , + __func__, + resp_ird, resp_ord, ep->ird, ep->ord);/* * This is a double-check. Ideally, below checks are
@@ -1553,12 +1559,11 @@ static int process_mpa_reply(struct c4iw_ep *ep, struct sk_buff *skb)if (peer2peer) ep->mpa_attr.p2p_type = p2p_type; -PDBG ("%s - crc_enabled=%d, recv_marker_enabled=%d, " -"xmit_marker_enabled=%d, version=%d p2p_type=%d local-p2p_type = " -"%d\n" , __func__, ep->mpa_attr.crc_enabled, - ep->mpa_attr.recv_marker_enabled, - ep->mpa_attr.xmit_marker_enabled, ep->mpa_attr.version, - ep->mpa_attr.p2p_type, p2p_type); +pr_debug ("%s - crc_enabled=%d, recv_marker_enabled=%d, xmit_marker_enabled=%d, version=%d p2p_type=%d local-p2p_type = %d\n" , + __func__, ep->mpa_attr.crc_enabled, + ep->mpa_attr.recv_marker_enabled, + ep->mpa_attr.xmit_marker_enabled, ep->mpa_attr.version, + ep->mpa_attr.p2p_type, p2p_type);/* * If responder's RTR does not match with that of initiator, assign
@@ -1651,7 +1656,7 @@ static int process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb)struct mpa_v2_conn_params *mpa_v2_params;u16 plen; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);/* * If we get more than the supported amount of private data
@@ -1660,7 +1665,7 @@ static int process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb)if (ep->mpa_pkt_len + skb->len >sizeof (ep->mpa_pkt)) goto err_stop_timer; -PDBG ("%s enter (%s line %u)\n" , __func__, __FILE__, __LINE__); +pr_debug ("%s enter (%s line %u)\n" , __func__, __FILE__, __LINE__);/* * Copy the new data into our accumulation buffer.
@@ -1676,7 +1681,7 @@ static int process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb)if (ep->mpa_pkt_len <sizeof (*mpa))return 0 ; -PDBG ("%s enter (%s line %u)\n" , __func__, __FILE__, __LINE__); +pr_debug ("%s enter (%s line %u)\n" , __func__, __FILE__, __LINE__); mpa = (struct mpa_message *) ep->mpa_pkt;/*
@@ -1739,8 +1744,8 @@ static int process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb)MPA_V2_IRD_ORD_MASK ; ep->ord =min_t (u32, ep->ord,cur_max_read_depth (ep->com.dev)); -PDBG ("%s initiator ird %u ord %u\n" , __func__, ep->ird, - ep->ord); +pr_debug ("%s initiator ird %u ord %u\n" , + __func__, ep->ird, ep->ord);if (ntohs (mpa_v2_params->ird) &MPA_V2_PEER2PEER_MODEL )if (peer2peer) { if (ntohs(mpa_v2_params->ord) &
@@ -1757,11 +1762,11 @@ static int process_mpa_request(struct c4iw_ep *ep, struct sk_buff *skb)if (peer2peer) ep->mpa_attr.p2p_type = p2p_type; -PDBG ("%s - crc_enabled=%d, recv_marker_enabled=%d, " -"xmit_marker_enabled=%d, version=%d p2p_type=%d\n" , __func__, - ep->mpa_attr.crc_enabled, ep->mpa_attr.recv_marker_enabled, - ep->mpa_attr.xmit_marker_enabled, ep->mpa_attr.version, - ep->mpa_attr.p2p_type); +pr_debug ("%s - crc_enabled=%d, recv_marker_enabled=%d, xmit_marker_enabled=%d, version=%d p2p_type=%d\n" , + __func__, + ep->mpa_attr.crc_enabled, ep->mpa_attr.recv_marker_enabled, + ep->mpa_attr.xmit_marker_enabled, ep->mpa_attr.version, + ep->mpa_attr.p2p_type);__state_set (&ep->com,MPA_REQ_RCVD );
@@ -1797,7 +1802,7 @@ static int rx_data(struct c4iw_dev *dev, struct sk_buff *skb) ep =get_ep_from_tid (dev, tid);if (!ep)return 0 ; -PDBG ("%s ep %p tid %u dlen %u\n" , __func__, ep, ep->hwtid, dlen); +pr_debug ("%s ep %p tid %u dlen %u\n" , __func__, ep, ep->hwtid, dlen);skb_pull (skb,sizeof (*hdr));skb_trim (skb, dlen);mutex_lock (&ep->com.mutex);
@@ -1851,7 +1856,7 @@ static int abort_rpl(struct c4iw_dev *dev, struct sk_buff *skb)pr_warn ("Abort rpl to freed endpoint\n" );return 0 ; } -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);mutex_lock (&ep->com.mutex);switch (ep->com.state) {case ABORTING :
@@ -1976,7 +1981,8 @@ static void set_tcp_window(struct c4iw_ep *ep, struct port_info *pi) { ep->snd_win = snd_win; ep->rcv_win = rcv_win; -PDBG ("%s snd_win %d rcv_win %d\n" , __func__, ep->snd_win, ep->rcv_win); +pr_debug ("%s snd_win %d rcv_win %d\n" , + __func__, ep->snd_win, ep->rcv_win); }#define ACT_OPEN_RETRY_COUNT 2
@@ -2081,7 +2087,7 @@ static int c4iw_reconnect(struct c4iw_ep *ep)int iptype;__u8 *ra; -PDBG ("%s qp %p cm_id %p\n" , __func__, ep->com.qp, ep->com.cm_id); +pr_debug ("%s qp %p cm_id %p\n" , __func__, ep->com.qp, ep->com.cm_id);init_timer (&ep->timer);c4iw_init_wr_wait (&ep->com.wr_wait);
@@ -2144,9 +2150,9 @@ static int c4iw_reconnect(struct c4iw_ep *ep) goto fail4; } -PDBG ("%s txq_idx %u tx_chan %u smac_idx %u rss_qid %u l2t_idx %u\n" , - __func__, ep->txq_idx, ep->tx_chan, ep->smac_idx, ep->rss_qid, - ep->l2t->idx); +pr_debug ("%s txq_idx %u tx_chan %u smac_idx %u rss_qid %u l2t_idx %u\n" , + __func__, ep->txq_idx, ep->tx_chan, ep->smac_idx, ep->rss_qid, + ep->l2t->idx);state_set (&ep->com,CONNECTING ); ep->tos = ep->com.cm_id->tos;
@@ -2196,12 +2202,12 @@ static int act_open_rpl(struct c4iw_dev *dev, struct sk_buff *skb) la6 = (struct sockaddr_in6 *)&ep->com.local_addr; ra6 = (struct sockaddr_in6 *)&ep->com.remote_addr; -PDBG ("%s ep %p atid %u status %u errno %d\n" , __func__, ep, atid, - status,status2errno (status)); +pr_debug ("%s ep %p atid %u status %u errno %d\n" , __func__, ep, atid, + status,status2errno (status));if (cxgb_is_neg_adv (status)) { -PDBG ("%s Connection problems for atid %u status %u (%s)\n" , - __func__, atid, status,neg_adv_str (status)); +pr_debug ("%s Connection problems for atid %u status %u (%s)\n" , + __func__, atid, status,neg_adv_str (status)); ep->stats.connect_neg_adv++;mutex_lock (&dev->rdev.stats.lock); dev->rdev.stats.neg_adv++;
@@ -2296,11 +2302,11 @@ static int pass_open_rpl(struct c4iw_dev *dev, struct sk_buff *skb)struct c4iw_listen_ep *ep =get_ep_from_stid (dev, stid);if (!ep) { -PDBG ("%s stid %d lookup failure!\n" , __func__, stid); +pr_debug ("%s stid %d lookup failure!\n" , __func__, stid); goto out; } -PDBG ("%s ep %p status %d error %d\n" , __func__, ep, - rpl->status,status2errno (rpl->status)); +pr_debug ("%s ep %p status %d error %d\n" , __func__, ep, + rpl->status,status2errno (rpl->status));c4iw_wake_up (&ep->com.wr_wait,status2errno (rpl->status));c4iw_put_ep (&ep->com); out:
@@ -2313,7 +2319,7 @@ static int close_listsrv_rpl(struct c4iw_dev *dev, struct sk_buff *skb)unsigned int stid =GET_TID (rpl);struct c4iw_listen_ep *ep =get_ep_from_stid (dev, stid); -PDBG ("%s ep %p\n" , __func__, ep); +pr_debug ("%s ep %p\n" , __func__, ep);c4iw_wake_up (&ep->com.wr_wait,status2errno (rpl->status));c4iw_put_ep (&ep->com);return 0 ;
@@ -2331,7 +2337,7 @@ static int accept_cr(struct c4iw_ep *ep, struct sk_buff *skb,int win;enum chip_type adapter_type = ep->com.dev->rdev.lldi.adapter_type; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);BUG_ON (skb_cloned (skb));skb_get (skb);
@@ -2402,7 +2408,7 @@ static int accept_cr(struct c4iw_ep *ep, struct sk_buff *skb,if (peer2peer) isn +=4 ; rpl5->iss =cpu_to_be32 (isn); -PDBG ("%s iss %u\n" , __func__,be32_to_cpu (rpl5->iss)); +pr_debug ("%s iss %u\n" , __func__,be32_to_cpu (rpl5->iss)); } rpl->opt0 =cpu_to_be64 (opt0);
@@ -2415,7 +2421,7 @@ static int accept_cr(struct c4iw_ep *ep, struct sk_buff *skb,static void reject_cr (struct c4iw_dev *dev,u32 hwtid,struct sk_buff *skb) { -PDBG ("%s c4iw_dev %p tid %u\n" , __func__, dev, hwtid); +pr_debug ("%s c4iw_dev %p tid %u\n" , __func__, dev, hwtid);BUG_ON (skb_cloned (skb));skb_trim (skb,sizeof (struct cpl_tid_release ));release_tid (&dev->rdev, hwtid, skb);
@@ -2441,12 +2447,13 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb) parent_ep = (struct c4iw_ep *)get_ep_from_stid (dev, stid);if (!parent_ep) { -PDBG ("%s connect request on invalid stid %d\n" , __func__, stid); +pr_debug ("%s connect request on invalid stid %d\n" , + __func__, stid); goto reject; }if (state_read (&parent_ep->com) !=LISTEN ) { -PDBG ("%s - listening ep not in LISTEN\n" , __func__); +pr_debug ("%s - listening ep not in LISTEN\n" , __func__); goto reject; }
@@ -2455,18 +2462,18 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb)/* Find output route */ if (iptype ==4 ) { -PDBG ("%s parent ep %p hwtid %u laddr %pI4 raddr %pI4 lport %d rport %d peer_mss %d\n" - , __func__, parent_ep, hwtid, - local_ip, peer_ip,ntohs (local_port), -ntohs (peer_port), peer_mss); +pr_debug ("%s parent ep %p hwtid %u laddr %pI4 raddr %pI4 lport %d rport %d peer_mss %d\n" + , __func__, parent_ep, hwtid, + local_ip, peer_ip,ntohs (local_port), +ntohs (peer_port), peer_mss); dst =cxgb_find_route (&dev->rdev.lldi, get_real_dev, *(__be32 *)local_ip, *(__be32 *)peer_ip, local_port, peer_port, tos); }else { -PDBG ("%s parent ep %p hwtid %u laddr %pI6 raddr %pI6 lport %d rport %d peer_mss %d\n" - , __func__, parent_ep, hwtid, - local_ip, peer_ip,ntohs (local_port), -ntohs (peer_port), peer_mss); +pr_debug ("%s parent ep %p hwtid %u laddr %pI6 raddr %pI6 lport %d rport %d peer_mss %d\n" + , __func__, parent_ep, hwtid, + local_ip, peer_ip,ntohs (local_port), +ntohs (peer_port), peer_mss); dst = cxgb_find_route6(&dev->rdev.lldi, get_real_dev, local_ip, peer_ip, local_port, peer_port, PASS_OPEN_TOS_G(ntohl(req->tos_stid)),
@@ -2549,8 +2556,8 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb) child_ep->dst = dst; child_ep->hwtid = hwtid; -PDBG ("%s tx_chan %u smac_idx %u rss_qid %u\n" , __func__, - child_ep->tx_chan, child_ep->smac_idx, child_ep->rss_qid); +pr_debug ("%s tx_chan %u smac_idx %u rss_qid %u\n" , __func__, + child_ep->tx_chan, child_ep->smac_idx, child_ep->rss_qid);init_timer (&child_ep->timer);cxgb4_insert_tid (t, child_ep, hwtid);
@@ -2585,12 +2592,12 @@ static int pass_establish(struct c4iw_dev *dev, struct sk_buff *skb)int ret; ep =get_ep_from_tid (dev, tid); -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); ep->snd_seq =be32_to_cpu (req->snd_isn); ep->rcv_seq =be32_to_cpu (req->rcv_isn); -PDBG ("%s ep %p hwtid %u tcp_opt 0x%02x\n" , __func__, ep, tid, -ntohs (req->tcp_opt)); +pr_debug ("%s ep %p hwtid %u tcp_opt 0x%02x\n" , __func__, ep, tid, +ntohs (req->tcp_opt));set_emss (ep,ntohs (req->tcp_opt));
@@ -2622,7 +2629,7 @@ static int peer_close(struct c4iw_dev *dev, struct sk_buff *skb)if (!ep)return 0 ; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);dst_confirm (ep->dst);set_bit (PEER_CLOSE , &ep->com.history);
@@ -2644,12 +2651,12 @@ static int peer_close(struct c4iw_dev *dev, struct sk_buff *skb)* in rdma connection migration (see c4iw_accept_cr()). */ __state_set (&ep->com,CLOSING ); -PDBG ("waking up ep %p tid %u\n" , ep, ep->hwtid); +pr_debug ("waking up ep %p tid %u\n" , ep, ep->hwtid);c4iw_wake_up (&ep->com.wr_wait, -ECONNRESET );break ;case MPA_REP_SENT :__state_set (&ep->com,CLOSING ); -PDBG ("waking up ep %p tid %u\n" , ep, ep->hwtid); +pr_debug ("waking up ep %p tid %u\n" , ep, ep->hwtid);c4iw_wake_up (&ep->com.wr_wait, -ECONNRESET );break ;case FPDU_MODE :
@@ -2713,17 +2720,17 @@ static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb)return 0 ;if (cxgb_is_neg_adv (req->status)) { -PDBG ("%s Negative advice on abort- tid %u status %d (%s)\n" , - __func__, ep->hwtid, req->status, -neg_adv_str (req->status)); +pr_debug ("%s Negative advice on abort- tid %u status %d (%s)\n" , + __func__, ep->hwtid, req->status, +neg_adv_str (req->status)); ep->stats.abort_neg_adv++;mutex_lock (&dev->rdev.stats.lock); dev->rdev.stats.neg_adv++;mutex_unlock (&dev->rdev.stats.lock); goto deref_ep; } -PDBG ("%s ep %p tid %u state %u\n" , __func__, ep, ep->hwtid, - ep->com.state); +pr_debug ("%s ep %p tid %u state %u\n" , __func__, ep, ep->hwtid, + ep->com.state);set_bit (PEER_ABORT , &ep->com.history);/*
@@ -2755,8 +2762,8 @@ static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb)* do some housekeeping so as to re-initiate the * connection */ -PDBG ("%s: mpa_rev=%d. Retrying with mpav1\n" , __func__, - mpa_rev); +pr_debug ("%s: mpa_rev=%d. Retrying with mpav1\n" , + __func__, mpa_rev); ep->retry_with_mpa_v1 =1 ; }break ;
@@ -2782,7 +2789,7 @@ static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb)case ABORTING :break ;case DEAD : -PDBG ("%s PEER_ABORT IN DEAD STATE!!!!\n" , __func__); +pr_debug ("%s PEER_ABORT IN DEAD STATE!!!!\n" , __func__);mutex_unlock (&ep->com.mutex); goto deref_ep;default :
@@ -2846,7 +2853,7 @@ static int close_con_rpl(struct c4iw_dev *dev, struct sk_buff *skb)if (!ep)return 0 ; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);BUG_ON (!ep);/* The cm_id may be null if we failed to connect */
@@ -2922,18 +2929,19 @@ static int fw4_ack(struct c4iw_dev *dev, struct sk_buff *skb) ep =get_ep_from_tid (dev, tid);if (!ep)return 0 ; -PDBG ("%s ep %p tid %u credits %u\n" , __func__, ep, ep->hwtid, credits); +pr_debug ("%s ep %p tid %u credits %u\n" , + __func__, ep, ep->hwtid, credits);if (credits ==0 ) { -PDBG ("%s 0 credit ack ep %p tid %u state %u\n" , - __func__, ep, ep->hwtid,state_read (&ep->com)); +pr_debug ("%s 0 credit ack ep %p tid %u state %u\n" , + __func__, ep, ep->hwtid,state_read (&ep->com)); goto out; }dst_confirm (ep->dst);if (ep->mpa_skb) { -PDBG ("%s last streaming msg ack ep %p tid %u state %u " -"initiator %u freeing skb\n" , __func__, ep, ep->hwtid, -state_read (&ep->com), ep->mpa_attr.initiator ?1 :0 ); +pr_debug ("%s last streaming msg ack ep %p tid %u state %u initiator %u freeing skb\n" , + __func__, ep, ep->hwtid, +state_read (&ep->com), ep->mpa_attr.initiator ?1 :0 );mutex_lock (&ep->com.mutex);kfree_skb (ep->mpa_skb); ep->mpa_skb =NULL ;
@@ -2951,7 +2959,7 @@ int c4iw_reject_cr(struct iw_cm_id *cm_id, const void *pdata, u8 pdata_len)int abort;struct c4iw_ep *ep =to_ep (cm_id); -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);mutex_lock (&ep->com.mutex);if (ep->com.state !=MPA_REQ_RCVD ) {
@@ -2982,7 +2990,7 @@ int c4iw_accept_cr(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)struct c4iw_qp *qp =get_qhp (h, conn_param->qpn);int abort =0 ; -PDBG ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid); +pr_debug ("%s ep %p tid %u\n" , __func__, ep, ep->hwtid);mutex_lock (&ep->com.mutex);if (ep->com.state !=MPA_REQ_RCVD ) {
@@ -3035,7 +3043,7 @@ int c4iw_accept_cr(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) ep->ird =1 ; } -PDBG ("%s %d ird %d ord %d\n" , __func__, __LINE__, ep->ird, ep->ord); +pr_debug ("%s %d ird %d ord %d\n" , __func__, __LINE__, ep->ird, ep->ord); ep->com.cm_id = cm_id;ref_cm_id (&ep->com);
@@ -3191,13 +3199,13 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) ep->com.dev = dev; ep->com.qp =get_qhp (dev, conn_param->qpn);if (!ep->com.qp) { -PDBG ("%s qpn 0x%x not found!\n" , __func__, conn_param->qpn); +pr_debug ("%s qpn 0x%x not found!\n" , __func__, conn_param->qpn); err = -EINVAL ; goto fail2; }ref_qp (ep); -PDBG ("%s qpn 0x%x qp %p cm_id %p\n" , __func__, conn_param->qpn, - ep->com.qp, cm_id); +pr_debug ("%s qpn 0x%x qp %p cm_id %p\n" , __func__, conn_param->qpn, + ep->com.qp, cm_id);/* * Allocate an active TID to initiate a TCP connection.
@@ -3234,9 +3242,9 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) }/* find a route */ -PDBG ("%s saddr %pI4 sport 0x%x raddr %pI4 rport 0x%x\n" , - __func__, &laddr->sin_addr,ntohs (laddr->sin_port), - ra,ntohs (raddr->sin_port)); +pr_debug ("%s saddr %pI4 sport 0x%x raddr %pI4 rport 0x%x\n" , + __func__, &laddr->sin_addr,ntohs (laddr->sin_port), + ra,ntohs (raddr->sin_port)); ep->dst = cxgb_find_route(&dev->rdev.lldi, get_real_dev, laddr->sin_addr.s_addr, raddr->sin_addr.s_addr,
@@ -3256,10 +3264,10 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) }/* find a route */ -PDBG ("%s saddr %pI6 sport 0x%x raddr %pI6 rport 0x%x\n" , - __func__, laddr6->sin6_addr.s6_addr, -ntohs (laddr6->sin6_port), - raddr6->sin6_addr.s6_addr,ntohs (raddr6->sin6_port)); +pr_debug ("%s saddr %pI6 sport 0x%x raddr %pI6 rport 0x%x\n" , + __func__, laddr6->sin6_addr.s6_addr, +ntohs (laddr6->sin6_port), + raddr6->sin6_addr.s6_addr,ntohs (raddr6->sin6_port)); ep->dst = cxgb_find_route6(&dev->rdev.lldi, get_real_dev, laddr6->sin6_addr.s6_addr, raddr6->sin6_addr.s6_addr,
@@ -3280,9 +3288,9 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) goto fail4; } -PDBG ("%s txq_idx %u tx_chan %u smac_idx %u rss_qid %u l2t_idx %u\n" , - __func__, ep->txq_idx, ep->tx_chan, ep->smac_idx, ep->rss_qid, - ep->l2t->idx); +pr_debug ("%s txq_idx %u tx_chan %u smac_idx %u rss_qid %u l2t_idx %u\n" , + __func__, ep->txq_idx, ep->tx_chan, ep->smac_idx, ep->rss_qid, + ep->l2t->idx);state_set (&ep->com,CONNECTING ); ep->tos = cm_id->tos;
@@ -3395,7 +3403,7 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog) goto fail1; }skb_queue_head_init (&ep->com.ep_skb_list); -PDBG ("%s ep %p\n" , __func__, ep); +pr_debug ("%s ep %p\n" , __func__, ep); ep->com.cm_id = cm_id;ref_cm_id (&ep->com); ep->com.dev = dev;
@@ -3449,7 +3457,7 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)int err;struct c4iw_listen_ep *ep =to_listen_ep (cm_id); -PDBG ("%s ep %p\n" , __func__, ep); +pr_debug ("%s ep %p\n" , __func__, ep);might_sleep ();state_set (&ep->com,DEAD );
@@ -3490,8 +3498,8 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)mutex_lock (&ep->com.mutex); -PDBG ("%s ep %p state %s, abrupt %d\n" , __func__, ep, - states[ep->com.state], abrupt); +pr_debug ("%s ep %p state %s, abrupt %d\n" , __func__, ep, + states[ep->com.state], abrupt);/* * Ref the ep here in case we have fatal errors causing the
@@ -3544,8 +3552,8 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)case MORIBUND :case ABORTING :case DEAD : -PDBG ("%s ignoring disconnect ep %p state %u\n" , - __func__, ep, ep->com.state); +pr_debug ("%s ignoring disconnect ep %p state %u\n" , + __func__, ep, ep->com.state);break ;default :BUG ();
@@ -3649,7 +3657,7 @@ static void passive_ofld_conn_reply(struct c4iw_dev *dev, struct sk_buff *skb, rpl_skb = (struct sk_buff *)(unsigned long )req->cookie;BUG_ON (!rpl_skb);if (req->retval) { -PDBG ("%s passive open failure %d\n" , __func__, req->retval); +pr_debug ("%s passive open failure %d\n" , __func__, req->retval);mutex_lock (&dev->rdev.stats.lock); dev->rdev.stats.pas_ofld_conn_fails++;mutex_unlock (&dev->rdev.stats.lock);
@@ -3865,7 +3873,8 @@ static int rx_pkt(struct c4iw_dev *dev, struct sk_buff *skb) lep = (struct c4iw_ep *)get_ep_from_stid (dev, stid);if (!lep) { -PDBG ("%s connect request on invalid stid %d\n" , __func__, stid); +pr_debug ("%s connect request on invalid stid %d\n" , + __func__, stid); goto reject; }
@@ -3902,9 +3911,9 @@ static int rx_pkt(struct c4iw_dev *dev, struct sk_buff *skb)skb_set_transport_header (skb, (void *)tcph - (void *)rss);skb_get (skb); -PDBG ("%s lip 0x%x lport %u pip 0x%x pport %u tos %d\n" , __func__, -ntohl (iph->daddr),ntohs (tcph->dest),ntohl (iph->saddr), -ntohs (tcph->source), iph->tos); +pr_debug ("%s lip 0x%x lport %u pip 0x%x pport %u tos %d\n" , __func__, +ntohl (iph->daddr),ntohs (tcph->dest),ntohl (iph->saddr), +ntohs (tcph->source), iph->tos); dst = cxgb_find_route(&dev->rdev.lldi, get_real_dev, iph->daddr, iph->saddr, tcph->dest,
@@ -4001,8 +4010,8 @@ static void process_timeout(struct c4iw_ep *ep)int abort =1 ;mutex_lock (&ep->com.mutex); -PDBG ("%s ep %p tid %u state %d\n" , __func__, ep, ep->hwtid, - ep->com.state); +pr_debug ("%s ep %p tid %u state %d\n" , __func__, ep, ep->hwtid, + ep->com.state);set_bit (TIMEDOUT , &ep->com.history);switch (ep->com.state) {case MPA_REQ_SENT :
@@ -4145,13 +4154,13 @@ static int fw6_msg(struct c4iw_dev *dev, struct sk_buff *skb)struct c4iw_wr_wait *wr_waitp;int ret; -PDBG ("%s type %u\n" , __func__, rpl->type); +pr_debug ("%s type %u\n" , __func__, rpl->type);switch (rpl->type) {case FW6_TYPE_WR_RPL : ret = (int )((be64_to_cpu (rpl->data[0 ]) >>8 ) &0xff ); wr_waitp = (struct c4iw_wr_wait *)(__force unsigned long ) rpl->data[1 ]; -PDBG ("%s wr_waitp %p ret %u\n" , __func__, wr_waitp, ret); +pr_debug ("%s wr_waitp %p ret %u\n" , __func__, wr_waitp, ret);if (wr_waitp)c4iw_wake_up (wr_waitp, ret ? -ret :0 );kfree_skb (skb);
@@ -4183,13 +4192,13 @@ static int peer_abort_intr(struct c4iw_dev *dev, struct sk_buff *skb)return 0 ; }if (cxgb_is_neg_adv (req->status)) { -PDBG ("%s Negative advice on abort- tid %u status %d (%s)\n" , - __func__, ep->hwtid, req->status, -neg_adv_str (req->status)); +pr_debug ("%s Negative advice on abort- tid %u status %d (%s)\n" , + __func__, ep->hwtid, req->status, +neg_adv_str (req->status)); goto out; } -PDBG ("%s ep %p tid %u state %u\n" , __func__, ep, ep->hwtid, - ep->com.state); +pr_debug ("%s ep %p tid %u state %u\n" , __func__, ep, ep->hwtid, + ep->com.state);c4iw_wake_up (&ep->com.wr_wait, -ECONNRESET ); out:
drivers/infiniband/hw/cxgb4/cq.c +36 -35
174 lines not on this page · raw message
drivers/infiniband/hw/cxgb4/device.c +27 -31
100 lines not on this page · raw message
drivers/infiniband/hw/cxgb4/ev.c +14 -15
@@ -47,17 +47,16 @@ static void print_tpte(struct c4iw_dev *dev, u32 stag) "%s cxgb4_read_tpte err %d\n", __func__, ret);return ; } -PDBG ("stag idx 0x%x valid %d key 0x%x state %d pdid %d " -"perm 0x%x ps %d len 0x%llx va 0x%llx\n" , - stag &0xffffff00 , -FW_RI_TPTE_VALID_G (ntohl (tpte.valid_to_pdid)), -FW_RI_TPTE_STAGKEY_G (ntohl (tpte.valid_to_pdid)), -FW_RI_TPTE_STAGSTATE_G (ntohl (tpte.valid_to_pdid)), -FW_RI_TPTE_PDID_G (ntohl (tpte.valid_to_pdid)), -FW_RI_TPTE_PERM_G (ntohl (tpte.locread_to_qpid)), -FW_RI_TPTE_PS_G (ntohl (tpte.locread_to_qpid)), - ((u64 )ntohl (tpte.len_hi) <<32 ) |ntohl (tpte.len_lo), - ((u64 )ntohl (tpte.va_hi) <<32 ) |ntohl (tpte.va_lo_fbo)); +pr_debug ("stag idx 0x%x valid %d key 0x%x state %d pdid %d perm 0x%x ps %d len 0x%llx va 0x%llx\n" , + stag &0xffffff00 , +FW_RI_TPTE_VALID_G (ntohl (tpte.valid_to_pdid)), +FW_RI_TPTE_STAGKEY_G (ntohl (tpte.valid_to_pdid)), +FW_RI_TPTE_STAGSTATE_G (ntohl (tpte.valid_to_pdid)), +FW_RI_TPTE_PDID_G (ntohl (tpte.valid_to_pdid)), +FW_RI_TPTE_PERM_G (ntohl (tpte.locread_to_qpid)), +FW_RI_TPTE_PS_G (ntohl (tpte.locread_to_qpid)), + ((u64 )ntohl (tpte.len_hi) <<32 ) |ntohl (tpte.len_lo), + ((u64 )ntohl (tpte.va_hi) <<32 ) |ntohl (tpte.va_lo_fbo)); }static void dump_err_cqe (struct c4iw_dev *dev,struct t4_cqe *err_cqe)
@@ -71,9 +70,9 @@ static void dump_err_cqe(struct c4iw_dev *dev, struct t4_cqe *err_cqe)CQE_STATUS (err_cqe),CQE_TYPE (err_cqe),ntohl (err_cqe->len), CQE_WRID_HI(err_cqe), CQE_WRID_LOW(err_cqe)); -PDBG ("%016llx %016llx %016llx %016llx\n" , -be64_to_cpu (p[0 ]),be64_to_cpu (p[1 ]),be64_to_cpu (p[2 ]), -be64_to_cpu (p[3 ])); +pr_debug ("%016llx %016llx %016llx %016llx\n" , +be64_to_cpu (p[0 ]),be64_to_cpu (p[1 ]),be64_to_cpu (p[2 ]), +be64_to_cpu (p[3 ]));/* * Ingress WRITE and READ_RESP errors provide
@@ -235,7 +234,7 @@ int c4iw_ev_handler(struct c4iw_dev *dev, u32 qid)if (atomic_dec_and_test (&chp->refcnt))wake_up (&chp->wait); }else { -PDBG ("%s unknown cqid 0x%x\n" , __func__, qid); +pr_debug ("%s unknown cqid 0x%x\n" , __func__, qid);spin_unlock_irqrestore (&dev->lock, flag); }return 0 ;
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +20 -24
81 lines not on this page · raw message
drivers/infiniband/hw/cxgb4/mem.c +14 -14
@@ -125,7 +125,7 @@ static int _c4iw_write_mem_inline(struct c4iw_rdev *rdev, u32 addr, u32 len, cmd |=cpu_to_be32 (T5_ULP_MEMIO_IMM_F ); addr &=0x7FFFFFF ; -PDBG ("%s addr 0x%x len %u\n" , __func__, addr, len); +pr_debug ("%s addr 0x%x len %u\n" , __func__, addr, len); num_wqe =DIV_ROUND_UP (len,C4IW_MAX_INLINE_SIZE );c4iw_init_wr_wait (&wr_wait);for (i =0 ; i < num_wqe; i++) {
@@ -287,8 +287,8 @@ static int write_tpt_entry(struct c4iw_rdev *rdev, u32 reset_tpt_entry,mutex_unlock (&rdev->stats.lock); *stag = (stag_idx <<8 ) | (atomic_inc_return (&key) &0xff ); } -PDBG ("%s stag_state 0x%0x type 0x%0x pdid 0x%0x, stag_idx 0x%x\n" , - __func__, stag_state, type, pdid, stag_idx); +pr_debug ("%s stag_state 0x%0x type 0x%0x pdid 0x%0x, stag_idx 0x%x\n" , + __func__, stag_state, type, pdid, stag_idx);/* write TPT entry */ if (reset_tpt_entry)
@@ -329,9 +329,9 @@ static int write_pbl(struct c4iw_rdev *rdev, __be64 *pbl, {int err; -PDBG ("%s *pdb_addr 0x%x, pbl_base 0x%x, pbl_size %d\n" , - __func__, pbl_addr, rdev->lldi.vr->pbl.start, - pbl_size); +pr_debug ("%s *pdb_addr 0x%x, pbl_base 0x%x, pbl_size %d\n" , + __func__, pbl_addr, rdev->lldi.vr->pbl.start, + pbl_size); err =write_adapter_mem (rdev, pbl_addr >>5 , pbl_size <<3 , pbl,NULL );return err;
@@ -374,7 +374,7 @@ static int finish_mem_reg(struct c4iw_mr *mhp, u32 stag) mhp->attr.stag = stag; mmid = stag >>8 ; mhp->ibmr.rkey = mhp->ibmr.lkey = stag; -PDBG ("%s mmid 0x%x mhp %p\n" , __func__, mmid, mhp); +pr_debug ("%s mmid 0x%x mhp %p\n" , __func__, mmid, mhp);return insert_handle (mhp->rhp, &mhp->rhp->mmidr, mhp, mmid); }
@@ -424,7 +424,7 @@ struct ib_mr *c4iw_get_dma_mr(struct ib_pd *pd, int acc)int ret;u32 stag =T4_STAG_UNSET ; -PDBG ("%s ib_pd %p\n" , __func__, pd); +pr_debug ("%s ib_pd %p\n" , __func__, pd); php =to_c4iw_pd (pd); rhp = php->rhp;
@@ -481,7 +481,7 @@ struct ib_mr *c4iw_reg_user_mr(struct ib_pd *pd, u64 start, u64 length,struct c4iw_pd *php;struct c4iw_mr *mhp; -PDBG ("%s ib_pd %p\n" , __func__, pd); +pr_debug ("%s ib_pd %p\n" , __func__, pd);if (length == ~0ULL )return ERR_PTR (-EINVAL );
@@ -618,7 +618,7 @@ struct ib_mw *c4iw_alloc_mw(struct ib_pd *pd, enum ib_mw_type type, ret = -ENOMEM ; goto dealloc_win; } -PDBG ("%s mmid 0x%x mhp %p stag 0x%x\n" , __func__, mmid, mhp, stag); +pr_debug ("%s mmid 0x%x mhp %p stag 0x%x\n" , __func__, mmid, mhp, stag);return &(mhp->ibmw); dealloc_win:
@@ -643,7 +643,7 @@ int c4iw_dealloc_mw(struct ib_mw *mw)deallocate_window (&rhp->rdev, mhp->attr.stag, mhp->dereg_skb);kfree_skb (mhp->dereg_skb);kfree (mhp); -PDBG ("%s ib_mw %p mmid 0x%x ptr %p\n" , __func__, mw, mmid, mhp); +pr_debug ("%s ib_mw %p mmid 0x%x ptr %p\n" , __func__, mw, mmid, mhp);return 0 ; }
@@ -701,7 +701,7 @@ struct ib_mr *c4iw_alloc_mr(struct ib_pd *pd, goto err3; } -PDBG ("%s mmid 0x%x mhp %p stag 0x%x\n" , __func__, mmid, mhp, stag); +pr_debug ("%s mmid 0x%x mhp %p stag 0x%x\n" , __func__, mmid, mhp, stag);return &(mhp->ibmr); err3: dereg_mem(&rhp->rdev, stag, mhp->attr.pbl_size,
@@ -746,7 +746,7 @@ int c4iw_dereg_mr(struct ib_mr *ib_mr)struct c4iw_mr *mhp;u32 mmid; -PDBG ("%s ib_mr %p\n" , __func__, ib_mr); +pr_debug ("%s ib_mr %p\n" , __func__, ib_mr); mhp =to_c4iw_mr (ib_mr); rhp = mhp->rhp;
@@ -764,7 +764,7 @@ int c4iw_dereg_mr(struct ib_mr *ib_mr)kfree ((void *) (unsigned long ) mhp->kva);if (mhp->umem)ib_umem_release (mhp->umem); -PDBG ("%s mmid 0x%x ptr %p\n" , __func__, mmid, mhp); +pr_debug ("%s mmid 0x%x ptr %p\n" , __func__, mmid, mhp);kfree (mhp);return 0 ; }
drivers/infiniband/hw/cxgb4/provider.c +19 -19
@@ -102,7 +102,7 @@ void _c4iw_free_ucontext(struct kref *kref) ucontext = container_of(kref, struct c4iw_ucontext, kref); rhp =to_c4iw_dev (ucontext->ibucontext.device); -PDBG ("%s ucontext %p\n" , __func__, ucontext); +pr_debug ("%s ucontext %p\n" , __func__, ucontext);list_for_each_entry_safe (mm, tmp, &ucontext->mmaps, entry)kfree (mm);c4iw_release_dev_ucontext (&rhp->rdev, &ucontext->uctx);
@@ -113,7 +113,7 @@ static int c4iw_dealloc_ucontext(struct ib_ucontext *context) {struct c4iw_ucontext *ucontext =to_c4iw_ucontext (context); -PDBG ("%s context %p\n" , __func__, context); +pr_debug ("%s context %p\n" , __func__, context);c4iw_put_ucontext (ucontext);return 0 ; }
@@ -127,7 +127,7 @@ static struct ib_ucontext *c4iw_alloc_ucontext(struct ib_device *ibdev,int ret =0 ;struct c4iw_mm_entry *mm =NULL ; -PDBG ("%s ibdev %p\n" , __func__, ibdev); +pr_debug ("%s ibdev %p\n" , __func__, ibdev); context =kzalloc (sizeof (*context),GFP_KERNEL );if (!context) { ret = -ENOMEM ;
@@ -185,8 +185,8 @@ static int c4iw_mmap(struct ib_ucontext *context, struct vm_area_struct *vma)struct c4iw_ucontext *ucontext;u64 addr; -PDBG ("%s pgoff 0x%lx key 0x%x len %d\n" , __func__, vma->vm_pgoff, - key, len); +pr_debug ("%s pgoff 0x%lx key 0x%x len %d\n" , __func__, vma->vm_pgoff, + key, len);if (vma->vm_start & (PAGE_SIZE -1 ))return -EINVAL ;
@@ -251,7 +251,7 @@ static int c4iw_deallocate_pd(struct ib_pd *pd) php =to_c4iw_pd (pd); rhp = php->rhp; -PDBG ("%s ibpd %p pdid 0x%x\n" , __func__, pd, php->pdid); +pr_debug ("%s ibpd %p pdid 0x%x\n" , __func__, pd, php->pdid);c4iw_put_resource (&rhp->rdev.resource.pdid_table, php->pdid);mutex_lock (&rhp->rdev.stats.lock); rhp->rdev.stats.pd.cur--;
@@ -268,7 +268,7 @@ static struct ib_pd *c4iw_allocate_pd(struct ib_device *ibdev,u32 pdid;struct c4iw_dev *rhp; -PDBG ("%s ibdev %p\n" , __func__, ibdev); +pr_debug ("%s ibdev %p\n" , __func__, ibdev); rhp = (struct c4iw_dev *) ibdev; pdid =c4iw_get_resource (&rhp->rdev.resource.pdid_table);if (!pdid)
@@ -291,14 +291,14 @@ static struct ib_pd *c4iw_allocate_pd(struct ib_device *ibdev,if (rhp->rdev.stats.pd.cur > rhp->rdev.stats.pd.max) rhp->rdev.stats.pd.max = rhp->rdev.stats.pd.cur;mutex_unlock (&rhp->rdev.stats.lock); -PDBG ("%s pdid 0x%0x ptr 0x%p\n" , __func__, pdid, php); +pr_debug ("%s pdid 0x%0x ptr 0x%p\n" , __func__, pdid, php);return &php->ibpd; }static int c4iw_query_pkey (struct ib_device *ibdev,u8 port,u16 index,u16 *pkey) { -PDBG ("%s ibdev %p\n" , __func__, ibdev); +pr_debug ("%s ibdev %p\n" , __func__, ibdev); *pkey =0 ;return 0 ; }
@@ -308,8 +308,8 @@ static int c4iw_query_gid(struct ib_device *ibdev, u8 port, int index, {struct c4iw_dev *dev; -PDBG ("%s ibdev %p, port %d, index %d, gid %p\n" , - __func__, ibdev, port, index, gid); +pr_debug ("%s ibdev %p, port %d, index %d, gid %p\n" , + __func__, ibdev, port, index, gid); dev =to_c4iw_dev (ibdev);BUG_ON (port ==0 );memset (&(gid->raw[0 ]),0 ,sizeof (gid->raw));
@@ -323,7 +323,7 @@ static int c4iw_query_device(struct ib_device *ibdev, struct ib_device_attr *prostruct c4iw_dev *dev; -PDBG ("%s ibdev %p\n" , __func__, ibdev); +pr_debug ("%s ibdev %p\n" , __func__, ibdev);if (uhw->inlen || uhw->outlen)return -EINVAL ;
@@ -364,7 +364,7 @@ static int c4iw_query_port(struct ib_device *ibdev, u8 port,struct net_device *netdev;struct in_device *inetdev; -PDBG ("%s ibdev %p\n" , __func__, ibdev); +pr_debug ("%s ibdev %p\n" , __func__, ibdev); dev =to_c4iw_dev (ibdev); netdev = dev->rdev.lldi.ports[port-1 ];
@@ -406,7 +406,7 @@ static ssize_t show_rev(struct device *dev, struct device_attribute *attr, { struct c4iw_dev *c4iw_dev = container_of(dev, struct c4iw_dev, ibdev.dev); -PDBG ("%s dev 0x%p\n" , __func__, dev); +pr_debug ("%s dev 0x%p\n" , __func__, dev);return sprintf (buf,"%d\n" ,CHELSIO_CHIP_RELEASE (c4iw_dev->rdev.lldi.adapter_type)); }
@@ -419,7 +419,7 @@ static ssize_t show_hca(struct device *dev, struct device_attribute *attr,struct ethtool_drvinfo info;struct net_device *lldev = c4iw_dev->rdev.lldi.ports[0 ]; -PDBG ("%s dev 0x%p\n" , __func__, dev); +pr_debug ("%s dev 0x%p\n" , __func__, dev); lldev->ethtool_ops->get_drvinfo (lldev, &info);return sprintf (buf,"%s\n" , info.driver); }
@@ -429,7 +429,7 @@ static ssize_t show_board(struct device *dev, struct device_attribute *attr, { struct c4iw_dev *c4iw_dev = container_of(dev, struct c4iw_dev, ibdev.dev); -PDBG ("%s dev 0x%p\n" , __func__, dev); +pr_debug ("%s dev 0x%p\n" , __func__, dev);return sprintf (buf,"%x.%x\n" , c4iw_dev->rdev.lldi.pdev->vendor, c4iw_dev->rdev.lldi.pdev->device); }
@@ -522,7 +522,7 @@ static void get_dev_fw_str(struct ib_device *dev, char *str, { struct c4iw_dev *c4iw_dev = container_of(dev, struct c4iw_dev, ibdev); -PDBG ("%s dev 0x%p\n" , __func__, dev); +pr_debug ("%s dev 0x%p\n" , __func__, dev); snprintf(str, str_len, "%u.%u.%u.%u", FW_HDR_FW_VER_MAJOR_G(c4iw_dev->rdev.lldi.fw_vers),
@@ -536,7 +536,7 @@ int c4iw_register_device(struct c4iw_dev *dev)int ret;int i; -PDBG ("%s c4iw_dev %p\n" , __func__, dev); +pr_debug ("%s c4iw_dev %p\n" , __func__, dev);BUG_ON (!dev->rdev.lldi.ports[0 ]);strlcpy (dev->ibdev.name,"cxgb4_%d" ,IB_DEVICE_NAME_MAX );memset (&dev->ibdev.node_guid,0 ,sizeof (dev->ibdev.node_guid));
@@ -646,7 +646,7 @@ void c4iw_unregister_device(struct c4iw_dev *dev) {int i; -PDBG ("%s c4iw_dev %p\n" , __func__, dev); +pr_debug ("%s c4iw_dev %p\n" , __func__, dev);for (i =0 ; i <ARRAY_SIZE (c4iw_class_attributes); ++i)device_remove_file (&dev->ibdev.dev, c4iw_class_attributes[i]);
drivers/infiniband/hw/cxgb4/qp.c +47 -44
232 lines not on this page · raw message
drivers/infiniband/hw/cxgb4/resource.c +23 -23
148 lines not on this page · raw message
drivers/infiniband/hw/cxgb4/t4.h +12 -10
@@ -466,14 +466,14 @@ static inline void t4_ring_sq_db(struct t4_wq *wq, u16 inc, union t4_wr *wqe)wmb ();if (wq->sq.bar2_va) {if (inc ==1 && wq->sq.bar2_qid ==0 && wqe) { -PDBG ("%s: WC wq->sq.pidx = %d\n" , - __func__, wq->sq.pidx); +pr_debug ("%s: WC wq->sq.pidx = %d\n" , + __func__, wq->sq.pidx);pio_copy ((u64 __iomem *) (wq->sq.bar2_va +SGE_UDB_WCDOORBELL ), (u64 *)wqe); }else { -PDBG ("%s: DB wq->sq.pidx = %d\n" , - __func__, wq->sq.pidx); +pr_debug ("%s: DB wq->sq.pidx = %d\n" , + __func__, wq->sq.pidx);writel (PIDX_T5_V (inc) |QID_V (wq->sq.bar2_qid), wq->sq.bar2_va +SGE_UDB_KDOORBELL ); }
@@ -493,14 +493,14 @@ static inline void t4_ring_rq_db(struct t4_wq *wq, u16 inc,wmb ();if (wq->rq.bar2_va) {if (inc ==1 && wq->rq.bar2_qid ==0 && wqe) { -PDBG ("%s: WC wq->rq.pidx = %d\n" , - __func__, wq->rq.pidx); +pr_debug ("%s: WC wq->rq.pidx = %d\n" , + __func__, wq->rq.pidx);pio_copy ((u64 __iomem *) (wq->rq.bar2_va +SGE_UDB_WCDOORBELL ), (void *)wqe); }else { -PDBG ("%s: DB wq->rq.pidx = %d\n" , - __func__, wq->rq.pidx); +pr_debug ("%s: DB wq->rq.pidx = %d\n" , + __func__, wq->rq.pidx);writel (PIDX_T5_V (inc) |QID_V (wq->rq.bar2_qid), wq->rq.bar2_va +SGE_UDB_KDOORBELL ); }
@@ -601,7 +601,8 @@ static inline void t4_swcq_produce(struct t4_cq *cq) { cq->sw_in_use++;if (cq->sw_in_use == cq->size) { -PDBG ("%s cxgb4 sw cq overflow cqid %u\n" , __func__, cq->cqid); +pr_debug ("%s cxgb4 sw cq overflow cqid %u\n" , + __func__, cq->cqid); cq->error =1 ;BUG_ON (1 ); }
@@ -672,7 +673,8 @@ static inline int t4_next_hw_cqe(struct t4_cq *cq, struct t4_cqe **cqe)static inline struct t4_cqe *t4_next_sw_cqe (struct t4_cq *cq) {if (cq->sw_in_use == cq->size) { -PDBG ("%s cxgb4 sw cq overflow cqid %u\n" , __func__, cq->cqid); +pr_debug ("%s cxgb4 sw cq overflow cqid %u\n" , + __func__, cq->cqid); cq->error =1 ;BUG_ON (1 );return NULL ;
Signature · 1 line
2.10.0.rc2.1.g053435c
RE: [PATCH 4/4] cxgb4: Convert PDBG to pr_debug
Quoted 7 lines
[email protected]
Subject: [PATCH 4/4] cxgb4: Convert PDBG topr_debugUse a more typical logging style.
Miscellanea:
Quoted 7 lines
o Obsolete the
c4iw_debugmodule parameter
o Coalesce formats
o Realign argumentsSigned-off-by Joe Perches <[email protected]>--- drivers/infiniband/hw/cxgb4/cm.c | 303
+++++++++++++++++----------------
Quoted 10 lines
drivers/infiniband/hw/cxgb4/cq.c | 71 ++++---- drivers/infiniband/hw/cxgb4/device.c | 58 +++---- drivers/infiniband/hw/cxgb4/ev.c | 29 ++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 44 +++-- drivers/infiniband/hw/cxgb4/mem.c | 28 +-- drivers/infiniband/hw/cxgb4/provider.c | 38 ++--- drivers/infiniband/hw/cxgb4/qp.c | 91 +++++----- drivers/infiniband/hw/cxgb4/resource.c | 46 ++--- drivers/infiniband/hw/cxgb4/t4.h | 22 +-- 10 files changed, 368 insertions(+), 362 deletions(-)
Looks good (and thanks).
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 33 lines · Joe Perches
Neaten logging
Joe Perches (4):
cxgb3: Use more common logging style
cxgb3: Convert PDBG topr_debug
cxgb4: Use more common logging style
cxgb4: Convert PDBG topr_debugdrivers/infiniband/hw/cxgb3/cxio_dbg.c | 35 +-- drivers/infiniband/hw/cxgb3/cxio_hal.c | 201 +++++++-------- drivers/infiniband/hw/cxgb3/cxio_hal.h | 7 +-drivers/infiniband/hw/cxgb3/cxio_resource.c | 25 +- drivers/infiniband/hw/cxgb3/iwch.c | 19 +- drivers/infiniband/hw/cxgb3/iwch_cm.c | 269 ++++++++++------
---drivers/infiniband/hw/cxgb3/iwch_cm.h | 18 +- drivers/infiniband/hw/cxgb3/iwch_cq.c | 21 +- drivers/infiniband/hw/cxgb3/iwch_ev.c | 26 +-drivers/infiniband/hw/cxgb3/iwch_mem.c | 2 +-
drivers/infiniband/hw/cxgb3/iwch_provider.c| 112 ++++----drivers/infiniband/hw/cxgb3/iwch_provider.h| 9 +- drivers/infiniband/hw/cxgb3/iwch_qp.c | 67 +++-- drivers/infiniband/hw/cxgb4/cm.c | 387 ++++++++++++++--
------------
drivers/infiniband/hw/cxgb4/cq.c | 79 +++--- drivers/infiniband/hw/cxgb4/device.c | 141 +++++----- drivers/infiniband/hw/cxgb4/ev.c | 39 ++- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 48 ++-- drivers/infiniband/hw/cxgb4/mem.c | 34 ++- drivers/infiniband/hw/cxgb4/provider.c | 42 ++- drivers/infiniband/hw/cxgb4/qp.c | 96 +++---- drivers/infiniband/hw/cxgb4/resource.c | 64 +++-- drivers/infiniband/hw/cxgb4/t4.h | 24 +-
Quoted 1 line
23 files changed, 861 insertions(+), 904 deletions(-)
Series applied, thanks.
Signature · 9 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html