Patch "CIFS: remove bad_network_name flag" has been added to the 4.9-stable tree
This is a note to let you know that I've just added the patch titled
CIFS: remove bad_network_name flag
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cifs-remove-bad_network_name-flag.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
a0918f1ce6a43ac980b42b300ec443c154970979Mon Sep 17 00:00:00 2001
From: Germano Percossi <[email protected]>
Date: Fri, 7 Apr 2017 12:29:37 +0100
Subject: CIFS: remove bad_network_name flag
From: Germano Percossi <[email protected]>
commit a0918f1ce6a43ac980b42b300ec443c154970979 upstream.
STATUS_BAD_NETWORK_NAME can be received during node failover, causing the flag to be set and making the reconnect thread always unsuccessful, thereafter.
Once the only place where it is set is removed, the remaining bits are rendered moot.
Removing it does not prevent "mount" from failing when a non existent share is passed.
What happens when the share really ceases to exist while the share is mounted is undefined now as much as it was before.
--- fs/cifs/cifsglob.h | 1 - fs/cifs/smb2pdu.c | 5 ----- 2 files changed, 6 deletions(-)
fs/cifs/cifsglob.h +0 -1
@@ -930,7 +930,6 @@ struct cifs_tcon { bool use_persistent:1; /* use persistent instead of durable handles */#ifdef CONFIG_CIFS_SMB2 bool print:1; /* set if connection to printer share */ - bool bad_network_name:1; /* set if ret status STATUS_BAD_NETWORK_NAME */__le32 capabilities;__u32 share_flags;__u32 maximal_access;
fs/cifs/smb2pdu.c +0 -5
@@ -1084,9 +1084,6 @@ SMB2_tcon(const unsigned int xid, structelse return -EIO ; -if (tcon && tcon->bad_network_name) -return -ENOENT ; -if ((tcon && tcon->seal) && ((ses->server->capabilities &SMB2_GLOBAL_CAP_ENCRYPTION ) ==0 )) {cifs_dbg (VFS ,"encryption requested but no server support" );
@@ -1188,8 +1185,6 @@ tcon_exit: tcon_error_exit:if (rsp->hdr.Status ==STATUS_BAD_NETWORK_NAME ) {cifs_dbg (VFS ,"BAD_NETWORK_NAME: %s\n" , tree); -if (tcon) - tcon->bad_network_name = true; } goto tcon_exit; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/cifs-remove-bad_network_name-flag.patch