staging: fbtft: fix character limit, trailing ; warning, etc.
Subsystems (2)
PATCH 1/1 staging: fbtft: fix character limit, trailing ; warning, etc.
checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that.
--- drivers/staging/fbtft/fbtft-bus.c | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +20 -7
@@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \ buf[i] = (type)va_arg(args, unsigned int); \ } \va_end (args); \ -fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , par, par->info->device, type, buf, len,"%s: " , __func__); \ +fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , \ + par, \ + par->info->device, \ + type, \ + buf, \ + len, \ +"%s: " , \ + __func__); \ } \ \va_start (args, len); \
@@ -41,7 +48,10 @@ void func(struct fbtft_par *par, int len, ...) \ ret = par->fbtftops.write (par, par->buf,sizeof (type) + offset); \if (ret <0 ) { \va_end (args); \ -dev_err (par->info->device,"%s: write() failed and returned %d\n" , __func__, ret); \ +dev_err (par->info->device, \ +"%s: write() failed and returned %d\n" , \ + __func__, \ + ret); \return ; \ } \ len--; \
@@ -60,17 +70,20 @@ void func(struct fbtft_par *par, int len, ...) \ len * (sizeof(type) + offset)); \if (ret <0 ) { \va_end (args); \ -dev_err (par->info->device,"%s: write() failed and returned %d\n" , __func__, ret); \ +dev_err (par->info->device, \ +"%s: write() failed and returned %d\n" , \ + __func__, \ + ret); \return ; \ } \ } \va_end (args); \ } \ -EXPORT_SYMBOL (func); +EXPORT_SYMBOL (func) -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ) -define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, ); +define_fbtft_write_reg (fbtft_write_reg16_bus8, u16, cpu_to_be16); +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, );void fbtft_write_reg8_bus9 (struct fbtft_par *par,int len, ...) {
Signature · 1 line
2.7.4
Quoted 4 lines · Eric Curtin
checkpatch spits out a warning about the 80 character line limit. Split the parameters of these functions onto different lines. Put the ; with the macro caller instead. Lined up parameters as there was another CHECK warning about that.
[]
drivers/staging/fbtft/fbtft-bus.c
Quoted 1 line
drivers/staging/fbtft/fbtft-bus.c +0
-0
[]
Quoted 4 lines
drivers/staging/fbtft/fbtft-bus.c +0
-0@@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \ buf[i] = (type)va_arg(args, unsigned int); \ } \va_end (args); \
drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 35
Quoted 10 lines
drivers/staging/fbtft/fbtft-bus.c +8
-1-fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , par, par->info->device, type, buf, len,"%s: " , __func__); \ +fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , \ + par, \ + par->info->device, \ + type, \ + buf, \ + len, \ +"%s: " , \ + __func__); \ } \
Multiple arguments per line please before 80 columns
fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, \ par->info->device, type, buf, len, \ "%s: ", __func__); \