Skip to contentSkip to conversation

IB/vmw_pvrdma: Spare annotate imm_data

PATCH Applied Jason Gunthorpe 3 participants 3 messages Apr 6, 2017 – Apr 25, 2017 2 messages not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/vmw_pvrdma: Spare annotate imm_data

imm_data is copied directly from the ib_send_wr and ib_wc which have it marked as __be32, copy that mark into the uapi structures as well.

---
 include/uapi/rdma/vmw_pvrdma-abi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This fixes sparse errors in user space and kernel space

include/uapi/rdma/vmw_pvrdma-abi.h +2 -2
index 5016abc9ee9712..c8c1d2d6df4d52 100644
@@ -222,7 +222,7 @@ struct pvrdma_sq_wqe_hdr {
 	__u32 opcode;		/* operation type */
 	__u32 send_flags;	/* wr flags */
 	union {
-		__u32 imm_data;
+		__be32 imm_data;
 		__u32 invalidate_rkey;
 	} ex;
 	__u32 reserved;
@@ -273,7 +273,7 @@ struct pvrdma_cqe {
 	__u32 opcode;
 	__u32 status;
 	__u32 byte_len;
-	__u32 imm_data;
+	__be32 imm_data;
 	__u32 src_qp;
 	__u32 wc_flags;
 	__u32 vendor_err;
Signature · 5 lines
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170406223314.GA3893-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org

Tested-by Acked-by
#2 lore raw
Quoted 10 lines · Jason Gunthorpe

imm_data is copied directly from the ib_send_wr and ib_wc which have it marked as __be32, copy that mark into the uapi structures as well.

---
 include/uapi/rdma/vmw_pvrdma-abi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This fixes sparse errors in user space and kernel space

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): c9d760af-2437-b377-3663-9df0973e542e-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org

Applied
#4 lore raw
Quoted 12 lines · Adit Ranadive
Quoted 11 lines · Jason Gunthorpe

imm_data is copied directly from the ib_send_wr and ib_wc which have
it marked as __be32, copy that mark into the uapi structures as well.

---
 include/uapi/rdma/vmw_pvrdma-abi.h | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 2 lines

This fixes sparse errors in user space and kernel space

Thanks!

Thanks, applied.

Signature · 9 lines
Doug Ledford <[email protected]>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html