Skip to contentSkip to conversation

drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.

PATCH In review Karim Eshapa 3 participants 7 messages Apr 26, 2017 – May 12, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.

Fixing sparse warnings incorrect type assignment.

---
 drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +14 -10
index 6134eba..cf6bf65 100644
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
 		datap = skb_put(skb, sizeof(struct p80211_caphdr));
 		caphdr = (struct p80211_caphdr *)datap;
 
-		caphdr->version = htonl(P80211CAPTURE_VERSION);
-		caphdr->length = htonl(sizeof(struct p80211_caphdr));
+		caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+		caphdr->length = __be32_to_cpu( htonl(sizeof(
+						struct p80211_caphdr)));
 		caphdr->mactime = __cpu_to_be64(rxdesc->time) * 1000;
 		caphdr->hosttime = __cpu_to_be64(jiffies);
-		caphdr->phytype = htonl(4);	/* dss_dot11_b */
-		caphdr->channel = htonl(hw->sniff_channel);
-		caphdr->datarate = htonl(rxdesc->rate);
-		caphdr->antenna = htonl(0);	/* unknown */
-		caphdr->priority = htonl(0);	/* unknown */
-		caphdr->ssi_type = htonl(3);	/* rssi_raw */
+
+		/* dss_dot11_b */
+		caphdr->phytype = __be32_to_cpu(htonl(4));
+
+		caphdr->channel = __be32_to_cpu(htonl(hw->sniff_channel));
+		caphdr->datarate = __be32_to_cpu(htonl(rxdesc->rate));
+		caphdr->antenna =  __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->priority = __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->ssi_type = __be32_to_cpu(htonl(3));	/* rssi_raw */
 		caphdr->ssi_signal = htonl(rxdesc->signal);
 		caphdr->ssi_noise = htonl(rxdesc->silence);
-		caphdr->preamble = htonl(0);	/* unknown */
-		caphdr->encoding = htonl(1);	/* cck */
+		caphdr->preamble = __be32_to_cpu(htonl(0));	/* unknown */
+		caphdr->encoding = __be32_to_cpu(htonl(1));	/* cck */
 	}
 
 	/* Copy the 802.11 header to the skb
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 12 lines · Karim Eshapa

Fixing sparse warnings incorrect type assignment.

---
 drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +0 -0
index 6134eba..cf6bf65 100644

drivers/staging/wlan-ng/hfa384x_usb.c static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, · line 3516

Quoted 8 lines
drivers/staging/wlan-ng/hfa384x_usb.c +3 -2
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
 		datap = skb_put(skb, sizeof(struct p80211_caphdr));
 		caphdr = (struct p80211_caphdr *)datap;
 
-		caphdr->version = htonl(P80211CAPTURE_VERSION);
-		caphdr->length = htonl(sizeof(struct p80211_caphdr));
+		caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+		caphdr->length = __be32_to_cpu( htonl(sizeof(
+						struct p80211_caphdr)));

How do you know this is correct? And why the odd ' ' usage? I can't take this patch for that reason alone...

thanks,

greg k-h

#2 lore raw
In reply to Karim Eshapa
Quoted 17 lines · Greg KH
Quoted 15 lines · Karim Eshapa

Fixing sparse warnings incorrect type assignment.

---
 drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +0 -0
index 6134eba..cf6bf65 100644
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
              datap = skb_put(skb, sizeof(struct p80211_caphdr));
              caphdr = (struct p80211_caphdr *)datap;
 
Quoted 10 lines

drivers/staging/wlan-ng/hfa384x_usb.c static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, · line 3533

Quoted 6 lines
drivers/staging/wlan-ng/hfa384x_usb.c +3 -2
-             caphdr->version = htonl(P80211CAPTURE_VERSION);
-             caphdr->length = htonl(sizeof(struct p80211_caphdr));
+             caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+             caphdr->length = __be32_to_cpu( htonl(sizeof(
+                                             struct p80211_caphdr)));
 

How do you know this is correct? And why the odd ' ' usage? I can't take this patch for that reason alone...

Actually using __be32_to_cpu may result in a problem if it's built for le machine. becasue if the network byte order needs to be represented in __be32 such that the header is going through the network in a right order.
So, I suggest if we can change the structure's args type into __be32 that I don't trust it if it can force the arg to be big endian as it's defined as __attribute__((bitwise)) that I'm not sure if it's GNU C attribute.
that I didn't want from the beginning.

Thanks,
Karim

#3 lore raw
Quoted 29 lines · Karim Eshapa
Quoted 17 lines · Greg KH
Quoted 15 lines · Karim Eshapa

Fixing sparse warnings incorrect type assignment.

---
 drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +0 -0
index 6134eba..cf6bf65 100644
@@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
              datap = skb_put(skb, sizeof(struct p80211_caphdr));
              caphdr = (struct p80211_caphdr *)datap;
 
Quoted 10 lines

drivers/staging/wlan-ng/hfa384x_usb.c static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, · line 3533

Quoted 6 lines
drivers/staging/wlan-ng/hfa384x_usb.c +3 -2
-             caphdr->version = htonl(P80211CAPTURE_VERSION);
-             caphdr->length = htonl(sizeof(struct p80211_caphdr));
+             caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
+             caphdr->length = __be32_to_cpu( htonl(sizeof(
+                                             struct p80211_caphdr)));
 

How do you know this is correct? And why the odd ' ' usage? I can't take this patch for that reason alone...

Quoted 7 lines

Actually using __be32_to_cpu may result in a problem if it's built for le machine. becasue if the network byte order needs to be represented in __be32 such that the header is going through the network in a right order.
So, I suggest if we can change the structure's args type into __be32 that I don't trust it if it can force the arg to be big endian as it's defined as __attribute__((bitwise)) that I'm not sure if it's GNU C attribute.
that I didn't want from the beginning.

It sounds like the correct fix would be to change the type of the members in p80211_caphdr.

Arnd

#4 lore raw
In reply to Karim Eshapa

Change the types of capture header, finally we need the header to be represented in the network byte order as __be..
this is a piece of doc that he mentioned it in the code doc/capturefrm.txt You can check
https://github.com/jdkoftinoff/mb-linux-msli/blob/master/
uClinux-dist/user/wlan-ng/doc/capturefrm.txt

3. Byte Order
All multibyte fields of the capture header are in "network" byte order. The "host to network" and "network to host" functions should work just fine. All the remaining multibyte fields are ordered according to their respective standards.

4. Capture Header Format
The following fields make up the AVS capture header:

	Offset	Name		Type
	------------------------------
	0	version		uint32
	4	length		uint32
	8	mactime		uint64
	16	hosttime	uint64
	24	phytype		uint32
	28	channel		uint32
	32	datarate	uint32
	36	antenna		uint32
	40	priority	uint32
	44	ssi_type	uint32
	48	ssi_signal	int32
	52	ssi_noise	int32
	56	preamble	uint32
	60	encoding	uint32

------------------------------

and the warnings here fixed

drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: expected unsigned int [unsigned] [usertype] version
drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: expected unsigned int [unsigned] [usertype] length
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3516:35: warning: restricted __be64 degrades to integer drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: expected unsigned long long [unsigned] [usertype] hosttime
drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: got restricted __be64 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: expected unsigned int [unsigned] [usertype] phytype
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: expected unsigned int [unsigned] [usertype] channel
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: expected unsigned int [unsigned] [usertype] datarate
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: expected unsigned int [unsigned] [usertype] antenna
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: expected unsigned int [unsigned] [usertype] priority
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: expected unsigned int [unsigned] [usertype] ssi_type
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: expected signed int [signed] [usertype] [explicitly-signed] ssi_signal
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: expected signed int [signed] [usertype] [explicitly-signed] ssi_noise
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: expected unsigned int [unsigned] [usertype] preamble
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: expected unsigned int [unsigned] [usertype] encoding
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: got restricted __be32 [usertype] <noident>

If this patch is fine, can I send the rest of fixes.

---
 drivers/staging/wlan-ng/hfa384x_usb.c |  2 +-
 drivers/staging/wlan-ng/p80211conv.h  | 28 ++++++++++++++--------------
 2 files changed, 15 insertions(+), 15 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +1 -1
index 6134eba..8f989bc 100644
@@ -3513,7 +3513,7 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
 
 		caphdr->version = htonl(P80211CAPTURE_VERSION);
 		caphdr->length = htonl(sizeof(struct p80211_caphdr));
-		caphdr->mactime = __cpu_to_be64(rxdesc->time) * 1000;
+		caphdr->mactime = __cpu_to_be64(rxdesc->time * 1000);
 		caphdr->hosttime = __cpu_to_be64(jiffies);
 		caphdr->phytype = htonl(4);	/* dss_dot11_b */
 		caphdr->channel = htonl(hw->sniff_channel);
drivers/staging/wlan-ng/p80211conv.h +14 -14
index 04bac2e..66332b1 100644
@@ -101,20 +101,20 @@ void p80211skb_rxmeta_detach(struct sk_buff *skb);
  * Frame capture header.  (See doc/capturefrm.txt)
  */
 struct p80211_caphdr {
-	u32 version;
-	u32 length;
-	u64 mactime;
-	u64 hosttime;
-	u32 phytype;
-	u32 channel;
-	u32 datarate;
-	u32 antenna;
-	u32 priority;
-	u32 ssi_type;
-	s32 ssi_signal;
-	s32 ssi_noise;
-	u32 preamble;
-	u32 encoding;
+	__be32 version;
+	__be32 length;
+	__be64 mactime;
+	__be64 hosttime;
+	__be32 phytype;
+	__be32 channel;
+	__be32 datarate;
+	__be32 antenna;
+	__be32 priority;
+	__be32 ssi_type;
+	__be32 ssi_signal;
+	__be32 ssi_noise;
+	__be32 preamble;
+	__be32 encoding;
 };
 
 /* buffer free method pointer type */
Signature · 1 line
2.7.4
maintainer
#5 lore raw

First off, why the "Re:" in the subject?

Second, your subject sucks :)

Try making it a bit more descriptive as to what you are doing, "fixing sparse warnings" is very vague.

Quoted 8 lines · Karim Eshapa

Change the types of capture header, finally we need the header to be represented in the network byte order as __be..
this is a piece of doc that he mentioned it in the code doc/capturefrm.txt You can check
https://github.com/jdkoftinoff/mb-linux-msli/blob/master/
uClinux-dist/user/wlan-ng/doc/capturefrm.txt

3. Byte Order

3? Where is 1. and 2.?

Quoted 69 lines

All multibyte fields of the capture header are in "network" byte order. The "host to network" and "network to host" functions should work just fine. All the remaining multibyte fields are ordered according to their respective standards.

4. Capture Header Format
The following fields make up the AVS capture header:

	Offset	Name		Type
	------------------------------
	0	version		uint32
	4	length		uint32
	8	mactime		uint64
	16	hosttime	uint64
	24	phytype		uint32
	28	channel		uint32
	32	datarate	uint32
	36	antenna		uint32
	40	priority	uint32
	44	ssi_type	uint32
	48	ssi_signal	int32
	52	ssi_noise	int32
	56	preamble	uint32
	60	encoding	uint32

------------------------------

and the warnings here fixed

drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: expected unsigned int [unsigned] [usertype] version
drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: expected unsigned int [unsigned] [usertype] length
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3516:35: warning: restricted __be64 degrades to integer drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: expected unsigned long long [unsigned] [usertype] hosttime
drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: got restricted __be64 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: expected unsigned int [unsigned] [usertype] phytype
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: expected unsigned int [unsigned] [usertype] channel
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: expected unsigned int [unsigned] [usertype] datarate
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: expected unsigned int [unsigned] [usertype] antenna
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: expected unsigned int [unsigned] [usertype] priority
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: expected unsigned int [unsigned] [usertype] ssi_type
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: expected signed int [signed] [usertype] [explicitly-signed] ssi_signal
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: expected signed int [signed] [usertype] [explicitly-signed] ssi_noise
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: expected unsigned int [unsigned] [usertype] preamble
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: expected unsigned int [unsigned] [usertype] encoding
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: got restricted __be32 [usertype] <noident>

Quoted 1 line

If this patch is fine, can I send the rest of fixes.

This line doesn't need to be in a changelog text, right? Please fix up and resend.

thanks,

greg k-h

#6 lore raw
In reply to Karim Eshapa
Quoted 16 lines · On Fri, 12 May 2017 10:07:14 +0200 Greg KH wrote:

First off, why the "Re:" in the subject?

Second, your subject sucks :)

Try making it a bit more descriptive as to what you are doing, "fixing sparse warnings" is very vague.

Quoted 7 lines · Karim Eshapa

Change the types of capture header, finally we need the header to be represented in the network byte order as __be..
this is a piece of doc that he mentioned it in the code doc/capturefrm.txt You can check
https://github.com/jdkoftinoff/mb-linux-msli/blob/master/
uClinux-dist/user/wlan-ng/doc/capturefrm.txt

Quoted 5 lines
Quoted 2 lines

3. Byte Order

3? Where is 1. and 2.?

This line is part of documentation mentioned in
the main code doc/capturefrm.txt. 1., 2. exist
in the documentation.

Quoted 69 lines
Quoted 69 lines

All multibyte fields of the capture header are in "network" byte order. The "host to network" and "network to host" functions should work just fine. All the remaining multibyte fields are ordered according to their respective standards.

4. Capture Header Format
The following fields make up the AVS capture header:

Offset Name Type
------------------------------
0 version uint32
4 length uint32
8 mactime uint64
16 hosttime uint64
24 phytype uint32
28 channel uint32
32 datarate uint32
36 antenna uint32
40 priority uint32
44 ssi_type uint32
48 ssi_signal int32
52 ssi_noise int32
56 preamble uint32
60 encoding uint32
------------------------------

and the warnings here fixed

drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: expected unsigned int [unsigned] [usertype] version
drivers/staging/wlan-ng/hfa384x_usb.c:3514:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: expected unsigned int [unsigned] [usertype] length
drivers/staging/wlan-ng/hfa384x_usb.c:3515:32: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3516:35: warning: restricted __be64 degrades to integer drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: expected unsigned long long [unsigned] [usertype] hosttime
drivers/staging/wlan-ng/hfa384x_usb.c:3517:34: got restricted __be64 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: expected unsigned int [unsigned] [usertype] phytype
drivers/staging/wlan-ng/hfa384x_usb.c:3518:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: expected unsigned int [unsigned] [usertype] channel
drivers/staging/wlan-ng/hfa384x_usb.c:3519:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: expected unsigned int [unsigned] [usertype] datarate
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: expected unsigned int [unsigned] [usertype] antenna
drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: expected unsigned int [unsigned] [usertype] priority
drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: expected unsigned int [unsigned] [usertype] ssi_type
drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: expected signed int [signed] [usertype] [explicitly-signed] ssi_signal
drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: expected signed int [signed] [usertype] [explicitly-signed] ssi_noise
drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: expected unsigned int [unsigned] [usertype] preamble
drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: got restricted __be32 [usertype] <noident>
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: expected unsigned int [unsigned] [usertype] encoding
drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: got restricted __be32 [usertype] <noident>

Quoted 6 lines
Quoted 2 lines

If this patch is fine, can I send the rest of fixes.

This line doesn't need to be in a changelog text, right? Please fix up and resend.

Ok sorry I'm gonna send you the new patch
with descriptive subject.

Thanks,
Karim