Fix inaccurate helper function description
Subsystems (3)
PATCH 1/1 Fix inaccurate helper function description
From: Chenbo Feng <[email protected]>
The description inside uapi/linux/bpf.h about bpf_get_socket_uid helper function is no longer valid. It returns overflowuid rather than 0 when failed.
--- include/uapi/linux/bpf.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
include/uapi/linux/bpf.h +1 -2
@@ -481,8 +481,7 @@ union bpf_attr {* u32 bpf_get_socket_uid(skb) * Get the owner uid of the socket stored inside sk_buff. * @skb: pointer to skb -* Return: uid of the socket owner on success or 0 if the socket pointer -* inside sk_buff is NULL +* Return: uid of the socket owner on success or overflowuid if failed. */ #define __BPF_FUNC_MAPPER (FN ) \ FN(unspec), \
Signature · 1 line
2.7.4
Quoted 7 lines · Chenbo Feng
From: Chenbo Feng <[email protected]>
The description inside
uapi/linux/bpf.haboutbpf_get_socket_uidhelper function is no longer valid. It returns overflowuid rather than 0 when failed.Signed-off-by Chenbo Feng <[email protected]>
"bpf: " prefix in patch subject line would have been good.
Alexei Starovoitov
Acked-byQuoted 10 lines · Daniel Borkmann
Quoted 7 lines · Chenbo Feng
From: Chenbo Feng <[email protected]>
The description inside
uapi/linux/bpf.haboutbpf_get_socket_uidhelper function is no longer valid. It returns overflowuid rather than 0 when failed.Signed-off-by Chenbo Feng <[email protected]>"bpf: " prefix in patch subject line would have been good.
+1
last time missing 'bpf:' prefix caused me headaches during backporting, so please always use it.
Also please use scripts/get_maintainer.pl to make sure maintainers cc-ed on patches.
gmail delivers netdev list emails to my mailbox with 10+ hour delay for some reason.
From: Chenbo Feng <[email protected]>
Date: Wed, 26 Apr 2017 16:41:23 -0700
Quoted 7 lines
From: Chenbo Feng <[email protected]>
The description inside
uapi/linux/bpf.haboutbpf_get_socket_uidhelper function is no longer valid. It returns overflowuid rather than 0 when failed.Signed-off-by Chenbo Feng <[email protected]>
Applied.