Skip to contentSkip to conversation

target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()

PATCH Applied Hannes Reinecke 3 participants 3 messages Apr 28, 2017 – May 2, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()

When setting up an ALUA target port group with an invalid ID the error message

kstrtoul() returned -22 for tg_pt_gp_id

is displayed, which is not really helpful.
Convert it to something sane.
And while we're at it, join the messages onto a single line.

---
 drivers/target/target_core_configfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/target/target_core_configfs.c +4 -4
index e8850ae..f62130f 100644
@@ -2639,13 +2639,13 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
 
 	ret = kstrtoul(page, 0, &tg_pt_gp_id);
 	if (ret < 0) {
-		pr_err("kstrtoul() returned %d for"
-			" tg_pt_gp_id\n", ret);
+		pr_err("ALUA tg_pt_gp_id: invalid value '%s' for tg_pt_gp_id\n",
+		       page);
 		return ret;
 	}
 	if (tg_pt_gp_id > 0x0000ffff) {
-		pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum:"
-			" 0x0000ffff\n", tg_pt_gp_id);
+		pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum: 0x0000ffff\n",
+		       tg_pt_gp_id);
 		return -EINVAL;
 	}
 
Signature · 1 line
1.8.5.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Hannes Reinecke

When setting up an ALUA target port group with an invalid ID the error message

kstrtoul() returned -22 for tg_pt_gp_id

is displayed, which is not really helpful.
Convert it to something sane.
And while we're at it, join the messages onto a single line.

#2 lore raw
In reply to Hannes Reinecke
Quoted 5 lines · Hannes Reinecke

When setting up an ALUA target port group with an invalid ID the error message

kstrtoul() returned -22 for tg_pt_gp_id

Quoted 9 lines

is displayed, which is not really helpful.
Convert it to something sane.
And while we're at it, join the messages onto a single line.

---
 drivers/target/target_core_configfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Applied.

Thanks Hannes.