Skip to contentSkip to conversation

amdgpu: add interface for reserve/unserve vmid

PATCH In review Chunming Zhou 2 participants 3 messages Apr 28, 2017 – May 2, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amdgpu: add interface for reserve/unserve vmid

Change-Id If533576eb8a65bd019a3480d6fe2a64f23e3c944
---
 amdgpu/amdgpu.h    | 13 +++++++++++++
 amdgpu/amdgpu_cs.c | 30 ++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
amdgpu/amdgpu.h +13 -0
index 4772006..7afade0 100644
@@ -1626,6 +1626,19 @@ int amdgpu_cs_signal_sem(amdgpu_device_handle dev,
 			 uint32_t ip_instance,
 			 uint32_t ring,
 			 amdgpu_sem_handle sem);
+/**
+ *  reserve vmid for this process
+ *
+ * \param   dev    - [in] Device handle. See #amdgpu_device_initialize()
+ */
+int amdgpu_cs_reserved_vmid(amdgpu_device_handle dev);
+
+/**
+ *  unreserve vmid for this process
+ *
+ * \param   dev    - [in] Device handle. See #amdgpu_device_initialize()
+ */
+int amdgpu_cs_unreserved_vmid(amdgpu_device_handle dev);
 
 /**
  *  wait sem
amdgpu/amdgpu_cs.c +30 -0
index 62b595a..df362ee 100644
@@ -754,3 +754,33 @@ int amdgpu_cs_destroy_sem(amdgpu_device_handle dev,
 
 	return 0;
 }
+
+int amdgpu_cs_unreserved_vmid(amdgpu_device_handle dev)
+{
+	union drm_amdgpu_vm args;
+	int r;
+
+	if (NULL == dev)
+		return -EINVAL;
+
+	/* Create the context */
+	memset(&args, 0, sizeof(args));
+	args.in.op = AMDGPU_VM_OP_UNRESERVE_VMID;
+	r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_VM, &args, sizeof(args));
+	return r;
+}
+
+int amdgpu_cs_reserved_vmid(amdgpu_device_handle dev)
+{
+	union drm_amdgpu_vm args;
+	int r;
+
+	if (NULL == dev)
+		return -EINVAL;
+
+	/* Create the context */
+	memset(&args, 0, sizeof(args));
+	args.in.op = AMDGPU_VM_OP_RESERVE_VMID;
+	r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_VM, &args, sizeof(args));
+	return r;
+}
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1493371366-10581-1-git-send-email-David1.Zhou-5C7GfCeVMHo@public.gmane.org

author
#2 lore raw

anyone could give a quick review?

Regards,
David Zhou

Quoted 59 lines · Chunming Zhou
Change-Id If533576eb8a65bd019a3480d6fe2a64f23e3c944
---
  amdgpu/amdgpu.h    | 13 +++++++++++++
  amdgpu/amdgpu_cs.c | 30 ++++++++++++++++++++++++++++++
  2 files changed, 43 insertions(+)
amdgpu/amdgpu.h +13 -0
index 4772006..7afade0 100644
@@ -1626,6 +1626,19 @@ int amdgpu_cs_signal_sem(amdgpu_device_handle dev,
  			 uint32_t ip_instance,
  			 uint32_t ring,
  			 amdgpu_sem_handle sem);
+/**
+ *  reserve vmid for this process
+ *
+ * \param   dev    - [in] Device handle. See #amdgpu_device_initialize()
+ */
+int amdgpu_cs_reserved_vmid(amdgpu_device_handle dev);
+
+/**
+ *  unreserve vmid for this process
+ *
+ * \param   dev    - [in] Device handle. See #amdgpu_device_initialize()
+ */
+int amdgpu_cs_unreserved_vmid(amdgpu_device_handle dev);
 
  /**
   *  wait sem
amdgpu/amdgpu_cs.c +20 -0
index 62b595a..df362ee 100644
@@ -754,3 +754,33 @@ int amdgpu_cs_destroy_sem(amdgpu_device_handle dev,
 
  	return 0;
  }
+
+int amdgpu_cs_unreserved_vmid(amdgpu_device_handle dev)
+{
+	union drm_amdgpu_vm args;
+	int r;
+
+	if (NULL == dev)
+		return -EINVAL;
+
+	/* Create the context */
+	memset(&args, 0, sizeof(args));
+	args.in.op = AMDGPU_VM_OP_UNRESERVE_VMID;
+	r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_VM, &args, sizeof(args));
+	return r;
+}
+
+int amdgpu_cs_reserved_vmid(amdgpu_device_handle dev)
+{
+	union drm_amdgpu_vm args;
+	int r;

amdgpu/amdgpu_cs.c int amdgpu_cs_destroy_sem(amdgpu_device_handle dev, · line 786

Quoted 10 lines
amdgpu/amdgpu_cs.c +10 -0
+
+	if (NULL == dev)
+		return -EINVAL;
+
+	/* Create the context */
+	memset(&args, 0, sizeof(args));
+	args.in.op = AMDGPU_VM_OP_RESERVE_VMID;
+	r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_VM, &args, sizeof(args));
+	return r;
+}

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 36 lines · Chunming Zhou
Change-Id If533576eb8a65bd019a3480d6fe2a64f23e3c944
---
  amdgpu/amdgpu.h    | 13 +++++++++++++
  amdgpu/amdgpu_cs.c | 30 ++++++++++++++++++++++++++++++
  2 files changed, 43 insertions(+)
amdgpu/amdgpu.h +13 -0
index 4772006..7afade0 100644
@@ -1626,6 +1626,19 @@ int amdgpu_cs_signal_sem(amdgpu_device_handle dev,
  			 uint32_t ip_instance,
  			 uint32_t ring,
  			 amdgpu_sem_handle sem);
+/**
+ *  reserve vmid for this process
+ *
+ * \param   dev    - [in] Device handle. See #amdgpu_device_initialize()
+ */
+int amdgpu_cs_reserved_vmid(amdgpu_device_handle dev);
+
+/**
+ *  unreserve vmid for this process
+ *
+ * \param   dev    - [in] Device handle. See #amdgpu_device_initialize()
+ */
+int amdgpu_cs_unreserved_vmid(amdgpu_device_handle dev);
 
  /**
   *  wait sem
amdgpu/amdgpu_cs.c +0 -0
index 62b595a..df362ee 100644

amdgpu/amdgpu_cs.c int amdgpu_cs_destroy_sem(amdgpu_device_handle dev, · line 758

Quoted 5 lines
amdgpu/amdgpu_cs.c +2 -0
@@ -754,3 +754,33 @@ int amdgpu_cs_destroy_sem(amdgpu_device_handle dev,
 
  	return 0;
  }
+
+int amdgpu_cs_unreserved_vmid(amdgpu_device_handle dev)

We might provide one more parameter for UMD flexibly, even if it's unused for now. i.e. the number of reserved vmid(constrained by KMD limitation, of course) and anything else like that.

Did we have any discussion about it with UMD guys?

amdgpu/amdgpu_cs.c int amdgpu_cs_destroy_sem(amdgpu_device_handle dev, · line 766

Quoted 8 lines
amdgpu/amdgpu_cs.c +8 -0
+{
+	union drm_amdgpu_vm args;
+	int r;
+
+	if (NULL == dev)
+		return -EINVAL;
+
+	/* Create the context */

It looks typo in comment for the actual code

Quoted 5 lines
amdgpu/amdgpu_cs.c +5 -0
+	memset(&args, 0, sizeof(args));
+	args.in.op = AMDGPU_VM_OP_UNRESERVE_VMID;
+	r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_VM, &args, sizeof(args));
+	return r;
+}

amdgpu/amdgpu_cs.c int amdgpu_cs_destroy_sem(amdgpu_device_handle dev, · line 781

Quoted 10 lines
amdgpu/amdgpu_cs.c +10 -0
+
+int amdgpu_cs_reserved_vmid(amdgpu_device_handle dev)
+{
+	union drm_amdgpu_vm args;
+	int r;
+
+	if (NULL == dev)
+		return -EINVAL;
+
+	/* Create the context */

Same typo as above comment

Jerry

amdgpu/amdgpu_cs.c int amdgpu_cs_destroy_sem(amdgpu_device_handle dev, · line 786

Quoted 6 lines
amdgpu/amdgpu_cs.c +5 -0
+	memset(&args, 0, sizeof(args));
+	args.in.op = AMDGPU_VM_OP_RESERVE_VMID;
+	r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_VM, &args, sizeof(args));
+	return r;
+}

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx