Skip to contentSkip to conversation

Patch "net/packet: fix overflow in check for tp_reserve" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Apr 30, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net/packet: fix overflow in check for tp_reserve

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-packet-fix-overflow-in-check-for-tp_reserve.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sun Apr 30 15:50:51 CEST 2017

From: Andrey Konovalov <[email protected]>
Date: Wed, 29 Mar 2017 16:11:22 +0200
Subject: net/packet: fix overflow in check for tp_reserve

From: Andrey Konovalov <[email protected]>

[ Upstream commit bcc5364bdcfe131e6379363f089e7b4108d35b70 ]

When calculating po->tp_hdrlen + po->tp_reserve the result can overflow.

Fix by checking that tp_reserve <= INT_MAX on assign.

---
 net/packet/af_packet.c |    2 ++
 1 file changed, 2 insertions(+)
net/packet/af_packet.c +2 -0
@@ -3314,6 +3314,8 @@ packet_setsockopt(struct socket *sock, i
 			return -EBUSY;
 		if (copy_from_user(&val, optval, sizeof(val)))
 			return -EFAULT;
+		if (val > INT_MAX)
+			return -EINVAL;
 		po->tp_reserve = val;
 		return 0;
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/sctp-listen-on-the-sock-only-when-it-s-state-is-listening-or-closed.patch queue-3.18/net-packet-fix-overflow-in-check-for-tp_frame_nr.patch queue-3.18/net-packet-fix-overflow-in-check-for-tp_reserve.patch queue-3.18/ip6mr-fix-notification-device-destruction.patch