Skip to contentSkip to conversation

Patch "ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 30, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-firewire-lib-fix-inappropriate-assignment-between-signed-unsigned-type.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From dfb00a56935186171abb5280b3407c3f910011f1 Mon Sep 17 00:00:00 2001

From: Takashi Sakamoto <[email protected]>
Date: Fri, 14 Apr 2017 12:43:01 +0900
Subject: ALSA: firewire-lib: fix inappropriate assignment between signed/unsigned type

From: Takashi Sakamoto <[email protected]>

commit dfb00a56935186171abb5280b3407c3f910011f1 upstream.

An abstraction of asynchronous transaction for transmission of MIDI messages was introduced in Linux v4.4. Each driver can utilize this abstraction to transfer MIDI messages via fixed-length payload of transaction to a certain unit address. Filling payload of the transaction is done by callback. In this callback, each driver can return negative error code, however current implementation assigns the return value to unsigned variable.

This commit changes type of the variable to fix the bug.

Fixes 585d7cba5e1f ("ALSA: firewire-lib: add helper functions for asynchronous transactions to transfer MIDI messages")
---
 sound/firewire/lib.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/firewire/lib.h +1 -1
@@ -42,7 +42,7 @@ struct snd_fw_async_midi_port {
 
 	struct snd_rawmidi_substream *substream;
 	snd_fw_async_midi_port_fill fill;
-	unsigned int consume_bytes;
+	int consume_bytes;
 };
 
 int snd_fw_async_midi_port_init(struct snd_fw_async_midi_port *port,

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/alsa-firewire-lib-fix-inappropriate-assignment-between-signed-unsigned-type.patch