Skip to contentSkip to conversation

Patch "ALSA: ppc/awacs: shut up maybe-uninitialized warning" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 3, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: ppc/awacs: shut up maybe-uninitialized warning

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-ppc-awacs-shut-up-maybe-uninitialized-warning.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b268c34e5ee92a4cc3099b0caaf26e6bfbdf0f18 Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Mon, 4 Jul 2016 17:07:45 +0200
Subject: ALSA: ppc/awacs: shut up maybe-uninitialized warning

From: Arnd Bergmann <[email protected]>

commit b268c34e5ee92a4cc3099b0caaf26e6bfbdf0f18 upstream.

The awacs sound driver produces a false-positive warning in ppc64_defconfig:

sound/ppc/awacs.c: In function 'snd_pmac_awacs_init':
include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized]

I haven't come up with a good way to rewrite the code to avoid the warning, so here is a bad one: I initialize the variable before the conditionall initialization so gcc no longer has to worry about it.

---
 sound/ppc/awacs.c |    1 +
 1 file changed, 1 insertion(+)
sound/ppc/awacs.c +1 -0
@@ -991,6 +991,7 @@ snd_pmac_awacs_init(struct snd_pmac *chi
 		if (err < 0)
 			return err;
 	}
+	master_vol = NULL;
 	if (pm7500)
 		err = build_mixers(chip,
 				   ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500),

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/alsa-ppc-awacs-shut-up-maybe-uninitialized-warning.patch queue-4.4/net-tg3-avoid-uninitialized-variable-warning.patch queue-4.4/mtd-avoid-stack-overflow-in-mtd-cfi-code.patch queue-4.4/drbd-avoid-redefinition-of-bits_per_page.patch