drm/amdgpu: fix errors in comments.
Subsystems (2)
PATCH 1/1 drm/amdgpu: fix errors in comments.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -4
@@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,/* * amdgpu_wb_*() -* Writeback is the the method by which the the GPU updates special pages -* in memory with the status of certain GPU events (fences, ring pointers, -* etc.). +* Writeback is the method by which GPU updates special pages in memory +* with the status of certain GPU events (fences, ring pointers,etc.). */ /**
@@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)* * @adev: amdgpu_device pointer * -* Disables Writeback and frees the Writeback memory (all asics). +* Initialize writeback and allocates writeback memory (all asics). * Used at driver startup. * Returns 0 on success or an -error on failure. */
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1494257533-11422-1-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org
Deucher, Alexander
Reviewed-by Alex DeucherQuoted 11 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Alex Xie
Sent: Monday, May 08, 2017 11:32 AM
To: [email protected]
Cc: Xie, AlexBin
Subject: [PATCH] drm/amdgpu: fix errors in comments.Signed-off-by Alex Xie <[email protected]>
Quoted 35 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-3@@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,/* * amdgpu_wb_*() -* Writeback is the the method by which the the GPU updates special pages -* in memory with the status of certain GPU events (fences, ring pointers, -* etc.). +* Writeback is the method by which GPU updates special pages in memory +* with the status of certain GPU events (fences, ring pointers,etc.). */ /**
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev) * * @adev: amdgpu_device pointer * - * Disables Writeback and frees the Writeback memory (all asics). + * Initialize writeback and allocates writeback memory (all asics). * Used at driver startup. * Returns 0 on success or an -error on failure.*/
--
2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 10 lines · Alex Xie
Signed-off-by Alex Xie <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev, · line 482
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-3@@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,/* * amdgpu_wb_*() -* Writeback is the the method by which the the GPU updates special pages -* in memory with the status of certain GPU events (fences, ring pointers, -* etc.). +* Writeback is the method by which GPU updates special pages in memory
You took out three instances of "the" instead of just two.
* Writeback is the method by which the GPU updates special pages in memory.
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev, · line 483
Quoted 1 line
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-0+* with the status of certain GPU events (fences, ring pointers,etc.).
And you took out a space that made it slightly more legible here.
* with the status of certain GPU events (fences, ring pointers, etc.).
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_wb_fini(struct amdgpu_device *adev) · line 509
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1*/ /** @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)* * @adev: amdgpu_device pointer * -* Disables Writeback and frees the Writeback memory (all asics). +* Initialize writeback and allocates writeback memory (all asics).
Inconsistent.
* Initializes writeback and allocates writeback memory (all asics).
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_wb_fini(struct amdgpu_device *adev) · line 512
Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0* Used at driver startup. * Returns 0 on success or an -error on failure. */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 10 lines · Alex Xie
Signed-off-by Alex Xie <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev, · line 482
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-3@@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,/* * amdgpu_wb_*() -* Writeback is the the method by which the the GPU updates special pages -* in memory with the status of certain GPU events (fences, ring pointers, -* etc.). +* Writeback is the method by which GPU updates special pages in memory
This should still say "the GPU".
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_wb_fini(struct amdgpu_device *adev) · line 509
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-1+* with the status of certain GPU events (fences, ring pointers,etc.). */ /** @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)* * @adev: amdgpu_device pointer * -* Disables Writeback and frees the Writeback memory (all asics). +* Initialize writeback and allocates writeback memory (all asics).
For consistency, this should say either "Initialize writeback and allocate writeback memory" or "Initializes writeback and allocates writeback memory".
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 042fa611-ad61-db65-2266-db9c6b6061b9-otUistvHUpPR7s880joybQ@public.gmane.org
Hi Michel,
The code change has been submitted into our internal git server.
I have a follow up commit in another email thread.
The commit fixes more errors in comments.
Thanks,
Alex Bin
________________________________
From: Michel Dänzer <[email protected]>
Sent: Monday, May 8, 2017 9:13 PM
To: Xie, AlexBin
Cc: [email protected]
Subject: Re: [PATCH] drm/amdgpu: fix errors in comments.
Quoted 10 lines · Alex Xie
Signed-off-by Alex Xie <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev, · line 482
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-3@@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,/* * amdgpu_wb_*() -* Writeback is the the method by which the the GPU updates special pages -* in memory with the status of certain GPU events (fences, ring pointers, -* etc.). +* Writeback is the method by which GPU updates special pages in memory
This should still say "the GPU".
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_wb_fini(struct amdgpu_device *adev) · line 509
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2
-1+* with the status of certain GPU events (fences, ring pointers,etc.). */ /** @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)* * @adev: amdgpu_device pointer * -* Disables Writeback and frees the Writeback memory (all asics). +* Initialize writeback and allocates writeback memory (all asics).
For consistency, this should say either "Initialize writeback and allocate writeback memory" or "Initializes writeback and allocates writeback memory".
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx