Skip to contentSkip to conversation

wil6210: Replace five seq_puts() calls by seq_putc()

PATCH In review SF Markus Elfring 3 participants 3 messages May 9, 2017

Subsystems (4)
Networking Network drivers Kernel janitors Wilocity WIL6210 wireless driver
lore
Share & tools
lore

SF Markus Elfring

author
#0 lore raw

PATCH 1/1 wil6210: Replace five seq_puts() calls by seq_putc()

From: Markus Elfring <[email protected]>
Date: Mon, 8 May 2017 22:22:04 +0200

Five single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by Markus Elfring <[email protected]>
---
 drivers/net/wireless/ath/wil6210/debugfs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/ath/wil6210/debugfs.c +5 -5
index 5648ebbd0e16..90118d286fb9 100644
@@ -76,11 +76,11 @@ static void wil_print_vring(struct seq_file *s, struct wil6210_priv *wil,
 			volatile struct vring_tx_desc *d = &vring->va[i].tx;
 
 			if ((i % 128) = 0 && (i != 0))
-				seq_puts(s, "\n");
+				seq_putc(s, '\n');
 			seq_printf(s, "%c", (d->dma.status & BIT(0)) ?
 					_s : (vring->ctx[i].skb ? _h : 'h'));
 		}
-		seq_puts(s, "\n");
+		seq_putc(s, '\n');
 	}
 	seq_puts(s, "}\n");
 }

@@ -233,7 +233,7 @@ static void wil_print_ring(struct seq_file *s, const char *prefix,
 				wil_seq_hexdump(s, databuf, len, "      : ");
 			}
 		} else {
-			seq_puts(s, "\n");
+			seq_putc(s, '\n');
 		}
 	}
  out:

@@ -1366,7 +1366,7 @@ static void wil_print_rxtid_crypto(struct seq_file *s, int tid,
 		seq_printf(s, " [%i%s]%6phN", i, cc->key_set ? "+" : "-",
 			   cc->pn);
 	}
-	seq_puts(s, "\n");
+	seq_putc(s, '\n');
 }
 
 static int wil_sta_debugfs_show(struct seq_file *s, void *data)

@@ -1423,7 +1423,7 @@ __acquires(&p->tid_rx_lock) __releases(&p->tid_rx_lock)
 			     mcs++)
 				seq_printf(s, " %lld",
 					   p->stats.rx_per_mcs[mcs]);
-			seq_puts(s, "\n");
+			seq_putc(s, '\n');
 		}
 	}
Signature · 1 line
2.12.2
#1 lore raw
Quoted 5 lines · SF Markus Elfring

From: Markus Elfring <[email protected]>
Date: Mon, 8 May 2017 22:22:04 +0200

Five single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc".

Please stop, this isn't really an issue worth worrying about.

johannes

#2 lore raw
In reply to SF Markus Elfring
Quoted 7 lines · SF Markus Elfring

From: Markus Elfring <[email protected]>
Date: Mon, 8 May 2017 22:22:04 +0200

Five single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

There is no _issue_ at all here, only a matter of taste.

printf("\n") or putchar('\n') in some slow path is really not that interesting.