Skip to contentSkip to conversation

Patch "phy: qcom-usb-hs: Add depends on EXTCON" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message May 9, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

phy: qcom-usb-hs: Add depends on EXTCON

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
phy-qcom-usb-hs-add-depends-on-extcon.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1a09b6a7c10e22c489a8b212dd6862b1fd9674ad Mon Sep 17 00:00:00 2001

From: Stephen Boyd <[email protected]>
Date: Thu, 9 Mar 2017 13:45:44 +0530
Subject: phy: qcom-usb-hs: Add depends on EXTCON

From: Stephen Boyd <[email protected]>

commit 1a09b6a7c10e22c489a8b212dd6862b1fd9674ad upstream.

We get the following compile errors if EXTCON is enabled as a module but this driver is builtin:

drivers/built-in.o: In function `qcom_usb_hs_phy_power_off':
phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to extcon_unregister_notifier' drivers/built-in.o: In function qcom_usb_hs_phy_probe':
phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to extcon_get_edev_by_phandle' drivers/built-in.o: In function qcom_usb_hs_phy_power_on':
phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to extcon_get_state' phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to extcon_register_notifier'

so let's mark this as needing to follow the modular status of the extcon framework.

Fixes 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy")
---
 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/phy/Kconfig +1 -0
@@ -456,6 +456,7 @@ config PHY_QCOM_UFS
 config PHY_TUSB1210
 	tristate "TI TUSB1210 ULPI PHY module"
 	depends on USB_ULPI_BUS
+	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	select GENERIC_PHY
 	help
 	  Support for TI TUSB1210 USB ULPI PHY.

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/usb-chipidea-only-read-write-otgsc-from-one-place.patch queue-4.9/phy-qcom-usb-hs-add-depends-on-extcon.patch queue-4.9/usb-chipidea-handle-extcon-events-properly.patch