Skip to contentSkip to conversation

Patch "power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message May 9, 2017 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
power-supply-bq24190_charger-fix-irq-trigger-to-irqf_trigger_falling.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 767eee362fd72bb2ca44cc80419ca4b38c6d8369 Mon Sep 17 00:00:00 2001

From: Liam Breck <[email protected]>
Date: Wed, 18 Jan 2017 09:26:48 -0800
Subject: power: supply: bq24190_charger: Fix irq trigger to IRQF_TRIGGER_FALLING

From: Liam Breck <[email protected]>

commit 767eee362fd72bb2ca44cc80419ca4b38c6d8369 upstream.

The interrupt signal is TRIGGER_FALLING. This is is specified in the data sheet PIN FUNCTIONS: "The INT pin sends active low, 256us pulse to host to report charger device status and fault."

Also the direction can be seen in the data sheet Figure 37 "BQ24190 with D+/D- Detection and USB On-The-Go (OTG)" which shows a 10k pull-up resistor installed for the sample configurations.

Fixes d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
---
 drivers/power/bq24190_charger.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/bq24190_charger.c +1 -1
@@ -1400,7 +1400,7 @@ static int bq24190_probe(struct i2c_clie
 
 	ret = devm_request_threaded_irq(dev, bdi->irq, NULL,
 			bq24190_irq_handler_thread,
-			IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+			IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 			"bq24190-charger", bdi);
 	if (ret < 0) {
 		dev_err(dev, "Can't set up irq handler\n");

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/power-supply-bq24190_charger-call-set_mode_host-on-pm_resume.patch queue-3.18/power-supply-bq24190_charger-fix-irq-trigger-to-irqf_trigger_falling.patch