drm/i915: Show dmc debug registers on Kabylake
Subsystems (2)
PATCH 1/1 drm/i915: Show dmc debug registers on Kabylake
The assumption is that the registers offsets are identical as with skl. Also all the published kbl firmwares support the debug registers. So let kbl show the debug counts.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100975
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +2 -1
@@ -2853,7 +2853,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused)seq_printf (m,"version: %d.%d\n" ,CSR_VERSION_MAJOR (csr->version),CSR_VERSION_MINOR (csr->version)); -if (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 )) { +if (IS_KABYLAKE (dev_priv) || + (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 ))) {seq_printf (m,"DC3 -> DC5 count: %d\n" ,I915_READ (SKL_CSR_DC3_DC5_COUNT )); seq_printf(m, "DC5 -> DC6 count: %d\n",
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Mika Kuoppala
The assumption is that the registers offsets are identical as with skl. Also all the published kbl firmwares support the debug registers. So let kbl show the debug counts.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100975
Cc Imre Deak <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
Quoted 21 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_debugfs.c +2
-1@@ -2853,7 +2853,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused)seq_printf (m,"version: %d.%d\n" ,CSR_VERSION_MAJOR (csr->version),CSR_VERSION_MINOR (csr->version)); -if (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 )) { +if (IS_KABYLAKE (dev_priv) || + (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 ))) {seq_printf (m,"DC3 -> DC5 count: %d\n" ,I915_READ (SKL_CSR_DC3_DC5_COUNT )); seq_printf(m, "DC5 -> DC6 count: %d\n",Signature · 1 line
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Imre Deak
Quoted 8 lines · Mika Kuoppala
The assumption is that the registers offsets are identical as with skl. Also all the published kbl firmwares support the debug registers. So let kbl show the debug counts.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100975
Cc Imre Deak <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>Reviewed-by Imre Deak <[email protected]>
Pushed. Thanks for review!
-Mika
Quoted 13 lines
Quoted 13 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_debugfs.c +0
-0@@ -2853,7 +2853,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused)seq_printf (m,"version: %d.%d\n" ,CSR_VERSION_MAJOR (csr->version),CSR_VERSION_MINOR (csr->version));
Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/i915_debugfs.c +2
-1-if (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 )) { +if (IS_KABYLAKE (dev_priv) || + (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 ))) {seq_printf (m,"DC3 -> DC5 count: %d\n" ,I915_READ (SKL_CSR_DC3_DC5_COUNT )); seq_printf(m, "DC5 -> DC6 count: %d\n",Signature · 1 line
2.7.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
A message that is not in the archive (sent off-list or not yet received): 20170510020358.GA2292@nc-int
Quoted 13 lines · Nathan Ciobanu
Quoted 12 lines · Mika Kuoppala
Quoted 10 lines · Imre Deak
Quoted 8 lines · Mika Kuoppala
The assumption is that the registers offsets are identical as with skl. Also all the published kbl firmwares support the debug registers. So let kbl show the debug counts.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100975
Cc Imre Deak <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Reviewed-by Imre Deak <[email protected]>Pushed. Thanks for review!
-MikaMika, the initial version of the KBL DMC firmware is 1.01 so because
CSR_VERSIONis checking for >1.6 this will
I am quite certain that it checks the version only with skl. -Mika
Quoted 31 lines
still not work. See Rodrigo's original patch that added it to linux-firmware:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=9facc31d772a3ed399760d2168d644f9de84d6dbQuoted 28 lines
Quoted 15 lines
Quoted 15 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_debugfs.c +0
-0@@ -2853,7 +2853,8 @@ static int i915_dmc_info(struct seq_file *m, void *unused)seq_printf (m,"version: %d.%d\n" ,CSR_VERSION_MAJOR (csr->version),CSR_VERSION_MINOR (csr->version));Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/i915_debugfs.c +2
-1-if (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 )) { +if (IS_KABYLAKE (dev_priv) || + (IS_SKYLAKE (dev_priv) && csr->version >=CSR_VERSION (1 ,6 ))) {seq_printf (m,"DC3 -> DC5 count: %d\n" ,I915_READ (SKL_CSR_DC3_DC5_COUNT )); seq_printf(m, "DC5 -> DC6 count: %d\n",Signature · 1 line
2.7.4_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Show dmc debug registers on Kabylake
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915: Show dmc debug registers on Kabylake
URL : https://patchwork.freedesktop.org/series/24171/
State : success
== Summary ==
Series 24171v1 drm/i915: Show dmc debug registers on Kabylake
https://patchwork.freedesktop.org/api/1.0/series/24171/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-kbl-7560u) fdo#100125
Test kms_flip:
Subgroup basic-flip-vs-modeset:
dmesg-warn -> PASS (fi-byt-j1900) fdo#100652fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#100652 https://bugs.freedesktop.org/show_bug.cgi?id=100652
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:429s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:432s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:576s fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time:543s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:487s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:480s fi-elk-e7500 total:278 pass:229 dwarn:0 dfail:0 fail:0 skip:49 time:409s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:407s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:416s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:480s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:469s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:456s fi-kbl-7560u total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:577s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:462s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time:572s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:457s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:497s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:434s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:524s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:401s
fi-bxt-j4205 failed to collect. IGT log at Patchwork_4646/fi-bxt-j4205/igt.log
f558b185c57202d90bdb9059f3d446956cbae133 drm-tip: 2017y-05m-08d-16h-35m-28s UTC integration manifest c085756 drm/i915: Show dmc debug registers on Kabylake
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4646/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx