cpufreq / CPPC: Initialize policy->min to lowest nonlinear performance
PATCH 1/1 cpufreq / CPPC: Initialize policy->min to lowest nonlinear performance
Description of Lowest Perfomance in ACPI 6.1 specification states:
"Lowest Performance is the absolute lowest performance level of the platform. Selecting a performance level lower than the lowest nonlinear performance level may actually cause an efficiency penalty, but should reduce the instantaneous power consumption of the processor. In traditional terms, this represents the T-state range of performance levels."
Set the default value of policy->min to Lowest Nonlinear Performance to avoid any potential efficiency penalty.
--- drivers/cpufreq/cppc_cpufreq.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)
drivers/cpufreq/cppc_cpufreq.c +16 -3
@@ -144,10 +144,23 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) cppc_dmi_max_khz =cppc_get_dmi_max_khz (); - policy->min = cpu->perf_caps.lowest_perf * cppc_dmi_max_khz / cpu->perf_caps.highest_perf; +/* +* Set min to lowest nonlinear perf to avoid any efficiency penalty (see +* Section 8.4.7.1.1.5 of ACPI 6.1 spec) +*/ + policy->min = cpu->perf_caps.lowest_nonlinear_perf * cppc_dmi_max_khz / + cpu->perf_caps.highest_perf; policy->max = cppc_dmi_max_khz; - policy->cpuinfo.min_freq = policy->min; - policy->cpuinfo.max_freq = policy->max; + +/* +* Set cpuinfo.min_freq to Lowest to make the full range of performance +* available if userspace wants to use any perf between lowest & lowest +* nonlinear perf +*/ + policy->cpuinfo.min_freq = cpu->perf_caps.lowest_perf * cppc_dmi_max_khz / + cpu->perf_caps.highest_perf; + policy->cpuinfo.max_freq = cppc_dmi_max_khz; + policy->cpuinfo.transition_latency =cppc_get_transition_latency (cpu_num); policy->shared_type = cpu->shared_type;
Signature · 3 lines
Qualcomm Datacenter Technologies on behalf of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 36 lines · Prashanth Prakash
Description of Lowest Perfomance in ACPI 6.1 specification states:
"Lowest Performance is the absolute lowest performance level of the platform. Selecting a performance level lower than the lowest nonlinear performance level may actually cause an efficiency penalty, but should reduce the instantaneous power consumption of the processor. In traditional terms, this represents the T-state range of performance levels."Set the default value of
policy->minto Lowest Nonlinear Performance to avoid any potential efficiency penalty.Signed-off-by Prashanth Prakash <[email protected]>--- drivers/cpufreq/cppc_cpufreq.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)drivers/cpufreq/cppc_cpufreq.c +8
-3@@ -144,10 +144,23 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) cppc_dmi_max_khz =cppc_get_dmi_max_khz (); - policy->min = cpu->perf_caps.lowest_perf * cppc_dmi_max_khz / cpu->perf_caps.highest_perf; +/* +* Set min to lowest nonlinear perf to avoid any efficiency penalty (see +* Section 8.4.7.1.1.5 of ACPI 6.1 spec) +*/ + policy->min = cpu->perf_caps.lowest_nonlinear_perf * cppc_dmi_max_khz / + cpu->perf_caps.highest_perf; policy->max = cppc_dmi_max_khz; - policy->cpuinfo.min_freq = policy->min; - policy->cpuinfo.max_freq = policy->max; + +/*
drivers/cpufreq/cppc_cpufreq.c static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 165
Quoted 10 lines
drivers/cpufreq/cppc_cpufreq.c +8
-0+* Set cpuinfo.min_freq to Lowest to make the full range of performance +* available if userspace wants to use any perf between lowest & lowest +* nonlinear perf +*/ + policy->cpuinfo.min_freq = cpu->perf_caps.lowest_perf * cppc_dmi_max_khz / + cpu->perf_caps.highest_perf; + policy->cpuinfo.max_freq = cppc_dmi_max_khz; + policy->cpuinfo.transition_latency =cppc_get_transition_latency (cpu_num); policy->shared_type = cpu->shared_type;
Signature · 1 line
viresh
Quoted 8 lines · Prashanth Prakash
Description of Lowest Perfomance in ACPI 6.1 specification states:
"Lowest Performance is the absolute lowest performance level of the platform. Selecting a performance level lower than the lowest nonlinear performance level may actually cause an efficiency penalty, but should reduce the instantaneous power consumption of the processor. In traditional terms, this represents the T-state range of performance levels."
Quoted 4 lines
Set the default value of
policy->minto Lowest Nonlinear Performance to avoid any potential efficiency penalty.Signed-off-by Prashanth Prakash <[email protected]>
Thanks,
Alexey