Skip to contentSkip to conversation

Patch "staging: gdm724x: gdm_mux: fix use-after-free on module unload" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message May 16, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

staging: gdm724x: gdm_mux: fix use-after-free on module unload

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
staging-gdm724x-gdm_mux-fix-use-after-free-on-module-unload.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b58f45c8fc301fe83ee28cad3e64686c19e78f1c Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Wed, 26 Apr 2017 12:23:04 +0200
Subject: staging: gdm724x: gdm_mux: fix use-after-free on module unload

From: Johan Hovold <[email protected]>

commit b58f45c8fc301fe83ee28cad3e64686c19e78f1c upstream.

Make sure to deregister the USB driver before releasing the tty driver to avoid use-after-free in the USB disconnect callback where the tty devices are deregistered.

Fixes 61e121047645 ("staging: gdm7240: adding LTE USB driver")
Cc Won Kang <[email protected]>
---
 drivers/staging/gdm724x/gdm_mux.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gdm724x/gdm_mux.c +1 -2
@@ -664,9 +664,8 @@ static int __init gdm_usb_mux_init(void)
 
 static void __exit gdm_usb_mux_exit(void)
 {
-	unregister_lte_tty_driver();
-
 	usb_deregister(&gdm_mux_driver);
+	unregister_lte_tty_driver();
 }
 
 module_init(gdm_usb_mux_init);

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/usb-serial-ftdi_sio-add-device-id-for-microsemi-arrow-sf2plus-dev-kit.patch queue-4.11/staging-gdm724x-gdm_mux-fix-use-after-free-on-module-unload.patch