Skip to contentSkip to conversation

usb: typec: Defer checking of valid power role swap to low level drivers

PATCH In review Badhri Jagan Sridharan 5 participants 16 messages May 17, 2017 – May 19, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: typec: Defer checking of valid power role swap to low level drivers

With this CL the lower level drivers are reponsible to check and make sure that the role swap can be performed.

This facilitates the lower level driver to attempt to perform role swap through initial connection process.

Quoting from the Type-C specification release(page 24), role swaps are not limited to devices that only support PD.

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

---
 Documentation/ABI/testing/sysfs-class-typec |  7 +++++--
 drivers/usb/typec/typec.c                   | 10 ----------
 2 files changed, 5 insertions(+), 12 deletions(-)
Documentation/ABI/testing/sysfs-class-typec +5 -2
index d4a3d23eb09c..ba4ca684adb2 100644
@@ -20,13 +20,16 @@ Date:		April 2017
 Contact:	Heikki Krogerus <[email protected]>
 Description:
 		The supported power roles. This attribute can be used to request
-		power role swap on the port when the port supports USB Power
-		Delivery. Swapping is supported as synchronous operation, so
+		power role swap. Swapping is supported as synchronous operation, so
 		write(2) to the attribute will not return until the operation
 		has finished. The attribute is notified about role changes so
 		that poll(2) on the attribute wakes up. Change on the role will
 		also generate uevent KOBJ_CHANGE. The current role is show in
 		brackets, for example "[source] sink" when in source mode.
+		When both the port and the port-partner supports USB Power
+		Delivery, the PR_SWAP command is used to perform the role swap.
+		Otherwise, the port roles would be re-resolved by forcing
+		a disconnect and reconnect.
 
 		Valid values: source, sink
 
drivers/usb/typec/typec.c +0 -10
index 89e540bb7ff3..fd2d661665fa 100644
@@ -887,21 +887,11 @@ static ssize_t power_role_store(struct device *dev,
 	struct typec_port *port = to_typec_port(dev);
 	int ret = size;
 
-	if (!port->cap->pd_revision) {
-		dev_dbg(dev, "USB Power Delivery not supported\n");
-		return -EOPNOTSUPP;
-	}
-
 	if (!port->cap->pr_set) {
 		dev_dbg(dev, "power role swapping not supported\n");
 		return -EOPNOTSUPP;
 	}
 
-	if (port->pwr_opmode != TYPEC_PWR_MODE_PD) {
-		dev_dbg(dev, "partner unable to swap power role\n");
-		return -EIO;
-	}
-
 	ret = sysfs_match_string(typec_roles, buf);
 	if (ret < 0)
 		return ret;
Signature · 1 line
2.13.0.303.g4ebf302169-goog
#1 lore raw

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 6 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

Regards
Oliver

#2 lore raw
Quoted 12 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 6 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

That seems to be a harsh and not very user friendly reading of the specification.

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Thanks,
Guenter

maintainer
#3 lore raw

Hi guys,

Quoted 18 lines · Guenter Roeck
Quoted 12 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 6 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

Quoted 5 lines

That seems to be a harsh and not very user friendly reading of the specification.

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

I agree. But I have to point out that at least with UCSI, the role swapping is usually not possible without USB PD connection.

So what I'm trying to say is that we can't really promise that role swapping will ever be possible in all cases without PD, which may mean different behavior depending on the platform. I don't know if that is a huge problem.

How predictable do we want this interface to function with role swapping?

Thanks,

Signature · 1 line
heikki
#4 lore raw
Quoted 30 lines · Heikki Krogerus

Hi guys,

Quoted 18 lines · Guenter Roeck
Quoted 12 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 6 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

Quoted 5 lines

That seems to be a harsh and not very user friendly reading of the specification.

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

I agree. But I have to point out that at least with UCSI, the role swapping is usually not possible without USB PD connection.

Quoted 8 lines

So what I'm trying to say is that we can't really promise that role swapping will ever be possible in all cases without PD, which may mean different behavior depending on the platform. I don't know if that is a huge problem.

How predictable do we want this interface to function with role swapping?

We can only do as good as we can, but we should not preclude it either. PR_SWAP and other swap operations fail a lot in practice with many dongles, just because the PD protocol implementation isn't always stable. So even that won't be predictable for some time to come.

As Badhri pointed out earlier, at least some low cost devices won't support PD. Since we are talking about high volume products, we _have_ to make it as user friendly as we can, if for nothing else to reduce the number of customer service calls, repeated bug filings, and, last but not least, to avoid bad press.

Thanks,
Guenter

maintainer
#5 lore raw
Quoted 45 lines · Guenter Roeck
Quoted 30 lines · Heikki Krogerus

Hi guys,

Quoted 18 lines · Guenter Roeck
Quoted 12 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 6 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

Quoted 5 lines

That seems to be a harsh and not very user friendly reading of the specification.

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

I agree. But I have to point out that at least with UCSI, the role swapping is usually not possible without USB PD connection.

Quoted 8 lines

So what I'm trying to say is that we can't really promise that role swapping will ever be possible in all cases without PD, which may mean different behavior depending on the platform. I don't know if that is a huge problem.

How predictable do we want this interface to function with role swapping?

We can only do as good as we can, but we should not preclude it either. PR_SWAP and other swap operations fail a lot in practice with many dongles, just because the PD protocol implementation isn't always stable. So even that won't be predictable for some time to come.

Quoted 4 lines

As Badhri pointed out earlier, at least some low cost devices won't support PD. Since we are talking about high volume products, we _have_ to make it as user friendly as we can, if for nothing else to reduce the number of customer service calls, repeated bug filings, and, last but not least, to avoid bad press.

OK. So I think we just need to explain in the documentation that there are no guarantees with role swapping.

Thanks,

Signature · 1 line
heikki
#6 lore raw

For non-pd case, Should I instead say that the low level driver might optionally choose to perform a best case effort of performing a role swap by disconnect and reconnect ?

Does the following description look better ?

Description:
The supported power roles. This attribute can be used to request power role swap. Swapping is supported as synchronous
operation, so
write(2) to the attribute will not return until the operation has finished. The attribute is notified about role changes so that poll(2) on the attribute wakes up. Change on the role will also generate uevent KOBJ_CHANGE. The current role is show in brackets, for example "[source] sink" when in source mode. When both the port and the port-partner supports USB Power Delivery, the PR_SWAP command is used to perform the role swap. For non-pd case, the low level driver might optionally perform a best effort approach to swap port roles by forcing a disconnect and reconnect.

Thanks,
Badhri

Quoted 60 lines · Heikki Krogerus
Quoted 45 lines · Guenter Roeck
Quoted 30 lines · Heikki Krogerus

Hi guys,

Quoted 18 lines · Guenter Roeck
Quoted 12 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 6 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

Quoted 5 lines

That seems to be a harsh and not very user friendly reading of the specification.

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

I agree. But I have to point out that at least with UCSI, the role swapping is usually not possible without USB PD connection.

Quoted 8 lines

So what I'm trying to say is that we can't really promise that role swapping will ever be possible in all cases without PD, which may mean different behavior depending on the platform. I don't know if that is a huge problem.

How predictable do we want this interface to function with role swapping?

We can only do as good as we can, but we should not preclude it either. PR_SWAP and other swap operations fail a lot in practice with many dongles, just because the PD protocol implementation isn't always stable. So even that won't be predictable for some time to come.

Quoted 4 lines

As Badhri pointed out earlier, at least some low cost devices won't support PD. Since we are talking about high volume products, we _have_ to make it as user friendly as we can, if for nothing else to reduce the number of customer service calls, repeated bug filings, and, last but not least, to avoid bad press.

OK. So I think we just need to explain in the documentation that there are no guarantees with role swapping.

Thanks,

--
heikki

#7 lore raw
In reply to Guenter Roeck

Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck:

Quoted 20 lines · Oliver Neukum
Quoted 14 lines

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 7 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

Quoted 5 lines

That seems to be a harsh and not very user friendly reading of the specification.

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Data role, no question, you are right.
Power role is a different question. A switch of power role with PD should not lead to a disconnect. Any other method might. So equating them does not look like a good idea.

Regards
Oliver

#8 lore raw
Quoted 23 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck:

Quoted 22 lines · Oliver Neukum
Quoted 14 lines

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 7 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

That seems to be a harsh and not very user friendly reading of the specification.

Quoted 9 lines
Quoted 3 lines

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Data role, no question, you are right.
Power role is a different question. A switch of power role with PD should not lead to a disconnect. Any other method might. So equating them does not look like a good idea.

Not really sure I can follow. If a partner does not support PD, there is no real distinction between data role and power role, or am I missing something ?

Are you saying that, if a partner does not support PD, user space should request a data role swap instead, and that this would be acceptable for you ?

I don't really understand the difference - a data role swap doesn't cause a disconnect either if the partner supports PD, and it would still result in a disconnect/reconnect sequence if the partner does not support PD - but if it works for you, fine with me.

Badhri, would that work for us ?

Thanks,
Guenter

#9 lore raw
Quoted 40 lines · Guenter Roeck
Quoted 23 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck:

Quoted 22 lines · Oliver Neukum
Quoted 14 lines

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 7 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

That seems to be a harsh and not very user friendly reading of the specification.

Quoted 9 lines
Quoted 3 lines

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Data role, no question, you are right.
Power role is a different question. A switch of power role with PD should not lead to a disconnect. Any other method might. So equating them does not look like a good idea.

Not really sure I can follow. If a partner does not support PD, there is no real distinction between data role and power role, or am I missing something ?

Are you saying that, if a partner does not support PD, user space should request a data role swap instead, and that this would be acceptable for you ?

Quoted 6 lines

I don't really understand the difference - a data role swap doesn't cause a disconnect either if the partner supports PD, and it would still result in a disconnect/reconnect sequence if the partner does not support PD - but if it works for you, fine with me.

Badhri, would that work for us ?

Yes Geunter that should work as well. Requesting non-pd role swap either through current_power_role or current_data_role is virtually the same.

Quoted 3 lines

Thanks,
Guenter

#10 lore raw

Not Sure whether my previous response was sent properly. So re-sending.

Quoted 41 lines · Badhri Jagan Sridharan
Quoted 40 lines · Guenter Roeck
Quoted 23 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck:

Quoted 22 lines · Oliver Neukum
Quoted 14 lines

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 7 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

That seems to be a harsh and not very user friendly reading of the specification.

Quoted 9 lines
Quoted 3 lines

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Data role, no question, you are right.
Power role is a different question. A switch of power role with PD should not lead to a disconnect. Any other method might. So equating them does not look like a good idea.

Not really sure I can follow. If a partner does not support PD, there is no real distinction between data role and power role, or am I missing something ?

Are you saying that, if a partner does not support PD, user space should request a data role swap instead, and that this would be acceptable for you ?

Quoted 6 lines
Quoted 6 lines

I don't really understand the difference - a data role swap doesn't cause a disconnect either if the partner supports PD, and it would still result in a disconnect/reconnect sequence if the partner does not support PD - but if it works for you, fine with me.

Badhri, would that work for us ?

Yes Geunter that should work as well. Requesting non-pd role swap either through current_power_role or current_data_role is virtually the same.

Quoted 7 lines

Yes Geunter that should work as well. Requesting non-pd role swap either through current_power_role or current_data_role is virtually the same.

Quoted 3 lines

Thanks,
Guenter

maintainer
#11 lore raw
In reply to Badhri Jagan Sridharan
Quoted 46 lines · Badhri Jagan Sridharan
Quoted 45 lines · Guenter Roeck
Quoted 23 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck:

Quoted 22 lines · Oliver Neukum
Quoted 14 lines

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 7 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

That seems to be a harsh and not very user friendly reading of the specification.

Quoted 9 lines
Quoted 3 lines

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Data role, no question, you are right.
Power role is a different question. A switch of power role with PD should not lead to a disconnect. Any other method might. So equating them does not look like a good idea.

Not really sure I can follow. If a partner does not support PD, there is no real distinction between data role and power role, or am I missing something ?

Are you saying that, if a partner does not support PD, user space should request a data role swap instead, and that this would be acceptable for you ?

I don't really understand the difference - a data role swap doesn't cause a disconnect either if the partner supports PD, and it would still result in a disconnect/reconnect sequence if the partner does not support PD - but if it works for you, fine with me.

Quoted 4 lines
Quoted 1 line

Badhri, would that work for us ?

Yes Geunter that should work as well. Requesting non-pd role swap either through current_power_role or current_data_role is virtually the same.

So if I understood this correctly, we'll skip this change, right?

Thanks,

Signature · 1 line
heikki
#12 lore raw
Quoted 47 lines · Heikki Krogerus
Quoted 46 lines · Badhri Jagan Sridharan
Quoted 45 lines · Guenter Roeck
Quoted 23 lines · Oliver Neukum

Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck:

Quoted 22 lines · Oliver Neukum
Quoted 14 lines

Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan Sridharan:

Hi,

Quoted 7 lines

"Two independent set of mechanisms are defined to allow a USB Type-C DRP to functionally swap power and data roles. When USB PD is supported, power and data role swapping is performed as a subsequent step following the initial connection process. For non-PD implementations, power/data role swapping can optionally be dealt with as part of the initial connection process."

Quoted 4 lines

Well, as I read it, without PD once a connection is established, you are stuck with your role. So it seems to me that blocking a later attempt to change it makes sense.

That seems to be a harsh and not very user friendly reading of the specification.

Quoted 9 lines
Quoted 3 lines

I would argue that the user doesn't care if the partner supports PD or not when selecting a role, and I would prefer to provide an implementation which is as user friendly as possible.

Data role, no question, you are right.
Power role is a different question. A switch of power role with PD should not lead to a disconnect. Any other method might. So equating them does not look like a good idea.

Not really sure I can follow. If a partner does not support PD, there is no real distinction between data role and power role, or am I missing something ?

Are you saying that, if a partner does not support PD, user space should request a data role swap instead, and that this would be acceptable for you ?

I don't really understand the difference - a data role swap doesn't cause a disconnect either if the partner supports PD, and it would still result in a disconnect/reconnect sequence if the partner does not support PD - but if it works for you, fine with me.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Badhri, would that work for us ?

Yes Geunter that should work as well. Requesting non-pd role swap either through current_power_role or current_data_role is virtually the same.

So if I understood this correctly, we'll skip this change, right?

Yes.

Thanks,
Guenter

#13 lore raw
In reply to Badhri Jagan Sridharan

Am Donnerstag, den 18.05.2017, 14:08 -0700 schrieb Badhri Jagan Sridharan:

Quoted 4 lines
Quoted 1 line

Badhri, would that work for us ?

Yes Geunter that should work as well. Requesting non-pd role swap either through current_power_role or current_data_role is virtually the same.

Yes and that is the issue.
If you can do PD and swap power roles, power roles will be swapped and data connection and driver assignments stay put. However without PD drivers will be unbound. That means that user space must be made aware that requesting a power role change will have side effects.

Regards
Oliver

#15 lore raw
Quoted 2 lines · Greg Kroah-Hartman
Quoted 1 line · Badhri Jagan Sridharan

With this CL the lower level drivers are reponsible to check and make sure

responsible

Quoted 4 lines
Quoted 1 line

that the role swap can be performed.

What is a "CL"?

Too much Gerrit. "Change List". Took me a while to understand what people were talking about when talking about CLs.

Guenter