Skip to contentSkip to conversation

drm/i915/dp: Clear the compliance test data for each long pulse

PATCH New Manasi Navare 2 participants 2 messages May 19, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/dp: Clear the compliance test data for each long pulse

Each time we handle the long pulse, we check for the test request interrupt and populate the compliance data in the intel_dp structure. So the previously populated data becomes stale. Hence we need to clear the compliance data during each long pulse handling.

Not clearing the compliance test data for each long pulse causes compliance failures since each test starts with a new long pulse and re populates the compliance test data.

Cc Jani Nikula <[email protected]>
Cc Ville Syrjala <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +4 -2
index 2dc87a5..8a21181 100644
@@ -4646,9 +4646,11 @@ intel_dp_long_pulse(struct intel_connector *intel_connector)
 	else
 		status = connector_status_disconnected;
 
+	/* In either case, clear the stale compliance test data since this
+	 * is a new long pulse handling, could be a new test request.
+	 */
+	memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
 	if (status == connector_status_disconnected) {
-		memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
-
 		if (intel_dp->is_mst) {
 			DRM_DEBUG_KMS("MST device may have disappeared %d vs %d\n",
 				      intel_dp->is_mst,
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/dp: Clear the compliance test data for each long pulse

== Series Details ==

== Series Details ==

Series: drm/i915/dp: Clear the compliance test data for each long pulse
URL : https://patchwork.freedesktop.org/series/24666/
State : success

== Summary ==

Series 24666v1 drm/i915/dp: Clear the compliance test data for each long pulse
https://patchwork.freedesktop.org/api/1.0/series/24666/revisions/1/mbox/

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-b:
                fail       -> PASS       (fi-skl-6700k)
fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:441s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:434s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:584s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:514s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:496s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:490s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:417s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:410s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:422s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:507s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:466s
fi-kbl-7500u     total:278  pass:255  dwarn:5   dfail:0   fail:0   skip:18  time:460s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:457s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:583s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:464s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:506s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:436s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:534s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:408s

2b6ec1764a34b8df3b15e10660a608e140ac05cb drm-tip: 2017y-05m-18d-21h-18m-07s UTC integration manifest 861293d drm/i915/dp: Clear the compliance test data for each long pulse

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4752/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx