Patch "tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tpm_tis_spi-remove-limitation-of-transfers-to-max_spi_framesize-bytes.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
591e48c26ced7c455751eef27fb5963e902c2137Mon Sep 17 00:00:00 2001
From: Peter Huewe <[email protected]>
Date: Thu, 2 Mar 2017 13:03:14 +0000
Subject: tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes
From: Peter Huewe <[email protected]>
commit 591e48c26ced7c455751eef27fb5963e902c2137 upstream.
Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper layers, as tpm_tis has no such limitation. Add a loop to hide that limitation.
v2: Moved scope of spi_message to the top as requested by Jarkko
--- drivers/char/tpm/tpm_tis_spi.c | 109 ++++++++++++++++++++++------------------- 1 file changed, 59 insertions(+), 50 deletions(-)
drivers/char/tpm/tpm_tis_spi.c +59 -50
@@ -61,67 +61,76 @@ static int tpm_tis_spi_transfer(struct t u8 *buffer, u8 direction) {struct tpm_tis_spi_phy *phy =to_tpm_tis_spi_phy (data); -int ret, i; +int ret =0 ; +int i;struct spi_message m; -struct spi_transfer spi_xfer = { - .tx_buf = phy->tx_buf, - .rx_buf = phy->rx_buf, - .len =4 , - .cs_change =1 , - }; - -if (len >MAX_SPI_FRAMESIZE ) -return -ENOMEM ; - - phy->tx_buf[0 ] = direction | (len -1 ); - phy->tx_buf[1 ] =0xd4 ; - phy->tx_buf[2 ] = addr >>8 ; - phy->tx_buf[3 ] = addr; - -spi_message_init (&m); -spi_message_add_tail (&spi_xfer, &m); +struct spi_transfer spi_xfer; +u8 transfer_len;spi_bus_lock (phy->spi_device->master); - ret =spi_sync_locked (phy->spi_device, &m); -if (ret <0 ) - goto exit; - -if ((phy->rx_buf[3 ] &0x01 ) ==0 ) { -// handle SPI wait states - phy->tx_buf[0 ] =0 ; - -for (i =0 ; i <TPM_RETRY ; i++) { - spi_xfer.len =1 ; -spi_message_init (&m); -spi_message_add_tail (&spi_xfer, &m); - ret =spi_sync_locked (phy->spi_device, &m); -if (ret <0 ) + +while (len) { + transfer_len =min_t (u16, len,MAX_SPI_FRAMESIZE ); + + phy->tx_buf[0 ] = direction | (transfer_len -1 ); + phy->tx_buf[1 ] =0xd4 ; + phy->tx_buf[2 ] = addr >>8 ; + phy->tx_buf[3 ] = addr; + +memset (&spi_xfer,0 ,sizeof (spi_xfer)); + spi_xfer.tx_buf = phy->tx_buf; + spi_xfer.rx_buf = phy->rx_buf; + spi_xfer.len =4 ; + spi_xfer.cs_change =1 ; + +spi_message_init (&m); +spi_message_add_tail (&spi_xfer, &m); + ret =spi_sync_locked (phy->spi_device, &m); +if (ret <0 ) + goto exit; + +if ((phy->rx_buf[3 ] &0x01 ) ==0 ) { +// handle SPI wait states + phy->tx_buf[0 ] =0 ; + +for (i =0 ; i <TPM_RETRY ; i++) { + spi_xfer.len =1 ; +spi_message_init (&m); +spi_message_add_tail (&spi_xfer, &m); + ret =spi_sync_locked (phy->spi_device, &m); +if (ret <0 ) + goto exit; +if (phy->rx_buf[0 ] &0x01 ) +break ; + } + +if (i ==TPM_RETRY ) { + ret = -ETIMEDOUT ; goto exit; -if (phy->rx_buf[0 ] &0x01 ) -break ; + } } -if (i ==TPM_RETRY ) { - ret = -ETIMEDOUT ; - goto exit; + spi_xfer.cs_change =0 ; + spi_xfer.len = transfer_len; + +if (direction) { + spi_xfer.tx_buf =NULL ; + spi_xfer.rx_buf = buffer; + }else { + spi_xfer.tx_buf = buffer; + spi_xfer.rx_buf =NULL ; } - } - spi_xfer.cs_change =0 ; - spi_xfer.len = len; +spi_message_init (&m); +spi_message_add_tail (&spi_xfer, &m); + ret =spi_sync_locked (phy->spi_device, &m); +if (ret <0 ) + goto exit; -if (direction) { - spi_xfer.tx_buf =NULL ; - spi_xfer.rx_buf = buffer; - }else { - spi_xfer.tx_buf = buffer; - spi_xfer.rx_buf =NULL ; + len -= transfer_len; + buffer += transfer_len; } -spi_message_init (&m); -spi_message_add_tail (&spi_xfer, &m); - ret =spi_sync_locked (phy->spi_device, &m); - exit:spi_bus_unlock (phy->spi_device->master);return ret;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/tpm_tis_spi-abort-transfer-when-too-many-wait-states-are-signaled.patch queue-4.9/tpm_tis_spi-remove-limitation-of-transfers-to-max_spi_framesize-bytes.patch queue-4.9/tpm_tis_core-choose-appropriate-timeout-for-reading-burstcount.patch queue-4.9/tpm_tis_spi-add-small-delay-after-last-transfer.patch queue-4.9/tpm_tis_spi-check-correct-byte-for-wait-state-indicator.patch queue-4.9/tpm_tis_spi-use-single-function-to-transfer-data.patch