Skip to contentSkip to conversation

Patch "USB: serial: io_ti: fix div-by-zero in set_termios" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message May 23, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

USB: serial: io_ti: fix div-by-zero in set_termios

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-serial-io_ti-fix-div-by-zero-in-set_termios.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6aeb75e6adfaed16e58780309613a578fe1ee90b Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Thu, 11 May 2017 11:41:21 +0200
Subject: USB: serial: io_ti: fix div-by-zero in set_termios

From: Johan Hovold <[email protected]>

commit 6aeb75e6adfaed16e58780309613a578fe1ee90b upstream.

Fix a division-by-zero in set_termios when debugging is enabled and a high-enough speed has been requested so that the divisor value becomes zero.

Instead of just fixing the offending debug statement, cap the baud rate at the base as a zero divisor value also appears to crash the firmware.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/usb/serial/io_ti.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/usb/serial/io_ti.c +4 -1
@@ -2349,8 +2349,11 @@ static void change_port_settings(struct
 	if (!baud) {
 		/* pick a default, any default... */
 		baud = 9600;
-	} else
+	} else {
+		/* Avoid a zero divisor. */
+		baud = min(baud, 461550);
 		tty_encode_baud_rate(tty, baud, baud);
+	}
 
 	edge_port->baud_rate = baud;
 	config->wBaudRate = (__u16)((461550L + baud/2) / baud);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/usb-serial-io_ti-fix-div-by-zero-in-set_termios.patch queue-4.9/usb-chaoskey-fix-alea-quirk-on-big-endian-hosts.patch queue-4.9/usb-hub-fix-non-ss-hub-descriptor-handling.patch queue-4.9/usb-serial-ftdi_sio-add-olimex-arm-usb-tiny-h-pids.patch queue-4.9/usb-serial-ftdi_sio-fix-setting-latency-for-unprivileged-users.patch queue-4.9/usb-iowarrior-fix-info-ioctl-on-big-endian-hosts.patch queue-4.9/watchdog-pcwd_usb-fix-null-deref-at-probe.patch queue-4.9/usb-serial-qcserial-add-more-lenovo-em74xx-device-ids.patch queue-4.9/usb-serial-option-add-telit-me910-support.patch queue-4.9/net-irda-irda-usb-fix-firmware-name-on-big-endian-hosts.patch queue-4.9/of-fdt-add-missing-allocation-failure-check.patch queue-4.9/usbvision-fix-null-deref-at-probe.patch queue-4.9/usb-serial-mct_u232-fix-big-endian-baud-rate-handling.patch queue-4.9/usb-ehci-platform-fix-companion-device-leak.patch queue-4.9/mceusb-fix-null-deref-at-probe.patch queue-4.9/usb-hub-fix-ss-hub-descriptor-handling.patch queue-4.9/ath9k_htc-fix-null-deref-at-probe.patch queue-4.9/usb-musb-fix-trying-to-suspend-while-active-for-otg-configurations.patch