Skip to contentSkip to conversation

Patch "uwb: fix device quirk on big-endian hosts" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message May 23, 2017 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

uwb: fix device quirk on big-endian hosts

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
uwb-fix-device-quirk-on-big-endian-hosts.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 41318a2b82f5d5fe1fb408f6d6e0b22aa557111d Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Fri, 12 May 2017 12:06:32 +0200
Subject: uwb: fix device quirk on big-endian hosts

From: Johan Hovold <[email protected]>

commit 41318a2b82f5d5fe1fb408f6d6e0b22aa557111d upstream.

Add missing endianness conversion when using the USB device-descriptor idProduct field to apply a hardware quirk.

Fixes 1ba47da52712 ("uwb: add the i1480 DFU driver")
---
 drivers/uwb/i1480/dfu/usb.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/uwb/i1480/dfu/usb.c +3 -2
@@ -341,6 +341,7 @@ error_submit_ep1:
 static
 int i1480_usb_probe(struct usb_interface *iface, const struct usb_device_id *id)
 {
+	struct usb_device *udev = interface_to_usbdev(iface);
 	struct i1480_usb *i1480_usb;
 	struct i1480 *i1480;
 	struct device *dev = &iface->dev;
@@ -352,8 +353,8 @@ int i1480_usb_probe(struct usb_interface
 			iface->cur_altsetting->desc.bInterfaceNumber);
 		goto error;
 	}
-	if (iface->num_altsetting > 1
-	    && interface_to_usbdev(iface)->descriptor.idProduct == 0xbabe) {
+	if (iface->num_altsetting > 1 &&
+			le16_to_cpu(udev->descriptor.idProduct) == 0xbabe) {
 		/* Need altsetting #1 [HW QUIRK] or EP1 won't work */
 		result = usb_set_interface(interface_to_usbdev(iface), 0, 1);
 		if (result < 0)

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/cx231xx-audio-fix-null-deref-at-probe.patch queue-3.18/usb-serial-io_ti-fix-div-by-zero-in-set_termios.patch queue-3.18/usb-hub-fix-non-ss-hub-descriptor-handling.patch queue-3.18/cx231xx-cards-fix-null-deref-at-probe.patch queue-3.18/usb-serial-ftdi_sio-add-olimex-arm-usb-tiny-h-pids.patch queue-3.18/usb-serial-ftdi_sio-fix-setting-latency-for-unprivileged-users.patch queue-3.18/usb-iowarrior-fix-info-ioctl-on-big-endian-hosts.patch queue-3.18/watchdog-pcwd_usb-fix-null-deref-at-probe.patch queue-3.18/gspca-konica-add-missing-endpoint-sanity-check.patch queue-3.18/usb-serial-qcserial-add-more-lenovo-em74xx-device-ids.patch queue-3.18/usb-serial-option-add-telit-me910-support.patch queue-3.18/net-irda-irda-usb-fix-firmware-name-on-big-endian-hosts.patch queue-3.18/dib0700-fix-null-deref-at-probe.patch queue-3.18/of-fdt-add-missing-allocation-failure-check.patch queue-3.18/usbvision-fix-null-deref-at-probe.patch queue-3.18/usb-serial-mct_u232-fix-big-endian-baud-rate-handling.patch queue-3.18/uwb-fix-device-quirk-on-big-endian-hosts.patch queue-3.18/mceusb-fix-null-deref-at-probe.patch queue-3.18/usb-hub-fix-ss-hub-descriptor-handling.patch queue-3.18/ath9k_htc-fix-null-deref-at-probe.patch