Skip to contentSkip to conversation

drm: kirin: Fix drm_of_find_panel_or_bridge conversion

PATCH In review John Stultz 2 participants 4 messages May 23, 2017 – Jun 6, 2017 1 message not in the archive

Subsystems (3)
DRM drivers DRM misc DRM drivers for HiSilicon kirin
lore
Share & tools
lore

John Stultz

author
#0 lore raw

PATCH 1/1 drm: kirin: Fix drm_of_find_panel_or_bridge conversion

This fixes a regression introduced by ebc944613567 ("drm:
convert drivers to use drm_of_find_panel_or_bridge") that was recently merged, causing HDMI output to not work.

For the kirin driver, the port value should be 1 instead of 0, so this oneline patch fixes it and gets graphics working again.

Cc Rob Herring <[email protected]>
Cc Archit Taneja <[email protected]>
Cc Philipp Zabel <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Sean Paul <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Xinliang Liu <[email protected]>
Fix-suggested-by Rob Herring <[email protected]>
Signed-off-by John Stultz <[email protected]>
---
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +1 -1
index 5abc69c..f77dcfa 100644
@@ -760,7 +760,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
 	 * Get the endpoint node. In our case, dsi has one output port1
 	 * to which the external HDMI bridge is connected.
 	 */
-	ret = drm_of_find_panel_or_bridge(np, 0, 0, NULL, &dsi->bridge);
+	ret = drm_of_find_panel_or_bridge(np, 1, 0, NULL, &dsi->bridge);
 	if (ret)
 		return ret;
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): CAGd==05qHrg-su91MAeTYFXGkF53yheZ0yjDKO9ehjG6nhKEOg@mail.gmail.com

author
#2 lore raw
Quoted 21 lines · Xinliang Liu
Quoted 16 lines · John Stultz

This fixes a regression introduced by ebc944613567 ("drm:
convert drivers to use drm_of_find_panel_or_bridge") that was recently merged, causing HDMI output to not work.

For the kirin driver, the port value should be 1 instead of 0, so this oneline patch fixes it and gets graphics working again.

Cc: Rob Herring <[email protected]>
Cc: Archit Taneja <[email protected]>
Cc: Philipp Zabel <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: Dave Airlie <[email protected]>
Cc:
Xinliang Liu <[email protected]>

Quoted 2 lines
Fix-suggested-by Rob Herring <[email protected]>
Signed-off-by John Stultz <[email protected]>
Quoted 5 lines

Looks good to me. Thanks for the patch.

Reviewed-by:
Xinliang Liu <[email protected]>

Just wanted to check in on this. Is there someone I'm missing from the cc list on this?

thanks
-john

#3 lore raw
Quoted 22 lines · John Stultz
Quoted 21 lines · Xinliang Liu
Quoted 18 lines · John Stultz

This fixes a regression introduced by ebc944613567 ("drm:
convert drivers to use drm_of_find_panel_or_bridge") that was recently merged, causing HDMI output to not work.

For the kirin driver, the port value should be 1 instead of 0, so this oneline patch fixes it and gets graphics working again.

Cc: Rob Herring <[email protected]>
Cc: Archit Taneja <[email protected]>
Cc: Philipp Zabel <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: Dave Airlie <[email protected]>
Cc:
Xinliang Liu <[email protected]>

Fix-suggested-by Rob Herring <[email protected]>
Signed-off-by John Stultz <[email protected]>
Quoted 9 lines
Quoted 5 lines

Looks good to me. Thanks for the patch.

Reviewed-by:
Xinliang Liu <[email protected]>

Just wanted to check in on this. Is there someone I'm missing from the cc list on this?

Hi John,
Apologies, I just saw this. Slipped through my cracks because it's not posted on dri-devel.

The patch looks good. I'll pick it up in drm-misc-fixes if Dave doesn't take it directly into drm-fixes.

Sean

Quoted 2 lines

thanks
-john

#4 lore raw
Quoted 33 lines · Sean Paul
Quoted 22 lines · John Stultz
Quoted 21 lines · Xinliang Liu
Quoted 18 lines · John Stultz

This fixes a regression introduced by ebc944613567 ("drm:
convert drivers to use drm_of_find_panel_or_bridge") that was recently merged, causing HDMI output to not work.

For the kirin driver, the port value should be 1 instead of 0, so this oneline patch fixes it and gets graphics working again.

Cc: Rob Herring <[email protected]>
Cc: Archit Taneja <[email protected]>
Cc: Philipp Zabel <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: Dave Airlie <[email protected]>
Cc:
Xinliang Liu <[email protected]>

Fix-suggested-by Rob Herring <[email protected]>
Signed-off-by John Stultz <[email protected]>
Quoted 9 lines
Quoted 5 lines

Looks good to me. Thanks for the patch.

Reviewed-by:
Xinliang Liu <[email protected]>

Just wanted to check in on this. Is there someone I'm missing from the cc list on this?

Quoted 7 lines

Hi John,
Apologies, I just saw this. Slipped through my cracks because it's not posted on dri-devel.

The patch looks good. I'll pick it up in drm-misc-fixes if Dave doesn't take it directly into drm-fixes.

Hi John,
I've picked this up in drm-misc-fixes.

Thanks again for the patch,

Sean

Quoted 5 lines

Sean

Quoted 2 lines

thanks
-john