sunxi: Add support for the CHIP Pro

CMD_MTDPARTS is something the user might or might not want to select, and
might depends on (or be selected by) other options too.

This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
might change from one board to another, or from one user to the other,
depending on what it expects and what storage devices are available.

In order to ease that configuration, add those options to Kconfig.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Tom Rini <[email protected]>

---
 cmd/Kconfig    | 20 ++++++++++++++++++++
 cmd/mtdparts.c |  8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

cmd/Kconfig +0 -0

index ef5315631476..0734d669dbd7 100644
@@ -801,6 +801,26 @@ config CMD_FS_GENERIC
 	help
 	  Enables filesystem commands (e.g. load, ls) that work for

multiple

Quoted 19 lines · Maxime Ripard

CMD_MTDPARTS is something the user might or might not want to select, and
might depends on (or be selected by) other options too.

This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
might change from one board to another, or from one user to the other,
depending on what it expects and what storage devices are available.

In order to ease that configuration, add those options to Kconfig.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Tom Rini <[email protected]>

---
 cmd/Kconfig    | 20 ++++++++++++++++++++
 cmd/mtdparts.c |  8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

cmd/Kconfig config CMD_FS_GENERIC · line 806

Quoted 12 lines

cmd/Kconfig +0 -0

index ef5315631476..0734d669dbd7 100644
@@ -801,6 +801,26 @@ config CMD_FS_GENERIC
 	help
 	  Enables filesystem commands (e.g. load, ls) that work for

multiple

cmd/Kconfig +3 -0

 	  fs types.
+
+config CMD_MTDPARTS
+	depends on ARCH_SUNXI

Is there any reason to limit the command for the sunxi arch only?

Hi Jörg,

Quoted 23 lines · Jörg Krause

Quoted 22 lines · Maxime Ripard

CMD_MTDPARTS is something the user might or might not want to select,
and
might depends on (or be selected by) other options too.

This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
might change from one board to another, or from one user to the other,
depending on what it expects and what storage devices are available.

In order to ease that configuration, add those options to Kconfig.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Tom Rini <[email protected]>

---
 cmd/Kconfig    | 20 ++++++++++++++++++++
 cmd/mtdparts.c |  8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

Quoted 15 lines

cmd/Kconfig config CMD_FS_GENERIC · line 806

Quoted 13 lines

cmd/Kconfig +0 -0

index ef5315631476..0734d669dbd7 100644
@@ -801,6 +801,26 @@ config CMD_FS_GENERIC
 	help
 	  Enables filesystem commands (e.g. load, ls) that work

for
multiple

cmd/Kconfig +3 -0

 	  fs types.
+
+config CMD_MTDPARTS
+	depends on ARCH_SUNXI

Is there any reason to limit the command for the sunxi arch only?

Yes, if we don't, this will generate warnings for each architecture that has not moved that option from their header to Kconfig.

Hi Maxime,

Quoted 42 lines · Maxime Ripard

Hi Jörg,

Quoted 38 lines · Jörg Krause

Quoted 31 lines · Maxime Ripard

CMD_MTDPARTS is something the user might or might not want to select,
and
might depends on (or be selected by) other options too.

This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
might change from one board to another, or from one user to the other,
depending on what it expects and what storage devices are available.

In order to ease that configuration, add those options to Kconfig.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Tom Rini <[email protected]>

---
 cmd/Kconfig    | 20 ++++++++++++++++++++
 cmd/mtdparts.c |  8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

cmd/Kconfig +0 -0

index ef5315631476..0734d669dbd7 100644
@@ -801,6 +801,26 @@ config CMD_FS_GENERIC
 	help
 	  Enables filesystem commands (e.g. load, ls) that work

for
multiple

cmd/Kconfig config CMD_FS_GENERIC · line 806

Quoted 4 lines

cmd/Kconfig +3 -0

 	  fs types.
+
+config CMD_MTDPARTS
+	depends on ARCH_SUNXI

Is there any reason to limit the command for the sunxi arch only?

Quoted 2 lines

Yes, if we don't, this will generate warnings for each architecture that has not moved that option from their header to Kconfig.

I see! However, wouldn't it be best to migrate all architectures to Kconfig instead of doing it seperately?

Quoted 48 lines · Jörg Krause

Hi Maxime,

Quoted 44 lines · Maxime Ripard

Hi Jörg,

Quoted 23 lines · Jörg Krause

Quoted 22 lines · Maxime Ripard

CMD_MTDPARTS is something the user might or might not want to select,
and
might depends on (or be selected by) other options too.

This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
might change from one board to another, or from one user to the other,
depending on what it expects and what storage devices are available.

In order to ease that configuration, add those options to Kconfig.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Tom Rini <[email protected]>

---
 cmd/Kconfig    | 20 ++++++++++++++++++++
 cmd/mtdparts.c |  8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

Quoted 15 lines

cmd/Kconfig config CMD_FS_GENERIC · line 806

Quoted 13 lines

cmd/Kconfig +0 -0

index ef5315631476..0734d669dbd7 100644
@@ -801,6 +801,26 @@ config CMD_FS_GENERIC
 	help
 	  Enables filesystem commands (e.g. load, ls) that work

for
multiple

cmd/Kconfig +3 -0

 	  fs types.
+
+config CMD_MTDPARTS
+	depends on ARCH_SUNXI

Is there any reason to limit the command for the sunxi arch only?

Yes, if we don't, this will generate warnings for each architecture that has not moved that option from their header to Kconfig.

Quoted 2 lines

I see! However, wouldn't it be best to migrate all architectures to Kconfig instead of doing it seperately?

Probably, but there was a quite significant number of Kconfig symbols introduced, used by a very significant number of boards and architectures.

This was really to unreasonable to do at the time, but we can definitely do that now.

Quoted 48 lines · Jörg Krause

Hi Maxime,

Quoted 44 lines · Maxime Ripard

Hi Jörg,

Quoted 23 lines · Jörg Krause

Quoted 22 lines · Maxime Ripard

CMD_MTDPARTS is something the user might or might not want to select,
and
might depends on (or be selected by) other options too.

This is even truer for the MTDIDS_DEFAULT and MTDPARTS_DEFAULT options that
might change from one board to another, or from one user to the other,
depending on what it expects and what storage devices are available.

In order to ease that configuration, add those options to Kconfig.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Tom Rini <[email protected]>

---
 cmd/Kconfig    | 20 ++++++++++++++++++++
 cmd/mtdparts.c |  8 ++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

Quoted 15 lines

cmd/Kconfig config CMD_FS_GENERIC · line 806

Quoted 13 lines

cmd/Kconfig +0 -0

index ef5315631476..0734d669dbd7 100644
@@ -801,6 +801,26 @@ config CMD_FS_GENERIC
 	help
 	  Enables filesystem commands (e.g. load, ls) that work

for
multiple

cmd/Kconfig +3 -0

 	  fs types.
+
+config CMD_MTDPARTS
+	depends on ARCH_SUNXI

Is there any reason to limit the command for the sunxi arch only?

Yes, if we don't, this will generate warnings for each architecture that has not moved that option from their header to Kconfig.

Quoted 2 lines

I see! However, wouldn't it be best to migrate all architectures to Kconfig instead of doing it seperately?

Probably, but there was a quite significant number of Kconfig symbols introduced, used by a very significant number of boards and architectures.

This was really to unreasonable to do at the time, but we can definitely do that now.

From: Boris Brezillon <[email protected]>

Expose the RBTREE feature through Kconfig and select this option from the MTD_UBI option.

Signed-off-by Boris Brezillon <[email protected]>

Signed-off-by Maxime Ripard <[email protected]>

---
 drivers/mtd/ubi/Kconfig | 1 +
 lib/Kconfig             | 3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

drivers/mtd/ubi/Kconfig +0 -0

index 0c82395317ab..cb9ba78681ed 100644

drivers/mtd/ubi/Kconfig +0 -0

 	help
 	  UBI is a software layer above MTD layer which admits of LVM-like
 	  logical volumes on top of MTD devices, hides some complexities of

lib/Kconfig +3 -0

index b16062fbe333..5944d967dff4 100644
@@ -52,6 +52,9 @@ config LIB_RAND
 	help
 	  This library provides pseudo-random number generator functions.
 
+config RBTREE
+	bool
+
 source lib/dhry/Kconfig
 
 source lib/rsa/Kconfig

From: Boris Brezillon <[email protected]>

Create a new Kconfig entry to allow CMD_UBIFS selection from Kconfig and
add an hidden LZO option that can be selected by CMD_UBIFS.

Signed-off-by Boris Brezillon <[email protected]>

Signed-off-by Maxime Ripard <[email protected]>

---
 cmd/Kconfig | 8 ++++++++
 lib/Kconfig | 2 ++
 2 files changed, 10 insertions(+), 0 deletions(-)

cmd/Kconfig +0 -0

index 0734d669dbd7..66d3273fac6f 100644
@@ -835,4 +835,12 @@ config CMD_UBI
 	  (www.linux-mtd.infradead.org). Activate this option if you

want

cmd/Kconfig +2 -0

 	  to use U-Boot UBI commands.
 
+config CMD_UBIFS
+	tristate "Enable UBIFS - Unsorted block images filesystem

commands"

From: Hans de Goede <[email protected]>

Enable the NAND and UBI support in the configuration header so that we can (finally) use it.

Signed-off-by Hans de Goede <[email protected]>

Signed-off-by Maxime Ripard <[email protected]>

---
 cmd/Kconfig                    | 4 ++++
 include/configs/sunxi-common.h | 3 +++
 2 files changed, 7 insertions(+), 0 deletions(-)

cmd/Kconfig +0 -0

index 4e7c0fbcdee5..8e2a05de82ea 100644

cmd/Kconfig +3 -0

        help
          NAND support.
 
 if CMD_NAND
 config CMD_NAND_TRIMFFS
        bool "nand write.trimffs"
+       default y if ARCH_SUNXI
        help
          Allows one to skip empty pages when flashing something on a NAND.
 

@@ -845,6 +847,7 @@ config CMD_UBI
        tristate "Enable UBI - Unsorted block images commands"
        select CRC32
        select MTD_UBI
+       default y if ARCH_SUNXI
        help
          UBI is a software layer above MTD layer which admits use of LVM-like
          logical volumes on top of MTD devices, hides some complexities of

@@ -858,6 +861,7 @@ config CMD_UBIFS
        select CRC32
        select RBTREE if ARCH_SUNXI
        select LZO if ARCH_SUNXI
+       default y if ARCH_SUNXI
        help
          UBIFS is a file system for flash devices which works on top of UBI.
 

include/configs/sunxi-common.h +3 -1

index b9cf315af58d..b1af756a6ac9 100644
@@ -132,6 +132,9 @@
 #define CONFIG_SYS_NAND_MAX_ECCPOS 1664
 #define CONFIG_SYS_NAND_ONFI_DETECTION
 #define CONFIG_SYS_MAX_NAND_DEVICE 8
+
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
 #endif
 
 #ifdef CONFIG_SPL_SPI_SUNXI
--

git-series 0.8.11
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/listinfo/u-boot

The CHIP Pro is a SoM that features the GR8 SIP, an AXP209, a BT/WiFi chip and a 512MiB SLC NAND.

This it's an SLC NAND, it doesn't suffer the same drawbacks than found on the MLC NANDs, and we can enable it right away.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Hans de Goede <[email protected]>

---
 configs/CHIP_pro_defconfig | 33 +++++++++++++++++++++++++++++++++

+CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256"

Quoted 10 lines · Maxime Ripard

The CHIP Pro is a SoM that features the GR8 SIP, an AXP209, a BT/WiFi chip and a 512MiB SLC NAND.

This it's an SLC NAND, it doesn't suffer the same drawbacks than found on the MLC NANDs, and we can enable it right away.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Hans de Goede <[email protected]>

---
 configs/CHIP_pro_defconfig | 33 +++++++++++++++++++++++++++++++++

[snip]

Quoted 1 line

+CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256"

Conversion itself won't be fun (I can see it'll take some regex'ing before hand to convert various values to a number) but can you please add Kconfig entires for SYS_NAND_xxx values and populate those for this baord instead of adding more SYS_EXTRA_OPTIONS? Thanks!

Hi Tom,

Quoted 15 lines · Tom Rini

Quoted 10 lines · Maxime Ripard

The CHIP Pro is a SoM that features the GR8 SIP, an AXP209, a BT/WiFi chip and a 512MiB SLC NAND.

This it's an SLC NAND, it doesn't suffer the same drawbacks than found on the MLC NANDs, and we can enable it right away.

Signed-off-by Maxime Ripard <[email protected]>

Reviewed-by Hans de Goede <[email protected]>

---
 configs/CHIP_pro_defconfig | 33 +++++++++++++++++++++++++++++++++

[snip]

Quoted 1 line

+CONFIG_SYS_EXTRA_OPTIONS="CONS_INDEX=2,SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256"

Quoted 4 lines

Conversion itself won't be fun (I can see it'll take some regex'ing before hand to convert various values to a number) but can you please add Kconfig entires for SYS_NAND_xxx values and populate those for this baord instead of adding more SYS_EXTRA_OPTIONS? Thanks!

If you mean converting only the Allwinner boards to it, then yes, sure. If you also mean converting all the other architectures, then I'm sorry but I don't have the time to do that.

The CHIP Pro is a SoM made by NextThing Co, and that embeds a GR8 SIP, an AXP209 PMIC, a WiFi BT chip and a 512MB SLC NAND.

Since the first Allwinner device coming whit an SLC NAND that doesn't have the shortcomings (and breakages) the MLC NAND has, we can finally enable the NAND support on a board by default.

This is the occasion to introduce a bunch of additions needed imo to be able to come up with a sane NAND support for our users.

The biggest pain point is that the BROM uses a different ECC and randomizer configuration than for the rest of the NAND. In order to lessen the number of bitflips, you also need to pad with random data the SPL image.

Since it's quite tedious to do right (and most users won't be able to figure it out) and since if it is not done right, it will eventually turn into an unusable system (which is bad UX), we think that the best solution is to generate an SPL image that already embeds all this. We'll possible have to do the same thing for the U-Boot image (at least for the random padding) on MLC NANDs.

The only drawback from that is that you need to flash it raw, instead of using the usual nand write, but it's just a different command, nothing major anyway.

In order to flash it, from a device switched in FEL, on your host:
sunxi-fel spl spl/sunxi-spl.bin
sunxi-fel write 0x4a000000 u-boot-dtb.bin
sunxi-fel write 0x43000000 spl/sunxi-spl-with-ecc.bin sunxi-fel exe 0x4a000000

And on the board, once u-boot is running (assuming the NAND is already erased):

nand write.raw.noverify 0x43000000 0 40
nand write.raw.noverify 0x43000000 0x400000 40

nand write 0x4a000000 0x800000 0xc0000

I also encountered some weird bug in the private libgcc that prevents U-Boot from loading. Disabling CONFIG_USE_PRIVATE_LIBGCC fixes that.

Let me know what you think,
Maxime

Changes from v4:
- Rebased on top of last pull request
- Removed irrelevant config options

Changes from v3:
- Bring new Kconfig patches from Boris
- Do not define Kconfig defaults in our board Kconfig but directly in the option declaration
- Sync the DT with the kernel
- Fixed build breakages

Changes from v2:
- Move CMD_NAND and CMD_UBI default to cmd/Kconfig
- Define the env Kconfig options only for ARCH_SUNXI to avoid build breakages
- Define CMD_MTDPARTS only for ARCH_SUNXI

Changes from v1:
- Allowed to build lib/bch.c for the host, and used that in the image builder
- Fixed a bug in the NAND driver
- Wrote a documentation on how to flash a NAND image on an Allwinner board
- Fixed a few compilation breakages and issues
- Moved U-boot offset out of the config header and into Kconfig
- Moved the environment into UBI
- Moved the environment selection to Kconfig
- Moved the CMD_MTDPARTS options to Kconfig
- Provide MTDIDS_DEFAULT and MTDPARTS_DEFAULT options through Kconfig
- Added the tags from everyone

Boris Brezillon (3):
mtd: ubi: Select RBTREE option from MTD_UBI Kconfig entry
cmd: Expose a Kconfig option to enable UBIFS commands
cmd: nand: Expose optional suboptions in Kconfig

Hans de Goede (1):
sunxi: Enable UBI and NAND support

Maxime Ripard (12):
nand: sunxi: Fix modulo by zero error
bch: Allow to build for the host
tools: sunxi: Add spl image builder
common: Move environment choice to Kconfig
cmd: Add Kconfig option for CMD_MTDPARTS and related options
mtd: sunxi: Select the U-Boot location config option
mtd: sunxi: Change U-Boot offset
sunxi: Add the default mtdids and mtdparts to our env
nand: sunxi: Add options for the SPL NAND configuration
scripts: sunxi: Build an raw SPL image
sunxi: Sync GR8 DTS and AXP209 with the kernel
sunxi: Add support for the CHIP Pro