Skip to contentSkip to conversation

Patch "be2net: Fix offload features for Q-in-Q packets" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message May 31, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

be2net: Fix offload features for Q-in-Q packets

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
be2net-fix-offload-features-for-q-in-q-packets.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Wed May 31 09:13:10 JST 2017

From: Vlad Yasevich <[email protected]>
Date: Tue, 23 May 2017 13:38:42 -0400
Subject: be2net: Fix offload features for Q-in-Q packets

From: Vlad Yasevich <[email protected]>

[ Upstream commit cc6e9de62a7f84c9293a2ea41bc412b55bb46e85 ]

At least some of the be2net cards do not seem to be capabled of performing checksum offload computions on Q-in-Q packets. In these case, the recevied checksum on the remote is invalid and TCP syn packets are dropped.

This patch adds a call to check disbled acceleration features on Q-in-Q tagged traffic.

CC Sathya Perla <[email protected]>
CC Ajit Khaparde <[email protected]>
CC Sriharsha Basavapatna <[email protected]>
CC Somnath Kotur <[email protected]>
---
 drivers/net/ethernet/emulex/benet/be_main.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/emulex/benet/be_main.c +3 -1
@@ -5027,9 +5027,11 @@ static netdev_features_t be_features_che
 	struct be_adapter *adapter = netdev_priv(dev);
 	u8 l4_hdr = 0;
 
-	/* The code below restricts offload features for some tunneled packets.
+	/* The code below restricts offload features for some tunneled and
+	 * Q-in-Q packets.
 	 * Offload features for normal (non tunnel) packets are unchanged.
 	 */
+	features = vlan_features_check(skb, features);
 	if (!skb->encapsulation ||
 	    !(adapter->flags & BE_FLAGS_VXLAN_OFFLOADS))
 		return features;

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/vlan-fix-tcp-checksum-offloads-in-q-in-q-vlans.patch queue-4.11/be2net-fix-offload-features-for-q-in-q-packets.patch queue-4.11/virtio-net-enable-tso-checksum-offloads-for-q-in-q-vlans.patch queue-4.11/sctp-fix-icmp-processing-if-skb-is-non-linear.patch