Skip to contentSkip to conversation

imx-uuc: fix start-stop-daemon stop failure

PATCH New Alexandre Esse 4 participants 4 messages May 31, 2017 – Jun 6, 2017 Arm i.MX and Layerscape

lore
Share & tools
lore

Alexandre Esse

author
#0 lore raw

PATCH 1/1 imx-uuc: fix start-stop-daemon stop failure

The daemon service script associated with imx-uuc failed to stop the daemon since the PID of the process wasn't stored at start time.

Adding -m option allowed to create the uuc.pid file as expected.

Signed-off-by Alexandre Esse <[email protected]>
---
 package/freescale-imx/imx-uuc/S80imx-uuc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/freescale-imx/imx-uuc/S80imx-uuc +1 -1
index 8a02f88..9a92c98 100644
@@ -6,7 +6,7 @@ DAEMON=/usr/bin/$NAME
 case "$1" in
     start)
 	printf "Starting $NAME: "
-	start-stop-daemon -S -q -b -p /var/run/${NAME}.pid -x $DAEMON
+	start-stop-daemon -S -q -b -m -p /var/run/${NAME}.pid -x $DAEMON
 	[ $? = 0 ] && echo "OK" || echo "FAIL"
 	;;
     stop)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 imx-uuc: fix start-stop-daemon stop failure

Hi Alexandre,

Quoted 6 lines · Alexandre Esse

The daemon service script associated with imx-uuc failed to stop the daemon since the PID of the process wasn't stored at start time.

Adding -m option allowed to create the uuc.pid file as expected.

Signed-off-by Alexandre Esse <[email protected]>
Reviewed-by Gary Bisson <[email protected]>

Thanks for your patch.

Regards,
Gary

Applied
#2 lore raw

PATCH 1/1 imx-uuc: fix start-stop-daemon stop failure

In reply to Alexandre Esse

Hello,

Quoted 9 lines · Alexandre Esse

The daemon service script associated with imx-uuc failed to stop the daemon since the PID of the process wasn't stored at start time.

Adding -m option allowed to create the uuc.pid file as expected.

Signed-off-by Alexandre Esse <[email protected]>
---
 package/freescale-imx/imx-uuc/S80imx-uuc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. Peter: this should go in the LTS branch.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 imx-uuc: fix start-stop-daemon stop failure

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 3 lines · Alexandre Esse

The daemon service script associated with imx-uuc failed to stop the daemon since the PID of the process wasn't stored at start time.

Quoted 8 lines
Quoted 6 lines

Adding -m option allowed to create the uuc.pid file as expected.

Signed-off-by Alexandre Esse <[email protected]>

---
package/freescale-imx/imx-uuc/S80imx-uuc | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. Peter: this should go in the LTS branch.

Indeed. Committed to 2017.02.x and 2017.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard