toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
PATCH 1/1 toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
As GCC7 is now available in Buildroot, update the definition for BR2_TOOLCHAIN_HAS_GCC_BUG_64735 as the bug #64735 is fixed in GCC 7.
--- toolchain/toolchain-common.in | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
toolchain/toolchain-common.in +3 -4
@@ -13,10 +13,9 @@ comment "Toolchain Generic Options" # ints before GCC 7 config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 bool - default y if BR2_nios2 - default y if BR2_ARM_CPU_ARMV4 - default y if BR2_ARM_CPU_ARMV5 - default y if BR2_sparc_v8 + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \ + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 config BR2_TOOLCHAIN_HAS_NATIVE_RPC bool
Signature · 1 line
2.13.0
PATCH 1/1 toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Hello,
Quoted 5 lines · J?rg Krause
toolchain/toolchain-common.in +0
-0
toolchain/toolchain-common.in comment "Toolchain Generic Options" · line 18
Quoted 10 lines
toolchain/toolchain-common.in +3
-4@@ -13,10 +13,9 @@ comment "Toolchain Generic Options" # ints before GCC 7 config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 bool - default y if BR2_nios2 - default y if BR2_ARM_CPU_ARMV4 - default y if BR2_ARM_CPU_ARMV5 - default y if BR2_sparc_v8 + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \ + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
This feels very complicated. What about just:
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Hi Thomas,
Quoted 22 lines · Thomas Petazzoni
Hello,
Quoted 5 lines · J?rg Krause
toolchain/toolchain-common.in +0
-0toolchain/toolchain-common.in comment "Toolchain Generic Options" · line 18
Quoted 10 lines
toolchain/toolchain-common.in +3
-4@@ -13,10 +13,9 @@ comment "Toolchain Generic Options" # ints before GCC 7 config BR2_TOOLCHAIN_HAS_GCC_BUG_64735 bool - default y if BR2_nios2 - default y if BR2_ARM_CPU_ARMV4 - default y if BR2_ARM_CPU_ARMV5 - default y if BR2_sparc_v8 + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \ + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_7This feels very complicated. What about just:
Quoted 1 line
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Wouldn't that be rather:
"""
config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""
The package mpd chooses between version 0.19 and 0.20 depending on that bug. For now, if mpd is build with GCC6 (and below) and an architecture not affected by this bug, version 0.20 is selected. By not depending on the architecture anymore, mpd version 0.19 would be selected instead.
J?rg
PATCH 1/1 toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Hello,
Quoted 12 lines · J?rg Krause
Quoted 12 lines
toolchain/toolchain-common.in comment "Toolchain Generic Options" · line 18
Quoted 9 lines
config
BR2_TOOLCHAIN_HAS_GCC_BUG_64735toolchain/toolchain-common.in +3
-4bool - default y if BR2_nios2 - default y if BR2_ARM_CPU_ARMV4 - default y if BR2_ARM_CPU_ARMV5 - default y if BR2_sparc_v8 + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \ + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_7This feels very complicated. What about just:
Quoted 8 lines
Quoted 1 line
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Wouldn't that be rather:
"""
configBR2_TOOLCHAIN_HAS_GCC_BUG_64735
default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""
No because that would make the option "y" as soon as you have gcc < 7. But we want the option to be "y" only if you have gcc < 7 *and* you're using one of nios2, ARMv4/v5 or sparc v8.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Quoted 20 lines · Thomas Petazzoni
Hello,
Quoted 16 lines · J?rg Krause
Quoted 12 lines
toolchain/toolchain-common.in comment "Toolchain Generic Options" · line 18
Quoted 9 lines
config
BR2_TOOLCHAIN_HAS_GCC_BUG_64735toolchain/toolchain-common.in +3
-4bool - default y if BR2_nios2 - default y if BR2_ARM_CPU_ARMV4 - default y if BR2_ARM_CPU_ARMV5 - default y if BR2_sparc_v8 + default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \ + BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_7This feels very complicated. What about just:
Quoted 1 line
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Wouldn't that be rather:
Quoted 8 lines
Quoted 4 lines
"""
configBR2_TOOLCHAIN_HAS_GCC_BUG_64735
default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""No because that would make the option "y" as soon as you have gcc < 7. But we want the option to be "y" only if you have gcc < 7 *and* you're using one of nios2, ARMv4/v5 or sparc v8.
Sorry, I totally got you wrong. So, what you mean is:
"""
config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
bool
default y if BR2_nios2
default y if BR2_ARM_CPU_ARMV4
default y if BR2_ARM_CPU_ARMV5
default y if BR2_sparc_v8
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""
Right?
J?rg
PATCH 1/1 toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Hello,
Quoted 13 lines · J?rg Krause
Sorry, I totally got you wrong. So, what you mean is:
"""
configBR2_TOOLCHAIN_HAS_GCC_BUG_64735
bool
default y ifBR2_nios2
default y ifBR2_ARM_CPU_ARMV4
default y ifBR2_ARM_CPU_ARMV5
default y ifBR2_sparc_v8
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
"""
Quoted 1 line
Right?
Yes, exactly!
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com