u-boot: enable dhcp for MPC8315 board

PATCH Superseded Ed Bartosh 6 participants 12 messages Jun 7, 2017 – May 4, 2018

Share & tools

Ed Bartosh

author

2017-06-07 12:06 UTC #0 lore raw

PATCH 1/1 u-boot: enable dhcp for MPC8315 board

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Signed-off-by Ed Bartosh <[email protected]>

---
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc +3 -1

index df24c85..8ee1c32 100644
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"

Signature · 1 line

2.1.4

Burton, Ross

2017-06-07 12:12 UTC #1 lore raw

Quoted 2 lines · Ed Bartosh

+ file://MPC8315ERDB-enable-DHCP.patch \

This file isn't in the patch.

Ross

Ed Bartosh

author

2017-06-07 12:29 UTC #2 lore raw

PATCH v2 1/1 u-boot: enable dhcp for MPC8315 board

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Signed-off-by Ed Bartosh <[email protected]>

---
 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12 ++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch new file +12 -0

new file mode 100644
index 0000000..df89e05
@@ -0,0 +1,12 @@
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y

meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc +3 -1

index df24c85..8ee1c32 100644
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"

Signature · 1 line

2.1.4

Ed Bartosh

author

2017-06-07 12:34 UTC #3 lore raw

sorry, wrong list
please, ignore

Quoted 50 lines · Ed Bartosh

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Signed-off-by Ed Bartosh <[email protected]>

---
 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12 ++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch new file +12 -0

new file mode 100644
index 0000000..df89e05
@@ -0,0 +1,12 @@
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y

meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc +3 -1

index df24c85..8ee1c32 100644
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"

Signature · 1 line

2.1.4

Signature · 3 lines

--
Regards,
Ed

Richard Purdie

2017-06-07 12:42 UTC #4 lore raw

In reply to Ed Bartosh

Quoted 9 lines · Ed Bartosh

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.
Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.
Signed-off-by Ed Bartosh <[email protected]>

Quoted 8 lines

---
meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12
++++++++++++
meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc | 4
+++-
 2 files changed, 15 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable- DHCP.patch

These files are in OE-Core, not meta-yocto but you sent them to the poky list?

Cheers,

Richard

Tom Rini

2017-06-08 00:43 UTC #5 lore raw

Quoted 19 lines · Richard Purdie

Quoted 9 lines · Ed Bartosh
Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.
Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.
Signed-off-by Ed Bartosh <[email protected]>
Quoted 8 lines
---
meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12
++++++++++++
meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc | 4
+++-
 2 files changed, 15 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable- DHCP.patch

Quoted 2 lines

These files are in OE-Core, not meta-yocto but you sent them to the poky list?

And really ought to be upstreamed? :)

Signature · 1 line

Tom

Trevor Woerner

2018-05-04 02:01 UTC #6 lore raw

Quoted 10 lines · Tom Rini

Quoted 8 lines · Richard Purdie
Quoted 7 lines · Ed Bartosh
Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.
Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Is this really something that should be part of the oe-core recipe? This looks more like something one would find in a BSP layer.

Tom Rini

2018-05-04 02:03 UTC #7 lore raw

Quoted 9 lines · Trevor Woerner

Quoted 7 lines · Tom Rini
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Ed Bartosh
Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Quoted 5 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.
Is this really something that should be part of the oe-core recipe? This looks more like something one would find in a BSP layer.

It was since it was needed to make this reference BSP slightly more usable. It's since been merged upstream.

Signature · 1 line

Tom

Ed Bartosh

author

2017-06-07 12:30 UTC #8 lore raw

PATCH v2 1/1 u-boot: enable dhcp for MPC8315 board

In reply to Burton, Ross

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Signed-off-by Ed Bartosh <[email protected]>

---
 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12 ++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch new file +12 -0

new file mode 100644
index 0000000..df89e05
@@ -0,0 +1,12 @@
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y

meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc +3 -1

index df24c85..8ee1c32 100644
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"

Signature · 1 line

2.1.4

Patchwork

2017-06-07 12:31 UTC #9 lore raw

✗ patchtest: failure for u-boot: enable dhcp for MPC8315 board (rev2)

In reply to Ed Bartosh

== Series Details ==

Series: u-boot: enable dhcp for MPC8315 board (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/7108/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence]
Suggested fix Add Upstream-Status: <status> to the header of meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)

* Issue A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence]
Suggested fix Sign off the added patch file (meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Ed Bartosh

author

2017-06-07 13:22 UTC #10 lore raw

PATCH v3 1/1 u-boot: enable dhcp for MPC8315 board

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Signed-off-by Ed Bartosh <[email protected]>

---
 .../u-boot/files/MPC8315ERDB-enable-DHCP.patch        | 19 +++++++++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc     |  4 +++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch new file +19 -0

new file mode 100644
index 0000000..5a41108
@@ -0,0 +1,19 @@
+Enabled dhcp client functionality for Yocto reference
+hardware MPC8315E-RDB.
+
+Upstream-Status: Submitted
+
+Signed-off-by: Ed Bartosh <[email protected]>
+
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y

meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc +3 -1

index df24c85..8ee1c32 100644
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"

Signature · 1 line

2.1.4

Ed Bartosh

author

2017-06-07 13:25 UTC #11 lore raw

PATCH v4 1/1 u-boot: enable dhcp for MPC8315 board

In reply to Patchwork

Getting ip address from DHCP server is much more convenient than setting static ip. It allows to configure u-boot in more generic way and to avoid hardcoding static ip in u-boot configuration.

Enabled dhcp client functionality for Yocto reference hardware MPC8315E-RDB.

Signed-off-by Ed Bartosh <[email protected]>

---
 .../u-boot/files/MPC8315ERDB-enable-DHCP.patch        | 19 +++++++++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc     |  4 +++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch new file +19 -0

new file mode 100644
index 0000000..cea52b7
@@ -0,0 +1,19 @@
+Enabled dhcp client functionality for Yocto reference
+hardware MPC8315E-RDB.
+
+Upstream-Status: Pending
+
+Signed-off-by: Ed Bartosh <[email protected]>
+
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y

meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc +3 -1

index df24c85..8ee1c32 100644
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"

Signature · 1 line

2.1.4