Skip to contentSkip to conversation

drm/i915/glk: RGB565 planes now allow 90/270 rotation

PATCH In review [email protected] 4 participants 6 messages Jun 7, 2017 – Jun 8, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/glk: RGB565 planes now allow 90/270 rotation

From: Clint Taylor <[email protected]>

RGB565 Pixel format planes can now be rotated at 90 and 270 degrees

---
 drivers/gpu/drm/i915/intel_atomic_plane.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/intel_atomic_plane.c +4 -7
index 4325cb0..9a7a7ea 100644
@@ -144,19 +144,16 @@ int intel_plane_atomic_check_with_state(struct intel_crtc_state *crtc_state,
 
 		/*
 		 * 90/270 is not allowed with RGB64 16:16:16:16,
-		 * RGB 16-bit 5:6:5, and Indexed 8-bit.
+		 * RGB 16-bit 5:6:5 (prior to gen 9 LP), and Indexed 8-bit.
 		 * TBD: Add RGB64 case once its added in supported format list.
 		 */
-		switch (state->fb->format->format) {
-		case DRM_FORMAT_C8:
-		case DRM_FORMAT_RGB565:
+		if ((state->fb->format->format == DRM_FORMAT_C8) ||
+		    (state->fb->format->format == DRM_FORMAT_RGB565 &&
+		     !IS_GEN9_LP(dev_priv) )) {
 			DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
 			              drm_get_format_name(state->fb->format->format,
 			                                  &format_name));
 			return -EINVAL;
-
-		default:
-			break;
 		}
 	}
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 3 lines · On Wed, Jun 07, 2017 at 10:45:25AM -0700, [email protected] wrote:

From: Clint Taylor <[email protected]>

RGB565 Pixel format planes can now be rotated at 90 and 270 degrees

"now" == since when?

Quoted 14 lines
---
 drivers/gpu/drm/i915/intel_atomic_plane.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/intel_atomic_plane.c +0 -0
index 4325cb0..9a7a7ea 100644
@@ -144,19 +144,16 @@ int intel_plane_atomic_check_with_state(struct intel_crtc_state *crtc_state,
 
 		/*
 		 * 90/270 is not allowed with RGB64 16:16:16:16,

drivers/gpu/drm/i915/intel_atomic_plane.c int intel_plane_atomic_check_with_state(struct intel_crtc_state *crtc_state, · line 152

Quoted 10 lines
drivers/gpu/drm/i915/intel_atomic_plane.c +4 -4
-		 * RGB 16-bit 5:6:5, and Indexed 8-bit.
+		 * RGB 16-bit 5:6:5 (prior to gen 9 LP), and Indexed 8-bit.
 		 * TBD: Add RGB64 case once its added in supported format list.
 		 */
-		switch (state->fb->format->format) {
-		case DRM_FORMAT_C8:
-		case DRM_FORMAT_RGB565:
+		if ((state->fb->format->format == DRM_FORMAT_C8) ||
+		    (state->fb->format->format == DRM_FORMAT_RGB565 &&
+		     !IS_GEN9_LP(dev_priv) )) {

I don't think BXT can do that.

Quoted 17 lines
drivers/gpu/drm/i915/intel_atomic_plane.c +0 -3
 			DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
 			              drm_get_format_name(state->fb->format->format,
 			                                  &format_name));
 			return -EINVAL;
-
-		default:
-			break;
 		}
 	}
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 5 lines · Ville Syrjälä
Quoted 3 lines · On Wed, Jun 07, 2017 at 10:45:25AM -0700, [email protected] wrote:

From: Clint Taylor <[email protected]>

RGB565 Pixel format planes can now be rotated at 90 and 270 degrees

"now" == since when?

GLK, I will update the commit message to be more specific.

Quoted 12 lines
Quoted 12 lines
---
  drivers/gpu/drm/i915/intel_atomic_plane.c | 11 ++++-------
  1 file changed, 4 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/intel_atomic_plane.c +0 -0
index 4325cb0..9a7a7ea 100644
@@ -144,19 +144,16 @@ int intel_plane_atomic_check_with_state(struct intel_crtc_state *crtc_state,
 
Quoted 13 lines

drivers/gpu/drm/i915/intel_atomic_plane.c int intel_plane_atomic_check_with_state(struct intel_crtc_state *crtc_state, · line 152

Quoted 12 lines
drivers/gpu/drm/i915/intel_atomic_plane.c +4 -4
  		/*
  		 * 90/270 is not allowed with RGB64 16:16:16:16,
-		 * RGB 16-bit 5:6:5, and Indexed 8-bit.
+		 * RGB 16-bit 5:6:5 (prior to gen 9 LP), and Indexed 8-bit.
  		 * TBD: Add RGB64 case once its added in supported format list.
  		 */
-		switch (state->fb->format->format) {
-		case DRM_FORMAT_C8:
-		case DRM_FORMAT_RGB565:
+		if ((state->fb->format->format == DRM_FORMAT_C8) ||
+		    (state->fb->format->format == DRM_FORMAT_RGB565 &&
+		     !IS_GEN9_LP(dev_priv) )) {

I don't think BXT can do that.

I forgot BXT was also labeled GEN9_LP. IS_GEMINILAKE() is more appropriate.

-Clint

Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/i915/intel_atomic_plane.c +0 -3
  			DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
  			              drm_get_format_name(state->fb->format->format,
  			                                  &format_name));
  			return -EINVAL;
-
-		default:
-			break;
  		}
  	}
 
Quoted 7 lines
Quoted 7 lines
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.BAT: success for drm/i915/glk: RGB565 planes now allow 90/270 rotation

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915/glk: RGB565 planes now allow 90/270 rotation
URL : https://patchwork.freedesktop.org/series/25417/
State : success

== Summary ==

Series 25417v1 drm/i915/glk: RGB565 planes now allow 90/270 rotation
https://patchwork.freedesktop.org/api/1.0/series/25417/revisions/1/mbox/

Test gem_exec_suspend:

        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125 +1
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (fi-skl-6770hq) fdo#99739
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-skl-6700hq) fdo#100461

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#99739 https://bugs.freedesktop.org/show_bug.cgi?id=99739
fdo#100461 https://bugs.freedesktop.org/show_bug.cgi?id=100461

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:449s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:436s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:581s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:513s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:482s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:475s
fi-glk-2a        total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:592s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:428s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:411s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:419s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:494s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:468s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:464s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:575s
fi-kbl-r         total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:574s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:458s
fi-skl-6700hq    total:278  pass:228  dwarn:1   dfail:0   fail:27  skip:22  time:404s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:466s
fi-skl-6770hq    total:278  pass:267  dwarn:0   dfail:0   fail:1   skip:10  time:505s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:436s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:539s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:401s

64f82c4142fd563bb5b1f3406369e90b072c7c4c drm-tip: 2017y-06m-07d-16h-03m-00s UTC integration manifest 553fb44 drm/i915/glk: RGB565 planes now allow 90/270 rotation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4900/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to [email protected]
Quoted 9 lines · On Wed, 2017-06-07 at 10:45 -0700, [email protected] wrote:

From: Clint Taylor <[email protected]>

RGB565 Pixel format planes can now be rotated at 90 and 270 degrees

---
 drivers/gpu/drm/i915/intel_atomic_plane.c | 11 ++++-------

 1 file changed, 4 insertions(+), 7 deletions(-)

I think we should also update corresponding IGT tests. -Radek
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 11 lines · Radoslaw
Quoted 9 lines · On Wed, 2017-06-07 at 10:45 -0700, [email protected] wrote:

From: Clint Taylor <[email protected]>

RGB565 Pixel format planes can now be rotated at 90 and 270 degrees

---
  drivers/gpu/drm/i915/intel_atomic_plane.c | 11 ++++-------
  1 file changed, 4 insertions(+), 7 deletions(-)

I think we should also update corresponding IGT tests.

I have IGT changes tested and ready. However, The BSPEC states that RGB565 90/270 rotation isn't supported on GLK (Thanks Rodrigo). I will be abandoning this patch for GLK.

-Clint

Quoted 1 line

-Radek

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx