Skip to contentSkip to conversation

Patch "net: bridge: fix a null pointer dereference in br_afspec" has been added to the 4.11-stable tree

PATCH [email protected] 1 participant 1 message Jun 8, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: bridge: fix a null pointer dereference in br_afspec

to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-bridge-fix-a-null-pointer-dereference-in-br_afspec.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Jun 8 08:58:08 CEST 2017

From: Nikolay Aleksandrov <[email protected]>
Date: Tue, 6 Jun 2017 01:26:24 +0300
Subject: net: bridge: fix a null pointer dereference in br_afspec

From: Nikolay Aleksandrov <[email protected]>

[ Upstream commit 1020ce3108cc26fbf09d70550ea2937cb1a211d2 ]

We might call br_afspec() with p == NULL which is a valid use case if the action is on the bridge device itself, but the bridge tunnel code dereferences the p pointer without checking, so check if p is null first.

Fixes efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
---
 net/bridge/br_netlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_netlink.c +1 -1
@@ -591,7 +591,7 @@ static int br_afspec(struct net_bridge *
 		err = 0;
 		switch (nla_type(attr)) {
 		case IFLA_BRIDGE_VLAN_TUNNEL_INFO:
-			if (!(p->flags & BR_VLAN_TUNNEL))
+			if (!p || !(p->flags & BR_VLAN_TUNNEL))
 				return -EINVAL;
 			err = br_parse_vlan_tunnel_info(attr, &tinfo_curr);
 			if (err)

Patches currently in stable-queue which might be from [email protected] are

queue-4.11/net-bridge-start-hello-timer-only-if-device-is-up.patch queue-4.11/net-bridge-fix-a-null-pointer-dereference-in-br_afspec.patch