Patch "bnx2x: Fix Multi-Cos" has been added to the 4.4-stable tree
This is a note to let you know that I've just added the patch titled
bnx2x: Fix Multi-Cos
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
bnx2x-fix-multi-cos.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Jun 8 09:11:25 CEST 2017
From: "Mintz, Yuval" <[email protected]>
Date: Thu, 1 Jun 2017 15:57:56 +0300
Subject: bnx2x: Fix Multi-Cos
From: "Mintz, Yuval" <[email protected]>
[ Upstream commit 3968d38917eb9bd0cd391265f6c9c538d9b33ffa ]
Apparently multi-cos isn't working for bnx2x quite some time - driver implements ndo_select_queue() to allow queue-selection for FCoE, but the regular L2 flow would cause it to modulo the fallback's result by the number of queues.
The fallback would return a queue matching the needed tc [via __skb_tx_hash()], but since the modulo is by the number of TSS queues where number of TCs is not accounted, transmission would always be done by a queue configured into using TC0.
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +1 -1
@@ -1949,7 +1949,7 @@ u16 bnx2x_select_queue(struct net_device }/* select a non-FCoE queue */ -return fallback (dev, skb) %BNX2X_NUM_ETH_QUEUES (bp); +return fallback (dev, skb) % (BNX2X_NUM_ETH_QUEUES (bp) * bp->max_cos); }void bnx2x_set_num_queues (struct bnx2x *bp)
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/bnx2x-fix-multi-cos.patch