Skip to contentSkip to conversation

Patch "cxgb4: avoid enabling napi twice to the same queue" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jun 8, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cxgb4: avoid enabling napi twice to the same queue

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cxgb4-avoid-enabling-napi-twice-to-the-same-queue.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Jun 8 09:11:25 CEST 2017

From: Ganesh Goudar <[email protected]>
Date: Wed, 31 May 2017 18:26:28 +0530
Subject: cxgb4: avoid enabling napi twice to the same queue

From: Ganesh Goudar <[email protected]>

[ Upstream commit e7519f9926f1d0d11c776eb0475eb098c7760f68 ]

Take uld mutex to avoid race between cxgb_up() and cxgb4_register_uld() to enable napi for the same uld queue.

---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |    4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +4 -0
@@ -2714,10 +2714,14 @@ static int cxgb_up(struct adapter *adap)
 		if (err)
 			goto irq_err;
 	}
+
+	mutex_lock(&uld_mutex);
 	enable_rx(adap);
 	t4_sge_start(adap);
 	t4_intr_enable(adap);
 	adap->flags |= FULL_INIT_DONE;
+	mutex_unlock(&uld_mutex);
+
 	notify_ulds(adap, CXGB4_STATE_UP);
 #if IS_ENABLED(CONFIG_IPV6)
 	update_clip(adap);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/cxgb4-avoid-enabling-napi-twice-to-the-same-queue.patch