Skip to contentSkip to conversation

drm/amd/powerplay: fix copy error in powerplay.

PATCH In review Rex Zhu 3 participants 4 messages Jun 8, 2017 – Jun 9, 2017 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Rex Zhu

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: fix copy error in powerplay.

should disable led dpm feature when stop dpm.

Change-Id I9d78459ff2467d2eba0b26d9696138f7eba484a0
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +3 -3
index 9338aca..b6df00c 100644
@@ -2702,9 +2702,9 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
 
 	if(data->smu_features[GNLD_LED_DISPLAY].supported == true){
 		PP_ASSERT_WITH_CODE(!vega10_enable_smc_features(hwmgr->smumgr,
-				true, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
-		"Attempt to Enable LED DPM feature Failed!", return -EINVAL);
-		data->smu_features[GNLD_LED_DISPLAY].enabled = true;
+				false, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
+		"Attempt to diable LED DPM feature Failed!", return -EINVAL);
+		data->smu_features[GNLD_LED_DISPLAY].enabled = false;
 	}
 
 	for (i = 0; i < GNLD_DPM_MAX; i++) {
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1496908250-25003-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 13 lines · Rex Zhu

should disable led dpm feature when stop dpm.

Change-Id I9d78459ff2467d2eba0b26d9696138f7eba484a0
---
  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +0 -0
index 9338aca..b6df00c 100644

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) · line 2706

Quoted 8 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -3
@@ -2702,9 +2702,9 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
 
  	if(data->smu_features[GNLD_LED_DISPLAY].supported == true){
  		PP_ASSERT_WITH_CODE(!vega10_enable_smc_features(hwmgr->smumgr,
-				true, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
-		"Attempt to Enable LED DPM feature Failed!", return -EINVAL);
-		data->smu_features[GNLD_LED_DISPLAY].enabled = true;
+				false, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
+		"Attempt to diable LED DPM feature Failed!", return -EINVAL);

s/diable/disable/

Also, why not make "Failed" lower-case at the same time?

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) · line 2710

Quoted 4 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -0
+		data->smu_features[GNLD_LED_DISPLAY].enabled = false;
  	}
 
  	for (i = 0; i < GNLD_DPM_MAX; i++) {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CY4PR17MB14001A40EC08FFA206779E5BC8C90-wNFeZrXzOlam8K7ZFAZNYX+GY4YGzQ7gvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

author
#4 lore raw
Quoted 3 lines
Quoted 3 lines

s/diable/disable/

Also, why not make "Failed" lower-case at the same time?

Of course. thanks.

Best Regards

Rex

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of William Lewis <[email protected]>
Sent: Thursday, June 8, 2017 8:47:58 PM
To: [email protected]
Subject: Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

Quoted 13 lines · Rex Zhu

should disable led dpm feature when stop dpm.

Change-Id I9d78459ff2467d2eba0b26d9696138f7eba484a0
---
  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +0 -0
index 9338aca..b6df00c 100644

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) · line 2706

Quoted 8 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -3
@@ -2702,9 +2702,9 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
 
       if(data->smu_features[GNLD_LED_DISPLAY].supported == true){
               PP_ASSERT_WITH_CODE(!vega10_enable_smc_features(hwmgr->smumgr,
-                             true, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
-             "Attempt to Enable LED DPM feature Failed!", return -EINVAL);
-             data->smu_features[GNLD_LED_DISPLAY].enabled = true;
+                             false, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
+             "Attempt to diable LED DPM feature Failed!", return -EINVAL);

s/diable/disable/

Also, why not make "Failed" lower-case at the same time?

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) · line 2710

Quoted 4 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -0
+             data->smu_features[GNLD_LED_DISPLAY].enabled = false;
       }
 
       for (i = 0; i < GNLD_DPM_MAX; i++) {

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#5 lore raw
In reply to a message not in the archive
Quoted 13 lines · Rex Zhu

should disable led dpm feature when stop dpm.

Change-Id I9d78459ff2467d2eba0b26d9696138f7eba484a0
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +0 -0
index 9338aca..b6df00c 100644

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) · line 2706

Quoted 8 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -3
@@ -2702,9 +2702,9 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
 
        if(data->smu_features[GNLD_LED_DISPLAY].supported == true){
                PP_ASSERT_WITH_CODE(!vega10_enable_smc_features(hwmgr->smumgr,
-                               true, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
-               "Attempt to Enable LED DPM feature Failed!", return -EINVAL);
-               data->smu_features[GNLD_LED_DISPLAY].enabled = true;
+                               false, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
+               "Attempt to diable LED DPM feature Failed!", return -EINVAL);

"disable"
With that fixed:

Quoted 11 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -1
+               data->smu_features[GNLD_LED_DISPLAY].enabled = false;
        }
 
        for (i = 0; i < GNLD_DPM_MAX; i++) {
--

1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx