Skip to contentSkip to conversation

drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.

PATCH In review Anusha Srivatsa 4 participants 8 messages Jun 8, 2017 – Jun 9, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.

Add PCI Ids for S Sku following the BSpec.

v2: Remove the unused INTEL_CFL_IDS.(Rodrigo)
v3: Add missing IDs(Rodrigo)

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 8 ++++++++
 2 files changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 03a495e..544b3a5 100644
@@ -490,6 +490,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT2_IDS(&intel_kabylake_info),
 	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
 	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
+	INTEL_CFL_S_IDS(&intel_coffeelake_info),
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 	{0, 0, 0}
 };
include/drm/i915_pciids.h +8 -0
index 7d2696a..4858deb 100644
@@ -334,6 +334,14 @@
 	INTEL_KBL_GT3_IDS(info), \
 	INTEL_KBL_GT4_IDS(info)
 
+/* CFL S */
+#define INTEL_CFL_S_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E96, info)  /* SRV GT2 */
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/3 drm/i915/cfl: Add Coffee Lake PCI IDs for H Sku.

Add PCI Ids for H Sku by following the BSpec.

v2: Remove unused INTEL_CFL_IDS.(Rodrigo).
v3: Add missing IDs(Rodrigo)

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 5 +++++
 2 files changed, 6 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 544b3a5..6aa8cbe 100644
@@ -491,6 +491,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
 	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
 	INTEL_CFL_S_IDS(&intel_coffeelake_info),
+	INTEL_CFL_H_IDS(&intel_coffeelake_info),
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 	{0, 0, 0}
 };
include/drm/i915_pciids.h +5 -0
index 4858deb..8f25316 100644
@@ -342,6 +342,11 @@
 	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
 	INTEL_VGA_DEVICE(0x3E96, info)  /* SRV GT2 */
 
+/* CFL H */
+#define INTEL_CFL_H_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
+	INTEL_VGA_DEVICE(0x3E94, info)  /* Halo GT2 */
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] drm/i915/cfl: Add Coffee Lake PCI IDs for H Sku.

Quoted 30 lines · Anusha Srivatsa

Add PCI Ids for H Sku by following the BSpec.

v2: Remove unused INTEL_CFL_IDS.(Rodrigo).
v3: Add missing IDs(Rodrigo)

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 5 +++++
 2 files changed, 6 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 544b3a5..6aa8cbe 100644
@@ -491,6 +491,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
 	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
 	INTEL_CFL_S_IDS(&intel_coffeelake_info),
+	INTEL_CFL_H_IDS(&intel_coffeelake_info),
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 	{0, 0, 0}
 };
include/drm/i915_pciids.h +0 -0
index 4858deb..8f25316 100644
@@ -342,6 +342,11 @@
 	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \

include/drm/i915_pciids.h line 352

Quoted 10 lines
include/drm/i915_pciids.h +5 -0
 	INTEL_VGA_DEVICE(0x3E96, info)  /* SRV GT2 */
 
+/* CFL H */
+#define INTEL_CFL_H_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
+	INTEL_VGA_DEVICE(0x3E94, info)  /* Halo GT2 */
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

PATCH 3/3 drm/i915/cfl: Add Coffee Lake PCI IDs for U Sku.

In reply to Anusha Srivatsa

Add PCI Ids for U Skus of Coffeelake.

v2: Use intel_coffeelake_gt3_info, in accordance to- Rodrigo's patch:

v3: rebased

v3: Remove unused INTEL_CFL_IDS(Rodrigo).

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 7 +++++++
 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 6aa8cbe..15f5891 100644
@@ -492,6 +492,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
 	INTEL_CFL_S_IDS(&intel_coffeelake_info),
 	INTEL_CFL_H_IDS(&intel_coffeelake_info),
+	INTEL_CFL_U_IDS(&intel_coffeelake_gt3_info),
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 	{0, 0, 0}
 };
include/drm/i915_pciids.h +7 -0
index 8f25316..34c8f56 100644
@@ -347,6 +347,13 @@
 	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x3E94, info)  /* Halo GT2 */
 
+/* CFL U */
+#define INTEL_CFL_U_IDS(info) \
+	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v1 3/3
#4 lore raw

Re: [PATCH 3/3] drm/i915/cfl: Add Coffee Lake PCI IDs for U Sku.

Quoted 36 lines · Anusha Srivatsa

Add PCI Ids for U Skus of Coffeelake.

v2: Use intel_coffeelake_gt3_info, in accordance to- Rodrigo's patch:

v3: rebased

v3: Remove unused INTEL_CFL_IDS(Rodrigo).

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 7 +++++++
 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 6aa8cbe..15f5891 100644
@@ -492,6 +492,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
 	INTEL_CFL_S_IDS(&intel_coffeelake_info),
 	INTEL_CFL_H_IDS(&intel_coffeelake_info),
+	INTEL_CFL_U_IDS(&intel_coffeelake_gt3_info),
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 	{0, 0, 0}
 };
include/drm/i915_pciids.h +0 -0
index 8f25316..34c8f56 100644
@@ -347,6 +347,13 @@
 	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
 	INTEL_VGA_DEVICE(0x3E94, info)  /* Halo GT2 */
 

include/drm/i915_pciids.h line 359

Quoted 10 lines
include/drm/i915_pciids.h +7 -0
+/* CFL U */
+#define INTEL_CFL_U_IDS(info) \
+	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [PATCH 3/3] drm/i915/cfl: Add Coffee Lake PCI IDs for U Sku.

Patches merged to dinq.
Thanks for the patches.

Quoted 55 lines · Rodrigo
Quoted 36 lines · Anusha Srivatsa

Add PCI Ids for U Skus of Coffeelake.

v2: Use intel_coffeelake_gt3_info, in accordance to- Rodrigo's patch:

v3: rebased

v3: Remove unused INTEL_CFL_IDS(Rodrigo).

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 7 +++++++
 2 files changed, 8 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 6aa8cbe..15f5891 100644
@@ -492,6 +492,7 @@ static const struct pci_device_id pciidlist[] = {
      INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
      INTEL_CFL_S_IDS(&intel_coffeelake_info),
      INTEL_CFL_H_IDS(&intel_coffeelake_info),
+     INTEL_CFL_U_IDS(&intel_coffeelake_gt3_info),
      INTEL_CNL_IDS(&intel_cannonlake_info),
      {0, 0, 0}
 };
include/drm/i915_pciids.h +0 -0
index 8f25316..34c8f56 100644
@@ -347,6 +347,13 @@
      INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
      INTEL_VGA_DEVICE(0x3E94, info)  /* Halo GT2 */
 

include/drm/i915_pciids.h line 359

Quoted 10 lines
include/drm/i915_pciids.h +7 -0
+/* CFL U */
+#define INTEL_CFL_U_IDS(info) \
+     INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
+     INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+     INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
+     INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
      INTEL_VGA_DEVICE(0x5A52, info), \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v1 1/3
#6 lore raw
In reply to Anusha Srivatsa
Quoted 29 lines · Anusha Srivatsa

Add PCI Ids for S Sku following the BSpec.

v2: Remove the unused INTEL_CFL_IDS.(Rodrigo)
v3: Add missing IDs(Rodrigo)

---
 drivers/gpu/drm/i915/i915_pci.c | 1 +
 include/drm/i915_pciids.h       | 8 ++++++++
 2 files changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_pci.c +1 -0
index 03a495e..544b3a5 100644
@@ -490,6 +490,7 @@ static const struct pci_device_id pciidlist[] = {
 	INTEL_KBL_GT2_IDS(&intel_kabylake_info),
 	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
 	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
+	INTEL_CFL_S_IDS(&intel_coffeelake_info),
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 	{0, 0, 0}
 };
include/drm/i915_pciids.h +0 -0
index 7d2696a..4858deb 100644

include/drm/i915_pciids.h line 343

Quoted 10 lines
include/drm/i915_pciids.h +7 -0
@@ -334,6 +334,14 @@
 	INTEL_KBL_GT3_IDS(info), \
 	INTEL_KBL_GT4_IDS(info)
 
+/* CFL S */
+#define INTEL_CFL_S_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E96, info)  /* SRV GT2 */

let's merge before they add some more hehehe :)

our process include a review during PV cycle, so we will be fine with later changes.

include/drm/i915_pciids.h line 347

Quoted 4 lines
include/drm/i915_pciids.h +1 -0
+
 /* CNL U 2+2 */
 #define INTEL_CNL_U_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A52, info), \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.

In reply to Anusha Srivatsa
== Series Details ==

== Series Details ==

Series: series starting with [1/3] drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.
URL : https://patchwork.freedesktop.org/series/25516/
State : success

== Summary ==

Series 25516v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/25516/revisions/1/mbox/

Test gem_exec_suspend:

        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125
Test kms_busy:
        Subgroup basic-flip-default-a:
                dmesg-warn -> PASS       (fi-skl-6700hq) fdo#101144 +3
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                fail       -> PASS       (fi-skl-6700hq) fdo#101154 +7

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fdo#101154 https://bugs.freedesktop.org/show_bug.cgi?id=101154

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:440s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:432s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:585s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:513s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:483s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:477s
fi-glk-2a        total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:586s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:433s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:411s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:412s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:488s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:465s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:469s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:578s
fi-kbl-r         total:278  pass:259  dwarn:1   dfail:0   fail:0   skip:18  time:580s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:463s
fi-skl-6700hq    total:278  pass:239  dwarn:0   dfail:1   fail:17  skip:21  time:433s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:464s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:502s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:437s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:535s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:398s

5b363842b49a66879d4c67d652923fb04e44b271 drm-tip: 2017y-06m-08d-20h-34m-37s UTC integration manifest 4db8904 drm/i915/cfl: Add Coffee Lake PCI IDs for U Sku.
d9cb548 drm/i915/cfl: Add Coffee Lake PCI IDs for H Sku.
be647f5 drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4918/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx