Skip to contentSkip to conversation

i2c: designware: add I2C SLAVE support

PATCH Superseded Luis Oliveira 4 participants 14 messages Jun 8, 2017 – Jun 9, 2017

Subsystems (4)

v10 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v10 cover i2c: designware: add I2C SLAVE support

The purpose of this patchset is to enable Linux to be a I2C slave by enabling the slave functionality in the designware I2C controller and at the same time it does some cleaning of the existing code.

The patch 1 is for cleaning and commentary fix.
The patch 2 refactors the original i2c-designware-core and extracts all master functions to a i2c-designware-master source file as suggested by Andy Shevchenko when I first submited the update. The patch 3 then separates the MASTER flow from the common flow.
The patch 4 introduces the SLAVE necessary definitions to the i2c-designware library and adds a how-to-use example to the designware.txt in device tree bindings.
The patch 5 adds the necessary functions to give the ability to be a SLAVE to the controller and for that changes also had to be made in the Makefile and Kconfig.
The patch 6 enables the SLAVE mode to be detected by the platform module.

The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here:

https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next

Luis Oliveira (6):
i2c: designware: Cleaning and comment style fixes.
i2c: designware: refactoring of the i2c-designware
i2c: designware: MASTER mode as separated driver
i2c: designware: introducing I2C_SLAVE definitions
i2c: designware: add SLAVE mode functions
i2c: designware: enable SLAVE in platform module

 .../devicetree/bindings/i2c/i2c-designware.txt     |  16 +-
 drivers/i2c/busses/Kconfig                         |  14 +-
 drivers/i2c/busses/Makefile                        |   4 +
 drivers/i2c/busses/i2c-designware-common.c         | 280 +++++++++++++
 drivers/i2c/busses/i2c-designware-core.h           | 182 +++++++-
 ...c-designware-core.c => i2c-designware-master.c} | 465 +++------------------
 drivers/i2c/busses/i2c-designware-pcidrv.c         |   8 +-
 drivers/i2c/busses/i2c-designware-platdrv.c        | 117 ++++--
 drivers/i2c/busses/i2c-designware-slave.c          | 396 ++++++++++++++++++
 9 files changed, 1029 insertions(+), 453 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-designware-common.c
 rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (60%)
 create mode 100644 drivers/i2c/busses/i2c-designware-slave.c
Signature · 1 line
2.13.0
#1 lore raw

PATCH v10 1/6 i2c: designware: Cleaning and comment style fixes.

The purpose of this commit is to fix some comments and styling in the existing code due to the need of reuse this code. What is being made here is:

- Sorted the headers files
- Corrected some comments style (capital letters, lowcase i2c)
- Reverse tree in the variables declaration
- Add/remove empty lines and tabs where needed
- Fix of misspelled word "endianness" and "transferred"
- Replaced the return variable "r" with the more standard "ret"

The value of this, besides the rules of coding style, is because I will use this code after and it will make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering.

---
v9-v10
- no changes

 drivers/i2c/busses/i2c-designware-core.c    | 76 ++++++++++++++---------------
 drivers/i2c/busses/i2c-designware-core.h    |  2 +-
 drivers/i2c/busses/i2c-designware-platdrv.c | 43 ++++++++--------
 3 files changed, 61 insertions(+), 60 deletions(-)
drivers/i2c/busses/i2c-designware-core.c +38 -38
index 3c41995634c2..efe211e8aac5 100644
@@ -21,17 +21,17 @@
  * ----------------------------------------------------------------------------
  *
  */
+#include <linux/delay.h>
 #include <linux/export.h>
 #include <linux/errno.h>
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
 #include <linux/io.h>
-#include <linux/pm_runtime.h>
-#include <linux/delay.h>
 #include <linux/module.h>
-#include "i2c-designware-core.h"
+#include <linux/pm_runtime.h>
 
+#include "i2c-designware-core.h"
 /*
  * Registers offset
  */
@@ -98,7 +98,7 @@
 
 #define DW_IC_ERR_TX_ABRT	0x1
 
-#define DW_IC_TAR_10BITADDR_MASTER BIT(12)
+#define DW_IC_TAR_10BITADDR_MASTER		BIT(12)
 
 #define DW_IC_COMP_PARAM_1_SPEED_MODE_HIGH	(BIT(2) | BIT(3))
 #define DW_IC_COMP_PARAM_1_SPEED_MODE_MASK	GENMASK(3, 2)
@@ -113,10 +113,10 @@
 #define TIMEOUT			20 /* ms */
 
 /*
- * hardware abort codes from the DW_IC_TX_ABRT_SOURCE register
+ * Hardware abort codes from the DW_IC_TX_ABRT_SOURCE register
  *
- * only expected abort codes are listed here
- * refer to the datasheet for the full list
+ * Only expected abort codes are listed here,
+ * refer to the datasheet for the full list.
  */
 #define ABRT_7B_ADDR_NOACK	0
 #define ABRT_10ADDR1_NOACK	1
@@ -318,7 +318,7 @@ static void i2c_dw_release_lock(struct dw_i2c_dev *dev)
 }
 
 /**
- * i2c_dw_init() - initialize the designware i2c master hardware
+ * i2c_dw_init() - Initialize the designware I2C master hardware
  * @dev: device private data
  *
  * This functions configures and enables the I2C master.
@@ -344,8 +344,8 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
 		/* Configure register access mode 16bit */
 		dev->flags |= ACCESS_16BIT;
 	} else if (reg != DW_IC_COMP_TYPE_VALUE) {
-		dev_err(dev->dev, "Unknown Synopsys component type: "
-			"0x%08x\n", reg);
+		dev_err(dev->dev,
+			"Unknown Synopsys component type: 0x%08x\n", reg);
 		i2c_dw_release_lock(dev);
 		return -ENODEV;
 	}
@@ -355,7 +355,7 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
 	/* Disable the adapter */
 	__i2c_dw_enable_and_wait(dev, false);
 
-	/* set standard and fast speed deviders for high/low periods */
+	/* Set standard and fast speed deviders for high/low periods */
 
 	sda_falling_time = dev->sda_falling_time ?: 300; /* ns */
 	scl_falling_time = dev->scl_falling_time ?: 300; /* ns */
@@ -444,7 +444,7 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
 	dw_writel(dev, dev->tx_fifo_depth / 2, DW_IC_TX_TL);
 	dw_writel(dev, 0, DW_IC_RX_TL);
 
-	/* configure the i2c master */
+	/* Configure the I2C master */
 	dw_writel(dev, dev->master_cfg , DW_IC_CON);
 
 	i2c_dw_release_lock(dev);
@@ -480,7 +480,7 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
 	/* Disable the adapter */
 	__i2c_dw_enable_and_wait(dev, false);
 
-	/* if the slave address is ten bit address, enable 10BITADDR */
+	/* If the slave address is ten bit address, enable 10BITADDR */
 	ic_con = dw_readl(dev, DW_IC_CON);
 	if (msgs[dev->msg_write_idx].flags & I2C_M_TEN) {
 		ic_con |= DW_IC_CON_10BITADDR_MASTER;
@@ -503,7 +503,7 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
 	 */
 	dw_writel(dev, msgs[dev->msg_write_idx].addr | ic_tar, DW_IC_TAR);
 
-	/* enforce disabled interrupts (due to HW issues) */
+	/* Enforce disabled interrupts (due to HW issues) */
 	i2c_dw_disable_int(dev);
 
 	/* Enable the adapter */
@@ -537,9 +537,9 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)
 		u32 flags = msgs[dev->msg_write_idx].flags;
 
 		/*
-		 * if target address has changed, we need to
-		 * reprogram the target address in the i2c
-		 * adapter when we are done with this transfer
+		 * If target address has changed, we need to
+		 * reprogram the target address in the I2C
+		 * adapter when we are done with this transfer.
 		 */
 		if (msgs[dev->msg_write_idx].addr != addr) {
 			dev_err(dev->dev,
@@ -599,7 +599,7 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)
 
 			if (msgs[dev->msg_write_idx].flags & I2C_M_RD) {
 
-				/* avoid rx buffer overrun */
+				/* Avoid rx buffer overrun */
 				if (dev->rx_outstanding >= dev->rx_fifo_depth)
 					break;
 
@@ -728,7 +728,7 @@ static int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev)
 }
 
 /*
- * Prepare controller for a transaction and call i2c_dw_xfer_msg
+ * Prepare controller for a transaction and call i2c_dw_xfer_msg.
  */
 static int
 i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
@@ -759,10 +759,10 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
 	if (ret < 0)
 		goto done;
 
-	/* start the transfers */
+	/* Start the transfers */
 	i2c_dw_xfer_init(dev);
 
-	/* wait for tx to complete */
+	/* Wait for tx to complete */
 	if (!wait_for_completion_timeout(&dev->cmd_complete, adap->timeout)) {
 		dev_err(dev->dev, "controller timed out\n");
 		/* i2c_dw_init implicitly disables the adapter */
@@ -786,7 +786,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
 		goto done;
 	}
 
-	/* no error */
+	/* No error */
 	if (likely(!dev->cmd_err && !dev->status)) {
 		ret = num;
 		goto done;
@@ -821,8 +821,8 @@ static u32 i2c_dw_func(struct i2c_adapter *adap)
 }
 
 static const struct i2c_algorithm i2c_dw_algo = {
-	.master_xfer	= i2c_dw_xfer,
-	.functionality	= i2c_dw_func,
+	.master_xfer = i2c_dw_xfer,
+	.functionality = i2c_dw_func,
 };
 
 static u32 i2c_dw_read_clear_intrbits(struct dw_i2c_dev *dev)
@@ -903,7 +903,7 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
 
 		/*
 		 * Anytime TX_ABRT is set, the contents of the tx/rx
-		 * buffers are flushed.  Make sure to skip them.
+		 * buffers are flushed. Make sure to skip them.
 		 */
 		dw_writel(dev, 0, DW_IC_INTR_MASK);
 		goto tx_aborted;
@@ -925,7 +925,7 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
 	if ((stat & (DW_IC_INTR_TX_ABRT | DW_IC_INTR_STOP_DET)) || dev->msg_err)
 		complete(&dev->cmd_complete);
 	else if (unlikely(dev->flags & ACCESS_INTR_MASK)) {
-		/* workaround to trigger pending interrupt */
+		/* Workaround to trigger pending interrupt */
 		stat = dw_readl(dev, DW_IC_INTR_MASK);
 		i2c_dw_disable_int(dev);
 		dw_writel(dev, stat, DW_IC_INTR_MASK);
@@ -961,13 +961,13 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 {
 	struct i2c_adapter *adap = &dev->adapter;
 	unsigned long irq_flags;
-	int r;
+	int ret;
 
 	init_completion(&dev->cmd_complete);
 
-	r = i2c_dw_init(dev);
-	if (r)
-		return r;
+	ret = i2c_dw_init(dev);
+	if (ret)
+		return ret;
 
 	snprintf(adap->name, sizeof(adap->name),
 		 "Synopsys DesignWare I2C adapter");
@@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 	}
 
 	i2c_dw_disable_int(dev);
-	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
+	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
 			     dev_name(dev->dev), dev);
-	if (r) {
+	if (ret) {
 		dev_err(dev->dev, "failure requesting irq %i: %d\n",
-			dev->irq, r);
-		return r;
+			dev->irq, ret);
+		return ret;
 	}
 
 	/*
@@ -999,12 +999,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 	 * registered I2C slaves that do I2C transfers in their probe.
 	 */
 	pm_runtime_get_noresume(dev->dev);
-	r = i2c_add_numbered_adapter(adap);
-	if (r)
-		dev_err(dev->dev, "failure adding adapter: %d\n", r);
+	ret = i2c_add_numbered_adapter(adap);
+	if (ret)
+		dev_err(dev->dev, "failure adding adapter: %d\n", ret);
 	pm_runtime_put_noidle(dev->dev);
 
-	return r;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(i2c_dw_probe);
 
drivers/i2c/busses/i2c-designware-core.h +1 -1
index a7cf429daf60..fe9b66898a72 100644
@@ -49,7 +49,7 @@
  * @cmd_complete: tx completion indicator
  * @clk: input reference clock
  * @cmd_err: run time hadware error code
- * @msgs: points to an array of messages currently being transfered
+ * @msgs: points to an array of messages currently being transferred
  * @msgs_num: the number of elements in msgs
  * @msg_write_idx: the element index of the current tx message in the msgs
  *	array
drivers/i2c/busses/i2c-designware-platdrv.c +22 -21

97 lines not on this page · raw message

Signature · 1 line
2.13.0
#2 lore raw

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

Quoted 2 lines · Luis Oliveira

complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering.

I challenge that. If there is an old bug that existed before this patch that is fixed in the future after this patch has been applied, it might very well be hard_er_ to backport that fix to a point before this patch has been applied. So, what do you mean?

drivers/i2c/busses/i2c-designware-core.c int i2c_dw_probe(struct dw_i2c_dev *dev) · line 988

Quoted 7 lines
drivers/i2c/busses/i2c-designware-core.c +1 -1
@@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 	}
 
 	i2c_dw_disable_int(dev);
-	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
+	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
 			     dev_name(dev->dev), dev);

Two extra spaces needed to align with the opening bracket.

Cheers,
peda

#3 lore raw

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

Quoted 9 lines · Peter Rosin
Quoted 2 lines · Luis Oliveira

complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering.

I challenge that. If there is an old bug that existed before this patch that is fixed in the future after this patch has been applied, it might very well be hard_er_ to backport that fix to a point before this patch has been applied. So, what do you mean?

Yes, that's true. But it will not be that hard since it's mostly style (comments, format, return variables, misspelled words).
For my humble point of view the code looks better after this patch is applied. So if It's more easy to read it should be more easy to fix also if needed.

Quoted 10 lines

drivers/i2c/busses/i2c-designware-core.c int i2c_dw_probe(struct dw_i2c_dev *dev) · line 988

Quoted 7 lines
drivers/i2c/busses/i2c-designware-core.c +1 -1
@@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 	}
 
 	i2c_dw_disable_int(dev);
-	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
+	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
 			     dev_name(dev->dev), dev);

Two extra spaces needed to align with the opening bracket.

Thank you, you are right.

Quoted 3 lines

Cheers,
peda

Cheers,
Luis
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

In reply to Peter Rosin
Quoted 5 lines · Peter Rosin
Quoted 3 lines · Luis Oliveira

complicated to review. The work here won't bring any additional work to
backported fixes because is just style and reordering.

Quoted 7 lines

I challenge that. If there is an old bug that existed before this patch
that is fixed in the future after this patch has been applied, it might
very well be hard_er_ to backport that fix to a point before this patch
has been applied. So, what do you mean?

I asked this during review of ~v3. I don't remember what Wolfram told about it.

Quoted 13 lines
Quoted 10 lines
(quoted diff) +0 -0
@@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
  	}


  i2c_dw_disable_int(dev);

(quoted diff) +0 -1
-	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,

irq_flags,

(quoted diff) +1 -0
+	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,

irq_flags,
       dev_name(dev->dev), dev);

Two extra spaces needed to align with the opening bracket.

It's a bikeshedding, though it looks like v11 is needed anyway (see kbuild bot complains), thus it might be addressed as well.

Signature · 6 lines
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/[email protected]>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#5 lore raw

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

Quoted 13 lines · Andy Shevchenko
Quoted 11 lines · Peter Rosin
Quoted 9 lines · Luis Oliveira
drivers/i2c/busses/i2c-designware-core.c +1 -1
@@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
 	}
 
 	i2c_dw_disable_int(dev);
-	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
 irq_flags,
+	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
 irq_flags,
 			     dev_name(dev->dev), dev);
Quoted 5 lines
Quoted 1 line

Two extra spaces needed to align with the opening bracket.

It's a bikeshedding, though it looks like v11 is needed anyway (see kbuild bot complains), thus it might be addressed as well.

Bikeshedding or not, checkpatch.pl --strict notifies about the issue with:

CHECK: Alignment should match open parenthesis

Cheers,
peda

#6 lore raw

PATCH v10 2/6 i2c: designware: refactoring of the i2c-designware

In reply to Luis Oliveira

- Factor out all _master() part of code from i2c-designware-core and i2c-designware-platdrv to separate functions.
- Standardize all code related with MASTER mode.
- I have to take off DW_IC_INTR_TX_EMPTY from DW_IC_INTR_DEFAULT_MASK because it is master specific.

The purpose of this is to prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified.

---
v9-v10
- no changes

 drivers/i2c/busses/i2c-designware-core.c    | 56 +++++++++++++++++------------
 drivers/i2c/busses/i2c-designware-platdrv.c | 31 +++++++++-------
 2 files changed, 52 insertions(+), 35 deletions(-)
drivers/i2c/busses/i2c-designware-core.c +34 -22
index efe211e8aac5..c45a4ae14d25 100644
@@ -87,10 +87,10 @@
 #define DW_IC_INTR_GEN_CALL	0x800
 
 #define DW_IC_INTR_DEFAULT_MASK		(DW_IC_INTR_RX_FULL | \
-					 DW_IC_INTR_TX_EMPTY | \
 					 DW_IC_INTR_TX_ABRT | \
 					 DW_IC_INTR_STOP_DET)
-
+#define DW_IC_INTR_MASTER_MASK		(DW_IC_INTR_DEFAULT_MASK | \
+					 DW_IC_INTR_TX_EMPTY)
 #define DW_IC_STATUS_ACTIVITY	0x1
 
 #define DW_IC_SDA_HOLD_RX_SHIFT		16
@@ -202,6 +202,16 @@ static void dw_writel(struct dw_i2c_dev *dev, u32 b, int offset)
 	}
 }
 
+static void i2c_dw_configure_fifo_master(struct dw_i2c_dev *dev)
+{
+	/* Configure Tx/Rx FIFO threshold levels */
+	dw_writel(dev, dev->tx_fifo_depth / 2, DW_IC_TX_TL);
+	dw_writel(dev, 0, DW_IC_RX_TL);
+
+	/* Configure the I2C master */
+	dw_writel(dev, dev->master_cfg, DW_IC_CON);
+}
+
 static u32
 i2c_dw_scl_hcnt(u32 ic_clk, u32 tSYMBOL, u32 tf, int cond, int offset)
 {
@@ -440,13 +450,7 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
 			"Hardware too old to adjust SDA hold time.\n");
 	}
 
-	/* Configure Tx/Rx FIFO threshold levels */
-	dw_writel(dev, dev->tx_fifo_depth / 2, DW_IC_TX_TL);
-	dw_writel(dev, 0, DW_IC_RX_TL);
-
-	/* Configure the I2C master */
-	dw_writel(dev, dev->master_cfg , DW_IC_CON);
-
+	i2c_dw_configure_fifo_master(dev);
 	i2c_dw_release_lock(dev);
 
 	return 0;
@@ -511,7 +515,7 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
 
 	/* Clear and enable interrupts */
 	dw_readl(dev, DW_IC_CLR_INTR);
-	dw_writel(dev, DW_IC_INTR_DEFAULT_MASK, DW_IC_INTR_MASK);
+	dw_writel(dev, DW_IC_INTR_MASTER_MASK, DW_IC_INTR_MASK);
 }
 
 /*
@@ -531,7 +535,7 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)
 	u8 *buf = dev->tx_buf;
 	bool need_restart = false;
 
-	intr_mask = DW_IC_INTR_DEFAULT_MASK;
+	intr_mask = DW_IC_INTR_MASTER_MASK;
 
 	for (; dev->msg_write_idx < dev->msgs_num; dev->msg_write_idx++) {
 		u32 flags = msgs[dev->msg_write_idx].flags;
@@ -881,22 +885,14 @@ static u32 i2c_dw_read_clear_intrbits(struct dw_i2c_dev *dev)
 }
 
 /*
- * Interrupt service routine. This gets called whenever an I2C interrupt
+ * Interrupt service routine. This gets called whenever an I2C master interrupt
  * occurs.
  */
-static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
+static int i2c_dw_irq_handler_master(struct dw_i2c_dev *dev)
 {
-	struct dw_i2c_dev *dev = dev_id;
-	u32 stat, enabled;
-
-	enabled = dw_readl(dev, DW_IC_ENABLE);
-	stat = dw_readl(dev, DW_IC_RAW_INTR_STAT);
-	dev_dbg(dev->dev, "%s: enabled=%#x stat=%#x\n", __func__, enabled, stat);
-	if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
-		return IRQ_NONE;
+	u32 stat;
 
 	stat = i2c_dw_read_clear_intrbits(dev);
-
 	if (stat & DW_IC_INTR_TX_ABRT) {
 		dev->cmd_err |= DW_IC_ERR_TX_ABRT;
 		dev->status = STATUS_IDLE;
@@ -931,6 +927,22 @@ static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
 		dw_writel(dev, stat, DW_IC_INTR_MASK);
 	}
 
+	return 0;
+}
+
+static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
+{
+	struct dw_i2c_dev *dev = dev_id;
+	u32 stat, enabled;
+
+	enabled = dw_readl(dev, DW_IC_ENABLE);
+	stat = dw_readl(dev, DW_IC_RAW_INTR_STAT);
+	dev_dbg(dev->dev, "enabled=%#x stat=%#x\n", enabled, stat);
+	if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
+		return IRQ_NONE;
+
+	i2c_dw_irq_handler_master(dev);
+
 	return IRQ_HANDLED;
 }
 
drivers/i2c/busses/i2c-designware-platdrv.c +18 -13
index 613dfb88307f..fd14b410369e 100644
@@ -172,6 +172,23 @@ static inline int dw_i2c_acpi_configure(struct platform_device *pdev)
 }
 #endif
 
+static void i2c_dw_configure_master(struct dw_i2c_dev *dev)
+{
+	dev->master_cfg = DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
+			  DW_IC_CON_RESTART_EN;
+
+	switch (dev->clk_freq) {
+	case 100000:
+		dev->master_cfg |= DW_IC_CON_SPEED_STD;
+		break;
+	case 3400000:
+		dev->master_cfg |= DW_IC_CON_SPEED_HIGH;
+		break;
+	default:
+		dev->master_cfg |= DW_IC_CON_SPEED_FAST;
+	}
+}
+
 static int i2c_dw_plat_prepare_clk(struct dw_i2c_dev *i_dev, bool prepare)
 {
 	if (IS_ERR(i_dev->clk))
@@ -287,19 +304,7 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
 
 	dev->functionality = I2C_FUNC_10BIT_ADDR | DW_IC_DEFAULT_FUNCTIONALITY;
 
-	dev->master_cfg = DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
-			  DW_IC_CON_RESTART_EN;
-
-	switch (dev->clk_freq) {
-	case 100000:
-		dev->master_cfg |= DW_IC_CON_SPEED_STD;
-		break;
-	case 3400000:
-		dev->master_cfg |= DW_IC_CON_SPEED_HIGH;
-		break;
-	default:
-		dev->master_cfg |= DW_IC_CON_SPEED_FAST;
-	}
+	i2c_dw_configure_master(dev);
 
 	dev->clk = devm_clk_get(&pdev->dev, NULL);
 	if (!i2c_dw_plat_prepare_clk(dev, true)) {
Signature · 7 lines
2.13.0


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#7 lore raw

PATCH v10 3/6 i2c: designware: MASTER mode as separated driver

In reply to Luis Oliveira

- The functions related to I2C master mode of operation were transformed in a single driver.
- Common definitions were moved to i2c-designware-core.h
- The i2c-designware-core is now only a library file, the functions associated are in a source file called i2c-designware-common and are used by both i2c-designware-master and i2c-designware-slave.
- To decrease noise in namespace common i2c_dw_*() functions are now using ops to keep them private.
- Designware PCI driver had to be changed to match the previous ops functions implementation.

Almost all of the "core" source is now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file.

---
v9-v10
- no changes

 drivers/i2c/busses/Makefile                        |   1 +
 drivers/i2c/busses/i2c-designware-common.c         | 274 +++++++++++++++
 drivers/i2c/busses/i2c-designware-core.h           | 145 +++++++-
 ...c-designware-core.c => i2c-designware-master.c} | 367 +--------------------
 drivers/i2c/busses/i2c-designware-pcidrv.c         |   8 +-
 drivers/i2c/busses/i2c-designware-platdrv.c        |   6 +-
 6 files changed, 432 insertions(+), 369 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-designware-common.c
 rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (65%)
drivers/i2c/busses/Makefile +1 -0
index 30b60855fbcd..c89a4314c563 100644
@@ -40,6 +40,7 @@ obj-$(CONFIG_I2C_CBUS_GPIO)	+= i2c-cbus-gpio.o
 obj-$(CONFIG_I2C_CPM)		+= i2c-cpm.o
 obj-$(CONFIG_I2C_DAVINCI)	+= i2c-davinci.o
 obj-$(CONFIG_I2C_DESIGNWARE_CORE)	+= i2c-designware-core.o
+i2c-designware-core-objs := i2c-designware-common.o i2c-designware-master.o
 obj-$(CONFIG_I2C_DESIGNWARE_PLATFORM)	+= i2c-designware-platform.o
 i2c-designware-platform-objs := i2c-designware-platdrv.o
 i2c-designware-platform-$(CONFIG_I2C_DESIGNWARE_BAYTRAIL) += i2c-designware-baytrail.o
drivers/i2c/busses/i2c-designware-common.c new file +274 -0

274 lines not on this page · raw message

drivers/i2c/busses/i2c-designware-core.h +141 -4

169 lines not on this page · raw message

drivers/i2c/busses/i2c-designware-master.c renamed from drivers/i2c/busses/i2c-designware-core.c +8 -359

420 lines not on this page · raw message

drivers/i2c/busses/i2c-designware-pcidrv.c +5 -3
index ed485b69b449..b582a5f2fb94 100644
@@ -187,16 +187,18 @@ static struct dw_pci_controller dw_pci_controllers[] = {
 static int i2c_dw_pci_suspend(struct device *dev)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
+	struct dw_i2c_dev *i_dev = pci_get_drvdata(pdev);
+	i_dev->disable(i_dev);
 
-	i2c_dw_disable(pci_get_drvdata(pdev));
 	return 0;
 }
 
 static int i2c_dw_pci_resume(struct device *dev)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
+	struct dw_i2c_dev *i_dev = pci_get_drvdata(pdev);
 
-	return i2c_dw_init(pci_get_drvdata(pdev));
+	return i_dev->init(i_dev);
 }
 #endif
 
@@ -296,7 +298,7 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev)
 {
 	struct dw_i2c_dev *dev = pci_get_drvdata(pdev);
 
-	i2c_dw_disable(dev);
+	dev->disable(dev);
 	pm_runtime_forbid(&pdev->dev);
 	pm_runtime_get_noresume(&pdev->dev);
 
drivers/i2c/busses/i2c-designware-platdrv.c +3 -3
index fd14b410369e..1f38c807be5f 100644
@@ -356,7 +356,7 @@ static int dw_i2c_plat_remove(struct platform_device *pdev)
 
 	i2c_del_adapter(&dev->adapter);
 
-	i2c_dw_disable(dev);
+	dev->disable(dev);
 
 	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_put_sync(&pdev->dev);
@@ -400,7 +400,7 @@ static int dw_i2c_plat_suspend(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	struct dw_i2c_dev *i_dev = platform_get_drvdata(pdev);
 
-	i2c_dw_disable(i_dev);
+	i_dev->disable(i_dev);
 	i2c_dw_plat_prepare_clk(i_dev, false);
 
 	return 0;
@@ -412,7 +412,7 @@ static int dw_i2c_plat_resume(struct device *dev)
 	struct dw_i2c_dev *i_dev = platform_get_drvdata(pdev);
 
 	i2c_dw_plat_prepare_clk(i_dev, true);
-	i2c_dw_init(i_dev);
+	i_dev->init(i_dev);
 
 	return 0;
 }
Signature · 1 line
2.13.0
#8 lore raw

PATCH v10 4/6 i2c: designware: introducing I2C_SLAVE definitions

In reply to Luis Oliveira

- Definitions were added to core library
- A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS

SLAVE related definitions were added to the core of the controller.

---
v9-v10
- no changes

 .../devicetree/bindings/i2c/i2c-designware.txt     | 16 ++++++++++-
 drivers/i2c/busses/i2c-designware-core.h           | 33 ++++++++++++++++++++--
 2 files changed, 46 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-designware.txt +15 -1
index fee26dc3e858..fbb0a6d8b964 100644
@@ -20,7 +20,7 @@ Optional properties :
  - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds.
    This value which is by default 300ns is used to compute the tHIGH period.
 
-Example :
+Examples :
 
 	i2c@f0000 {
 		#address-cells = <1>;
@@ -43,3 +43,17 @@ Example :
 		i2c-sda-falling-time-ns = <300>;
 		i2c-scl-falling-time-ns = <300>;
 	};
+
+	i2c@1120000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x2000 0x100>;
+		clock-frequency = <400000>;
+		clocks = <&i2cclk>;
+		interrupts = <0>;
+
+		eeprom@64 {
+			compatible = "linux,slave-24c02";
+			reg = <0x40000064>;
+		};
+	};
drivers/i2c/busses/i2c-designware-core.h +31 -2
index 81b46c8529fa..dc20ef079fc1 100644
@@ -1,5 +1,5 @@
 /*
- * Synopsys DesignWare I2C adapter driver (master only).
+ * Synopsys DesignWare I2C adapter driver.
  *
  * Based on the TI DAVINCI I2C adapter driver.
  *
@@ -37,15 +37,20 @@
 #define DW_IC_CON_SPEED_FAST		0x4
 #define DW_IC_CON_SPEED_HIGH		0x6
 #define DW_IC_CON_SPEED_MASK		0x6
+#define DW_IC_CON_10BITADDR_SLAVE		0x8
 #define DW_IC_CON_10BITADDR_MASTER	0x10
 #define DW_IC_CON_RESTART_EN		0x20
 #define DW_IC_CON_SLAVE_DISABLE		0x40
+#define DW_IC_CON_STOP_DET_IFADDRESSED		0x80
+#define DW_IC_CON_TX_EMPTY_CTRL		0x100
+#define DW_IC_CON_RX_FIFO_FULL_HLD_CTRL		0x200
 
 /*
  * Registers offset
  */
 #define DW_IC_CON		0x0
 #define DW_IC_TAR		0x4
+#define DW_IC_SAR		0x8
 #define DW_IC_DATA_CMD		0x10
 #define DW_IC_SS_SCL_HCNT	0x14
 #define DW_IC_SS_SCL_LCNT	0x18
@@ -76,6 +81,7 @@
 #define DW_IC_SDA_HOLD		0x7c
 #define DW_IC_TX_ABRT_SOURCE	0x80
 #define DW_IC_ENABLE_STATUS	0x9c
+#define DW_IC_CLR_RESTART_DET	0xa8
 #define DW_IC_COMP_PARAM_1	0xf4
 #define DW_IC_COMP_VERSION	0xf8
 #define DW_IC_SDA_HOLD_MIN_VERS	0x3131312A
@@ -94,15 +100,22 @@
 #define DW_IC_INTR_STOP_DET	0x200
 #define DW_IC_INTR_START_DET	0x400
 #define DW_IC_INTR_GEN_CALL	0x800
+#define DW_IC_INTR_RESTART_DET	0x1000
 
 #define DW_IC_INTR_DEFAULT_MASK		(DW_IC_INTR_RX_FULL | \
 					 DW_IC_INTR_TX_ABRT | \
 					 DW_IC_INTR_STOP_DET)
 #define DW_IC_INTR_MASTER_MASK		(DW_IC_INTR_DEFAULT_MASK | \
 					 DW_IC_INTR_TX_EMPTY)
+#define DW_IC_INTR_SLAVE_MASK		(DW_IC_INTR_DEFAULT_MASK | \
+					 DW_IC_INTR_RX_DONE | \
+					 DW_IC_INTR_RX_UNDER | \
+					 DW_IC_INTR_RD_REQ)
+
 #define DW_IC_STATUS_ACTIVITY		0x1
 #define DW_IC_STATUS_TFE		BIT(2)
 #define DW_IC_STATUS_MASTER_ACTIVITY	BIT(5)
+#define DW_IC_STATUS_SLAVE_ACTIVITY	BIT(6)
 
 #define DW_IC_SDA_HOLD_RX_SHIFT		16
 #define DW_IC_SDA_HOLD_RX_MASK		GENMASK(23, DW_IC_SDA_HOLD_RX_SHIFT)
@@ -115,7 +128,7 @@
 #define DW_IC_COMP_PARAM_1_SPEED_MODE_MASK	GENMASK(3, 2)
 
 /*
- * Status codes
+ * status codes
  */
 #define STATUS_IDLE			0x0
 #define STATUS_WRITE_IN_PROGRESS	0x1
@@ -124,6 +137,12 @@
 #define TIMEOUT			20 /* ms */
 
 /*
+ * operation modes
+ */
+#define DW_IC_MASTER		0
+#define DW_IC_SLAVE		1
+
+/*
  * Hardware abort codes from the DW_IC_TX_ABRT_SOURCE register
  *
  * Only expected abort codes are listed here
@@ -140,6 +159,9 @@
 #define ABRT_10B_RD_NORSTRT	10
 #define ABRT_MASTER_DIS		11
 #define ARB_LOST		12
+#define ABRT_SLAVE_FLUSH_TXFIFO	13
+#define ABRT_SLAVE_ARBLOST	14
+#define ABRT_SLAVE_RD_INTX	15
 
 #define DW_IC_TX_ABRT_7B_ADDR_NOACK	(1UL << ABRT_7B_ADDR_NOACK)
 #define DW_IC_TX_ABRT_10ADDR1_NOACK	(1UL << ABRT_10ADDR1_NOACK)
@@ -152,6 +174,9 @@
 #define DW_IC_TX_ABRT_10B_RD_NORSTRT	(1UL << ABRT_10B_RD_NORSTRT)
 #define DW_IC_TX_ABRT_MASTER_DIS	(1UL << ABRT_MASTER_DIS)
 #define DW_IC_TX_ARB_LOST		(1UL << ARB_LOST)
+#define DW_IC_RX_ABRT_SLAVE_RD_INTX	(1UL << ABRT_SLAVE_RD_INTX)
+#define DW_IC_RX_ABRT_SLAVE_ARBLOST	(1UL << ABRT_SLAVE_ARBLOST)
+#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIFO	(1UL << ABRT_SLAVE_FLUSH_TXFIFO)
 
 #define DW_IC_TX_ABRT_NOACK		(DW_IC_TX_ABRT_7B_ADDR_NOACK | \
 					 DW_IC_TX_ABRT_10ADDR1_NOACK | \
@@ -166,6 +191,7 @@
  * @base: IO registers pointer
  * @cmd_complete: tx completion indicator
  * @clk: input reference clock
+ * @slave: represent an I2C slave device
  * @cmd_err: run time hadware error code
  * @msgs: points to an array of messages currently being transferred
  * @msgs_num: the number of elements in msgs
@@ -182,6 +208,7 @@
  * @abort_source: copy of the TX_ABRT_SOURCE register
  * @irq: interrupt number for the i2c master
  * @adapter: i2c subsystem adapter node
+ * @slave_cfg: configuration for the slave device
  * @tx_fifo_depth: depth of the hardware tx fifo
  * @rx_fifo_depth: depth of the hardware rx fifo
  * @rx_outstanding: current master-rx elements in tx fifo
@@ -212,6 +239,7 @@ struct dw_i2c_dev {
 	struct completion	cmd_complete;
 	struct clk		*clk;
 	struct reset_control	*rst;
+	struct i2c_client		*slave;
 	u32			(*get_clk_rate_khz) (struct dw_i2c_dev *dev);
 	struct dw_pci_controller *controller;
 	int			cmd_err;
@@ -231,6 +259,7 @@ struct dw_i2c_dev {
 	struct i2c_adapter	adapter;
 	u32			functionality;
 	u32			master_cfg;
+	u32			slave_cfg;
 	unsigned int		tx_fifo_depth;
 	unsigned int		rx_fifo_depth;
 	int			rx_outstanding;
Signature · 1 line
2.13.0
#9 lore raw

PATCH v10 5/6 i2c: designware: add SLAVE mode functions

In reply to Luis Oliveira

- Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
- Slave functions added to core library file
- Slave abort sources added to common source file
- New driver: i2c-designware-slave added
- Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module when supported by the architecture.

All the SLAVE flow is added but it is not enabled via platform driver.

---
v9-v10 (@Andy)
- Fixed Makefile selection of I2C_DESIGNWARE_SLAVE as suggested
- Corrected wrong comments
- Little refactoring on irq_handler_slave flow

 drivers/i2c/busses/Kconfig                 |  13 +-
 drivers/i2c/busses/Makefile                |   3 +
 drivers/i2c/busses/i2c-designware-common.c |   6 +
 drivers/i2c/busses/i2c-designware-core.h   |   2 +
 drivers/i2c/busses/i2c-designware-slave.c  | 396 +++++++++++++++++++++++++++++
 5 files changed, 419 insertions(+), 1 deletion(-)
 create mode 100644 drivers/i2c/busses/i2c-designware-slave.c
drivers/i2c/busses/Kconfig +12 -1
index 144cbadc7c72..88e5062015f8 100644
@@ -474,11 +474,22 @@ config I2C_DESIGNWARE_PLATFORM
 	depends on (ACPI && COMMON_CLK) || !ACPI
 	help
 	  If you say yes to this option, support will be included for the
-	  Synopsys DesignWare I2C adapter. Only master mode is supported.
+	  Synopsys DesignWare I2C adapter.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-designware-platform.
 
+config I2C_DESIGNWARE_SLAVE
+	bool "Synopsys DesignWare Slave"
+	select I2C_SLAVE
+	depends on I2C_DESIGNWARE_PLATFORM
+	help
+	  If you say yes to this option, support will be included for the
+	  Synopsys DesignWare I2C slave adapter.
+
+	  This is not a standalone module, this module compiles together with
+	  i2c-designware-core.
+
 config I2C_DESIGNWARE_PCI
 	tristate "Synopsys DesignWare PCI"
 	depends on PCI
drivers/i2c/busses/Makefile +3 -0
index c89a4314c563..142f1b3a96c2 100644
@@ -41,6 +41,9 @@ obj-$(CONFIG_I2C_CPM)		+= i2c-cpm.o
 obj-$(CONFIG_I2C_DAVINCI)	+= i2c-davinci.o
 obj-$(CONFIG_I2C_DESIGNWARE_CORE)	+= i2c-designware-core.o
 i2c-designware-core-objs := i2c-designware-common.o i2c-designware-master.o
+ifneq ($(CONFIG_I2C_DESIGNWARE_SLAVE),n)
+i2c-designware-core-objs += i2c-designware-slave.o
+endif
 obj-$(CONFIG_I2C_DESIGNWARE_PLATFORM)	+= i2c-designware-platform.o
 i2c-designware-platform-objs := i2c-designware-platdrv.o
 i2c-designware-platform-$(CONFIG_I2C_DESIGNWARE_BAYTRAIL) += i2c-designware-baytrail.o
drivers/i2c/busses/i2c-designware-common.c +6 -0
index 98b64e4f5977..fcd9d6bb8897 100644
@@ -56,6 +56,12 @@ static char *abort_sources[] = {
 		"trying to use disabled adapter",
 	[ARB_LOST] =
 		"lost arbitration",
+	[ABRT_SLAVE_FLUSH_TXFIFO] =
+		"read command so flush old data in the TX FIFO",
+	[ABRT_SLAVE_ARBLOST] =
+		"slave lost the bus while transmitting data to a remote master",
+	[ABRT_SLAVE_RD_INTX] =
+		"incorrect slave-transmitter mode configuration",
 };
 
 u32 dw_readl(struct dw_i2c_dev *dev, int offset)
drivers/i2c/busses/i2c-designware-core.h +2 -0
index dc20ef079fc1..8c6fc8384b1e 100644
@@ -305,9 +305,11 @@ u32 i2c_dw_func(struct i2c_adapter *adap);
 void i2c_dw_disable(struct dw_i2c_dev *dev);
 void i2c_dw_disable_int(struct dw_i2c_dev *dev);
 int i2c_dw_init(struct dw_i2c_dev *dev);
+int i2c_dw_init_slave(struct dw_i2c_dev *dev);
 
 extern u32 i2c_dw_read_comp_param(struct dw_i2c_dev *dev);
 extern int i2c_dw_probe(struct dw_i2c_dev *dev);
+extern int i2c_dw_probe_slave(struct dw_i2c_dev *dev);
 
 #if IS_ENABLED(CONFIG_I2C_DESIGNWARE_BAYTRAIL)
 extern int i2c_dw_probe_lock_support(struct dw_i2c_dev *dev);
drivers/i2c/busses/i2c-designware-slave.c new file +396 -0

396 lines not on this page · raw message

Signature · 1 line
2.13.0
#10 lore raw

Re: [PATCH v10 5/6] i2c: designware: add SLAVE mode functions

reproduce:

Hi Luis,

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.12-rc4 next-20170608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Luis-Oliveira/i2c-designware-add-I2C-SLAVE-support/20170609-143533
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: x86_64-randconfig-x012-201723 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

drivers/i2c/busses/i2c-designware-slave.c: In function 'i2c_dw_irq_handler_slave':

>> drivers/i2c/busses/i2c-designware-slave.c:285:3: error: implicit declaration of function 'i2c_slave_event' [-Werror=implicit-function-declaration]
      i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val);
      ^~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:285:31: error: 'I2C_SLAVE_WRITE_REQUESTED' undeclared (first use in this function)
      i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val);
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c:285:31: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/i2c/busses/i2c-designware-slave.c:293:9: error: 'I2C_SLAVE_WRITE_RECEIVED' undeclared (first use in this function)
            I2C_SLAVE_WRITE_RECEIVED, &val)) {
            ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:305:8: error: 'I2C_SLAVE_READ_REQUESTED' undeclared (first use in this function)
           I2C_SLAVE_READ_REQUESTED, &val))
           ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:311:36: error: 'I2C_SLAVE_READ_PROCESSED' undeclared (first use in this function)
      if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED,
                                       ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-designware-slave.c:315:31: error: 'I2C_SLAVE_STOP' undeclared (first use in this function)
      i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
                                  ^~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c: At top level:
>> drivers/i2c/busses/i2c-designware-slave.c:351:2: error: unknown field 'reg_slave' specified in initializer
     .reg_slave = i2c_dw_reg_slave,
     ^
>> drivers/i2c/busses/i2c-designware-slave.c:351:15: warning: excess elements in struct initializer
     .reg_slave = i2c_dw_reg_slave,
                  ^~~~~~~~~~~~~~~~
   drivers/i2c/busses/i2c-designware-slave.c:351:15: note: (near initialization for 'i2c_dw_algo')
>> drivers/i2c/busses/i2c-designware-slave.c:352:2: error: unknown field 'unreg_slave' specified in initializer

.unreg_slave = i2c_dw_unreg_slave,
^
drivers/i2c/busses/i2c-designware-slave.c:352:17: warning: excess elements in struct initializer
.unreg_slave = i2c_dw_unreg_slave,
^~~~~~~~~~~~~~~~~~
drivers/i2c/busses/i2c-designware-slave.c:352:17: note: (near initialization for 'i2c_dw_algo')
cc1: some warnings being treated as errors

vim +/i2c_slave_event +285 drivers/i2c/busses/i2c-designware-slave.c

279 dev_dbg(dev->dev,
280 "%#x STAUTS SLAVE_ACTTVITY=%#x : RAW_INTR_STAT=%#x"
281 " : INTR_STAT=%#x\n",
282 enabled, slave_activity, raw_stat, stat);
283
284 if ((stat & DW_IC_INTR_RX_FULL) && (stat & DW_IC_INTR_STOP_DET))

 > 285			i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val);
   286	
   287		if (stat & DW_IC_INTR_RD_REQ) {
   288			if (slave_activity) {
   289				if (stat & DW_IC_INTR_RX_FULL) {
   290				    val = dw_readl(dev, DW_IC_DATA_CMD);
   291	
   292					if (!i2c_slave_event(dev->slave,
 > 293					    I2C_SLAVE_WRITE_RECEIVED, &val)) {
   294						dev_vdbg(dev->dev, "Byte %X acked!",
   295						val);
   296						}
   297					dw_readl(dev, DW_IC_CLR_RD_REQ);
   298					stat = i2c_dw_read_clear_intrbits_slave(dev);
   299				} else {
   300					dw_readl(dev, DW_IC_CLR_RD_REQ);
   301					dw_readl(dev, DW_IC_CLR_RX_UNDER);
   302					stat = i2c_dw_read_clear_intrbits_slave(dev);
   303				}
   304				if (!i2c_slave_event(dev->slave,
 > 305				    I2C_SLAVE_READ_REQUESTED, &val))
   306					dw_writel(dev, val, DW_IC_DATA_CMD);
   307			}
   308		}
   309	
   310		if (stat & DW_IC_INTR_RX_DONE) {
 > 311			if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED,
   312			    &val))
   313				dw_readl(dev, DW_IC_CLR_RX_DONE);
   314	
 > 315			i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
   316			stat = i2c_dw_read_clear_intrbits_slave(dev);
   317			return 1;
   318		}
   319	
   320		if (stat & DW_IC_INTR_RX_FULL) {
   321			val = dw_readl(dev, DW_IC_DATA_CMD);
   322			if (!i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_RECEIVED,
   323				&val))
   324				dev_vdbg(dev->dev, "Byte %X acked!", val);
   325		} else {
   326			i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
   327			stat = i2c_dw_read_clear_intrbits_slave(dev);
   328		}
   329	
   330		//~ if (stat & DW_IC_INTR_TX_OVER)
   331			//~ dw_readl(dev, DW_IC_CLR_TX_OVER);
   332	
   333		return 1;
   334	}
   335	
   336	static irqreturn_t i2c_dw_isr_slave(int this_irq, void *dev_id)
   337	{
   338		struct dw_i2c_dev *dev = dev_id;
   339		int ret;
   340	
   341		i2c_dw_read_clear_intrbits_slave(dev);
   342		ret = i2c_dw_irq_handler_slave(dev);
   343		if (ret > 0)
   344			complete(&dev->cmd_complete);
   345	
   346		return IRQ_RETVAL(ret);
   347	}
   348	
   349	static struct i2c_algorithm i2c_dw_algo = {
   350		.functionality = i2c_dw_func,
 > 351		.reg_slave = i2c_dw_reg_slave,
 > 352		.unreg_slave = i2c_dw_unreg_slave,

353 };
354
355 int i2c_dw_probe_slave(struct dw_i2c_dev *dev)

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#11 lore raw

Re: [PATCH v10 5/6] i2c: designware: add SLAVE mode functions

Quoted 2 lines · kbuild test robot

Hi Luis,

Luis, it seems you didn't rebase your patches against Wolfram's i2c-next tree.

Please, rebase and retest.

Quoted 189 lines

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.12-rc4 next-20170608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Luis-Oliveira/i2c-des
ignware-add-I2C-SLAVE-support/20170609-143533
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
i2c/for-next
config: x86_64-randconfig-x012-201723 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:

        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/i2c/busses/i2c-designware-slave.c: In function 'i2c_dw_irq_handler_slave':

Quoted 3 lines
Quoted 3 lines

drivers/i2c/busses/i2c-designware-slave.c:285:3: error: implicit declaration of function 'i2c_slave_event' [-Werror=implicit- function-declaration]

      i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val); ^~~~~~~~~~~~~~~

Quoted 3 lines
Quoted 3 lines

drivers/i2c/busses/i2c-designware-slave.c:285:31: error:
'I2C_SLAVE_WRITE_REQUESTED' undeclared (first use in this function)

      i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val); ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-designware-slave.c:285:31: note: each undeclared identifier is reported only once for each function it appears in

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:293:9: error:
'I2C_SLAVE_WRITE_RECEIVED' undeclared (first use in this function)

            I2C_SLAVE_WRITE_RECEIVED, &val)) {
            ^~~~~~~~~~~~~~~~~~~~~~~~

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:305:8: error:
'I2C_SLAVE_READ_REQUESTED' undeclared (first use in this function)

           I2C_SLAVE_READ_REQUESTED, &val))
           ^~~~~~~~~~~~~~~~~~~~~~~~

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:311:36: error:
'I2C_SLAVE_READ_PROCESSED' undeclared (first use in this function)

      if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED, ^~~~~~~~~~~~~~~~~~~~~~~~

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:315:31: error:
'I2C_SLAVE_STOP' undeclared (first use in this function)

      i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val); ^~~~~~~~~~~~~~ drivers/i2c/busses/i2c-designware-slave.c: At top level:

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:351:2: error: unknown field 'reg_slave' specified in initializer

     .reg_slave = i2c_dw_reg_slave,
     ^

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:351:15: warning: excess elements in struct initializer

     .reg_slave = i2c_dw_reg_slave,
                  ^~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-designware-slave.c:351:15: note: (near initialization for 'i2c_dw_algo')

Quoted 2 lines
Quoted 2 lines

drivers/i2c/busses/i2c-designware-slave.c:352:2: error: unknown field 'unreg_slave' specified in initializer

     .unreg_slave = i2c_dw_unreg_slave,
     ^
   drivers/i2c/busses/i2c-designware-slave.c:352:17: warning: excess elements in struct initializer
     .unreg_slave = i2c_dw_unreg_slave, ^~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-designware-slave.c:352:17: note: (near initialization for 'i2c_dw_algo')
   cc1: some warnings being treated as errors

vim +/i2c_slave_event +285 drivers/i2c/busses/i2c-designware-slave.c

   279 dev_dbg(dev->dev,
   280 "%#x STAUTS SLAVE_ACTTVITY=%#x :
RAW_INTR_STAT=%#x"
   281 " : INTR_STAT=%#x\n",
   282 enabled, slave_activity, raw_stat,
stat);
   283
   284 if ((stat & DW_IC_INTR_RX_FULL) && (stat &
DW_IC_INTR_STOP_DET))
 > 285 i2c_slave_event(dev->slave,
I2C_SLAVE_WRITE_REQUESTED, &val);
   286
   287 if (stat & DW_IC_INTR_RD_REQ) {
   288 if (slave_activity) {
   289 if (stat & DW_IC_INTR_RX_FULL) {
   290     val = dw_readl(dev,
DW_IC_DATA_CMD);
   291
   292 if
(!i2c_slave_event(dev->slave,
 > 293     I2C_SLAVE_WRITE_RECE
IVED, &val)) {
   294 dev_vdbg(dev-

Quoted 1 line

dev, "Byte %X acked!",

   295 val);
   296 }
   297 dw_readl(dev,
DW_IC_CLR_RD_REQ);
   298 stat =
i2c_dw_read_clear_intrbits_slave(dev);
   299 } else {
   300 dw_readl(dev,
DW_IC_CLR_RD_REQ);
   301 dw_readl(dev,
DW_IC_CLR_RX_UNDER);
   302 stat =
i2c_dw_read_clear_intrbits_slave(dev);
   303 }
   304 if (!i2c_slave_event(dev->slave,
 > 305     I2C_SLAVE_READ_REQUESTED,
&val))
   306 dw_writel(dev, val,
DW_IC_DATA_CMD);
   307 }
   308 }
   309
   310 if (stat & DW_IC_INTR_RX_DONE) {
 > 311 if (!i2c_slave_event(dev->slave,
I2C_SLAVE_READ_PROCESSED,
   312     &val))
   313 dw_readl(dev,
DW_IC_CLR_RX_DONE);
   314
 > 315 i2c_slave_event(dev->slave,
I2C_SLAVE_STOP, &val);
   316 stat =
i2c_dw_read_clear_intrbits_slave(dev);
   317 return 1;
   318 }
   319
   320 if (stat & DW_IC_INTR_RX_FULL) {
   321 val = dw_readl(dev, DW_IC_DATA_CMD);
   322 if (!i2c_slave_event(dev->slave,
I2C_SLAVE_WRITE_RECEIVED,
   323 &val))
   324 dev_vdbg(dev->dev, "Byte %X
acked!", val);
   325 } else {
   326 i2c_slave_event(dev->slave,
I2C_SLAVE_STOP, &val);
   327 stat =
i2c_dw_read_clear_intrbits_slave(dev);
   328 }
   329
   330 //~ if (stat & DW_IC_INTR_TX_OVER)
   331 //~ dw_readl(dev, DW_IC_CLR_TX_OVER);
   332
   333 return 1;
   334 }
   335
   336 static irqreturn_t i2c_dw_isr_slave(int this_irq, void
*dev_id)
   337 {
   338 struct dw_i2c_dev *dev = dev_id;
   339 int ret;
   340
   341 i2c_dw_read_clear_intrbits_slave(dev);
   342 ret = i2c_dw_irq_handler_slave(dev);
   343 if (ret > 0)
   344 complete(&dev->cmd_complete);
   345
   346 return IRQ_RETVAL(ret);
   347 }
   348
   349 static struct i2c_algorithm i2c_dw_algo = {
   350 .functionality = i2c_dw_func,
 > 351 .reg_slave = i2c_dw_reg_slave,
 > 352 .unreg_slave = i2c_dw_unreg_slave,
   353 };
   354
   355 int i2c_dw_probe_slave(struct dw_i2c_dev *dev)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel
Corporation

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#12 lore raw

Re: [PATCH v10 5/6] i2c: designware: add SLAVE mode functions

In reply to Luis Oliveira
Quoted 10 lines · Luis Oliveira

- Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
- Slave functions added to core library file
- Slave abort sources added to common source file
- New driver: i2c-designware-slave added
- Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module when supported by the architecture.

All the SLAVE flow is added but it is not enabled via platform driver.

drivers/i2c/busses/i2c-designware-slave.c line 331

Quoted 8 lines
drivers/i2c/busses/i2c-designware-slave.c new file +7 -0
+	} else {
+		i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val);
+		stat = i2c_dw_read_clear_intrbits_slave(dev);
+	}
+
 
+	//~ if (stat & DW_IC_INTR_TX_OVER)
+		//~ dw_readl(dev, DW_IC_CLR_TX_OVER);

What is this?

Quoted 3 lines
drivers/i2c/busses/i2c-designware-slave.c new file +3 -0
+
+	return 1;
+}
Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#13 lore raw

PATCH v10 6/6 i2c: designware: enable SLAVE in platform module

In reply to Luis Oliveira

- Slave mode selected in platform module if the support is detected in the DT.

---
v9-v10
- Removed "default y" from Kconfig because it was not needed (only for tests)

 drivers/i2c/busses/Kconfig                  |  1 +
 drivers/i2c/busses/i2c-designware-core.h    |  2 ++
 drivers/i2c/busses/i2c-designware-platdrv.c | 41 +++++++++++++++++++++++++----
 3 files changed, 39 insertions(+), 5 deletions(-)
drivers/i2c/busses/Kconfig +1 -0
index 88e5062015f8..f3f22085e227 100644
@@ -471,6 +471,7 @@ config I2C_DESIGNWARE_CORE
 config I2C_DESIGNWARE_PLATFORM
 	tristate "Synopsys DesignWare Platform"
 	select I2C_DESIGNWARE_CORE
+	select I2C_DESIGNWARE_SLAVE
 	depends on (ACPI && COMMON_CLK) || !ACPI
 	help
 	  If you say yes to this option, support will be included for the
drivers/i2c/busses/i2c-designware-core.h +2 -0
index 8c6fc8384b1e..944af016eac0 100644
@@ -228,6 +228,7 @@
  * @disable: function to disable the controller
  * @disable_int: function to disable all interrupts
  * @init: function to initialize the I2C hardware
+ * @mode: operation mode - DW_IC_MASTER or DW_IC_SLAVE
  * 
  * HCNT and LCNT parameters can be used if the platform knows more accurate
  * values than the one computed based only on the input clock frequency.
@@ -282,6 +283,7 @@ struct dw_i2c_dev {
 	void			(*disable)(struct dw_i2c_dev *dev);
 	void			(*disable_int)(struct dw_i2c_dev *dev);
 	int			(*init)(struct dw_i2c_dev *dev);
+	int			mode;
 };
 
 #define ACCESS_SWAP		0x00000001
drivers/i2c/busses/i2c-designware-platdrv.c +36 -5

72 lines not on this page · raw message

Signature · 1 line
2.13.0